fe7ad8e4a3
Backend Report: - Application/Reports/Dtos/DashboardStatsDto: 5 KPI + PhaseCount + SupplierCount + ProjectCount + MonthlyValue - Application/Reports/Queries/GetDashboardStats handler: total/active/overdue/published this month/totalValueActive + byPhase + top 5 NCC/du an + 12 thang monthly (fill zero khi thang empty) - Application/Reports/Services/IContractExcelExporter interface - Infrastructure/Reports/ContractExcelExporter: ClosedXML workbook 10 cot, header style bold+blue, number format #,##0, formula SUM, auto-fit, freeze header - Application/Reports/Commands/ExportContractsToExcelCommand: filter phase/supplier/project/date range - Api/Controllers/ReportsController: GET /reports/dashboard, GET /reports/contracts/export - DI register IContractExcelExporter (Scoped) Frontend fe-admin: - types/reports.ts: DashboardStats type - components/BarChart.tsx: generic horizontal bar chart — chi Tailwind, khong thu vien ngoai - pages/DashboardPage.tsx REWRITE: 5 KPI card (FileText/TrendingUp/AlertTriangle/CheckCircle2/Coins) + by-phase bar + monthly 12-month chart + top 5 NCC + top 5 du an + skeleton loader - pages/ReportsPage.tsx MOI: filter phase/fromDate/toDate → export Excel button - Route /reports vao App.tsx E2E verified: - GET /api/reports/dashboard → 200 voi day du KPI + monthly fill 12 thang - GET /api/reports/contracts/export → 200 xlsx 7229 bytes (Microsoft Excel 2007+) Docs consolidation (theo yeu cau user): - docs/rules.md MOI: 9 section coding conventions (ngon ngu UI/code/DB/docs, BE Clean Arch, CQRS+MediatR, Validation FluentValidation, Error handling, Async, Entity rules, DI, Package pinning, FE React/TS erasableSyntaxOnly, path alias, TanStack Query, Permission guard, Toast+error, DB convention, Git commit format, Docs structure, Testing, Security) - docs/architecture.md MOI: layered overview ASCII art, request lifecycle (1 POST/api/contracts qua 10 step), workflow state machine 9 phase, permission model, data flow sequence diagram 4 actor (Drafter/Manager/CCM/BOD/HRA), deployment architecture Phase 5, skill library, non-functional table - docs/database/schema-diagram.md MOI: full ERD 19 table mermaid + data flow diagram + vong doi 1 HD (create → 7 transition → gen ma → publish) + index strategy table + relationship cardinality + soft delete behavior + SQL queries (inbox/dashboard/gen ma) + migration history - docs/gotchas.md UPDATE: 17 → 26 pitfalls, them section "Claude Code harness quirks" (Edit File not read, DI build pass nhung runtime fail) + "Contract workflow" (ma HD gen 2 lan, BE-FE NEXT_PHASES sync, race condition) + "Permission matrix" (cache real-time, MenuKey typo) - docs/STATUS.md: Phase 4 MVP done, docs entry points section liet ke het, next Phase 5 Production - docs/HANDOFF.md: phase table them Phase 4 row, file tree update voi Reports, test points day du, git state commit 7 - docs/changelog/migration-todos.md: tick Phase 4 MVP items + them iteration 2 list - docs/changelog/sessions/2026-04-21-1430-phase4-report.md: session log voi thong so cumulative (BE 3100 LOC, 30 docs) - CLAUDE.md root: update Tai lieu quan trong section them rules.md, architecture.md, schema-diagram.md, .claude/skills (13 links now) Bug fix: - TS unused import ContractPhaseLabel trong DashboardPage - DI thieu register IContractExcelExporter — build pass but runtime would fail (added) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
194 lines
8.9 KiB
Markdown
194 lines
8.9 KiB
Markdown
# HANDOFF — Brief 5 phút cho session tiếp theo
|
||
|
||
**Last updated:** 2026-04-21 14:30 (cuối Phase 4 MVP + docs consolidation)
|
||
|
||
## Ở đâu rồi?
|
||
|
||
| Phase | Trạng thái |
|
||
|---|---|
|
||
| 0 Draft | ✅ Done |
|
||
| 1 Alpha Core foundation | ✅ Done |
|
||
| 1 Alpha Core đợt 2 (CRUD + Permission) | ✅ Done |
|
||
| 2 Form Engine MVP | ✅ Done |
|
||
| 2 Form Engine iteration 2 | 📝 Optional |
|
||
| 3 Workflow MVP (9 phase + code gen) | ✅ Done |
|
||
| 3 Workflow iteration 2 (SLA job + notify + attachment) | 📝 Optional |
|
||
| **4 Report + Polish MVP (Dashboard + Excel)** | ✅ Done |
|
||
| 4 Report iteration 2 (SLA report, PDF export) | 📝 Optional |
|
||
| 5 Production (CI/CD IIS) | 📋 Next |
|
||
|
||
## Run nhanh
|
||
|
||
```powershell
|
||
# Terminal 1 — API (auto seed 8 template lần đầu)
|
||
dotnet run --project src\Backend\SolutionErp.Api
|
||
|
||
# Terminal 2 — Admin FE
|
||
cd fe-admin && npm run dev # → http://localhost:8082
|
||
|
||
# Terminal 3 — User FE
|
||
cd fe-user && npm run dev # → http://localhost:8080
|
||
```
|
||
|
||
Login: `admin@solutionerp.local` / `Admin@123456`
|
||
|
||
Điểm cần test ngay (Phase 4 MVP):
|
||
- **Admin `/dashboard`** → 5 KPI card + By Phase bar + Monthly chart + Top NCC/dự án
|
||
- **Admin `/reports`** → filter phase/date → Export Excel .xlsx 10 cột có formula SUM
|
||
- **fe-user `/contracts/new`** → tạo HĐ draft (Phase 2 DangSoanThao, SLA +7d)
|
||
- **fe-user `/inbox`** → xem HĐ chờ role mình xử lý
|
||
- **`/contracts/{id}`** → click "Duyệt → tiếp" chạy state machine. Phase 8 gen `MaHopDong` RG-001
|
||
- **`/forms`** → render template .docx
|
||
- **`/system/permissions`** → ma trận Role × MenuKey
|
||
- **`/master/suppliers|projects|departments`** → CRUD
|
||
|
||
## Cần làm kế tiếp (ưu tiên)
|
||
|
||
### A. Phase 5 — Production (tuần 12-13, item lớn nhất còn lại)
|
||
|
||
**Đọc trước:** `docs/changelog/migration-todos.md` section Phase 5.
|
||
|
||
- [ ] `.gitea/workflows/deploy.yml` CI/CD build + deploy IIS
|
||
- [ ] `scripts/deploy-iis.ps1` stop app pool → xcopy → start
|
||
- [ ] Windows Server IIS + URL Rewrite + ARR (reverse proxy FE → .NET)
|
||
- [ ] HTTPS cert via win-acme hoặc mua
|
||
- [ ] `appsettings.Production.json` + user secrets + JWT secret rotation
|
||
- [ ] Rate limiting middleware (auth endpoint 5 req/min/IP)
|
||
- [ ] Security audit OWASP top 10
|
||
- [ ] Health check endpoint `/health`
|
||
- [ ] Serilog → file rolling daily retention 30d
|
||
- [ ] SQL backup: daily full + 15min log
|
||
- [ ] Runbook: restart, rollback migration, restore backup
|
||
- [ ] UAT production 1 tuần với 2-3 user thật
|
||
- [ ] Go-live checklist
|
||
|
||
### B. Polish iterations (optional — khi rảnh)
|
||
|
||
**Phase 2 iter 2:** convert 3 .doc qua Word COM `DisplayAlerts=0` hoặc LibreOffice, field spec JSON + form builder FE dynamic, `{{#loop}}` block support, PDF convert, FE upload template multipart.
|
||
|
||
**Phase 3 iter 2:** `SlaExpiryJob` BackgroundService auto-approve, email (MailKit) + in-app (SignalR) notify, upload attachment endpoint + FE multipart (`wwwroot/uploads/contracts/{id}/`), RowVersion concurrency, render HĐ docx khi tạo (merge TemplateId + DraftData + ContractClause).
|
||
|
||
**Phase 4 iter 2:** SLA overdue report by role/phase, PDF HĐ export (LibreOffice), dashboard user-specific (role tôi).
|
||
|
||
### C. Phase 2 iteration 2 (form engine polish)
|
||
|
||
- Convert 3 file `.doc` qua Word COM `DisplayAlerts=0` + timeout, hoặc LibreOffice
|
||
- Field spec JSON per template + dynamic form builder FE
|
||
- `{{#loop}}...{{/loop}}` block support cho table lặp
|
||
- PDF convert via LibreOffice headless
|
||
- Admin upload template UI (multipart)
|
||
|
||
### D. Quick wins (không block phase)
|
||
|
||
- FE Users management + Roles CRUD (test permission với non-admin user thật)
|
||
- Filter Inbox theo phase FE
|
||
- Refresh token auto (FE axios interceptor retry 401)
|
||
|
||
## Lưu ý kỹ thuật quan trọng
|
||
|
||
**Đọc [`gotchas.md`](gotchas.md) trước khi:**
|
||
- Thêm package mới → check compat với .NET 10 (MediatR 14 fail → dùng 12)
|
||
- Debug 404 API → kiểm Program.cs có persist không (Dropbox issue)
|
||
- Expression tree error → tách switch ra ngoài LINQ
|
||
- TS enum error → dùng const-object pattern (`erasableSyntaxOnly`)
|
||
- Word COM stuck → kill + fallback LibreOffice
|
||
- Migration lỗi → check 3 file đầy đủ (Designer + Migration + Snapshot)
|
||
|
||
## File đang active
|
||
|
||
```
|
||
SOLUTION_ERP/
|
||
├── src/Backend/ (Clean Arch, 4 project, .NET 10)
|
||
│ ├── SolutionErp.Domain/
|
||
│ │ ├── Common/ BaseEntity, AuditableEntity
|
||
│ │ ├── Contracts/ ContractType, ContractPhase, ApprovalDecision + **Contract, ContractApproval, ContractComment, ContractAttachment, ContractCodeSequence** ← Phase 3
|
||
│ │ ├── Forms/ ContractTemplate, ContractClause ← Phase 2
|
||
│ │ ├── Identity/ User, Role, MenuItem, Permission, AppRoles, MenuKeys
|
||
│ │ └── Master/ Supplier, Project, Department, SupplierType
|
||
│ ├── SolutionErp.Application/
|
||
│ │ ├── Auth/ Login, Refresh, Me
|
||
│ │ ├── Common/ Exceptions, Behaviors, Interfaces, Models
|
||
│ │ ├── Contracts/ ContractFeatures (8 CQRS), IContractWorkflowService, IContractCodeGenerator, DTOs ← Phase 3
|
||
│ │ ├── Forms/ FormFeatures (List/Get/Render) ← Phase 2
|
||
│ │ ├── Master/ Suppliers, Projects, Departments CQRS
|
||
│ │ ├── Permissions/ GetMyMenuTree, matrix upsert
|
||
│ │ └── Reports/ **DashboardStats, ExportContractsToExcel, IContractExcelExporter** ← Phase 4
|
||
│ ├── SolutionErp.Infrastructure/
|
||
│ │ ├── Forms/ DocxRenderer, XlsxRenderer, FormRenderer ← Phase 2
|
||
│ │ ├── Identity/ JwtSettings, JwtTokenService
|
||
│ │ ├── Persistence/ DbContext, DbInitializer, Interceptors, Migrations (**5**)
|
||
│ │ ├── Reports/ **ContractExcelExporter** ← Phase 4
|
||
│ │ └── Services/ DateTimeService, ContractWorkflowService, ContractCodeGenerator ← Phase 3
|
||
│ └── SolutionErp.Api/
|
||
│ ├── Authorization/ MenuPermissionHandler + Requirement
|
||
│ ├── Controllers/ Auth, Suppliers, Projects, Departments, Menus, Roles, Permissions, Forms, Contracts, **Reports** (10 controller)
|
||
│ ├── Middleware/ GlobalExceptionMiddleware
|
||
│ ├── Services/ CurrentUserService, WebHostEnvironmentLocator
|
||
│ └── wwwroot/templates/ 5 file .docx/.xlsx ← Phase 2
|
||
├── fe-admin/ (11 page)
|
||
│ └── src/pages/
|
||
│ ├── LoginPage
|
||
│ ├── DashboardPage ← Phase 4 rewrite (KPI cards + BarChart)
|
||
│ ├── master/SuppliersPage, ProjectsPage, DepartmentsPage
|
||
│ ├── system/PermissionsPage
|
||
│ ├── forms/FormsPage ← Phase 2
|
||
│ ├── contracts/ContractsListPage, ContractDetailPage ← Phase 3
|
||
│ └── ReportsPage ← Phase 4
|
||
├── fe-user/ (5 page)
|
||
│ └── src/pages/
|
||
│ ├── LoginPage
|
||
│ ├── InboxPage ← Phase 3
|
||
│ └── contracts/ContractCreatePage, ContractDetailPage, MyContractsPage ← Phase 3
|
||
├── docs/ (30 file)
|
||
│ ├── STATUS.md, HANDOFF.md, rules.md, architecture.md
|
||
│ ├── CLAUDE.md, PROJECT-MAP.md
|
||
│ ├── workflow-contract.md, forms-spec.md
|
||
│ ├── database/{database-guide, schema-diagram}.md
|
||
│ ├── flows/ (7 file — README + 6 flow)
|
||
│ ├── changelog/migration-todos.md + sessions/ (6 session log)
|
||
│ └── gotchas.md
|
||
└── .claude/skills/ (3 skill — all full spec)
|
||
```
|
||
|
||
## Git state
|
||
|
||
```
|
||
(sẽ là commit 7) — Phase 4 Report MVP + docs consolidation
|
||
7e957a7 — Phase 3 Workflow MVP
|
||
5113e4c — Phase 2 Form Engine MVP
|
||
54d6c9b — Phase 1.2 CRUD + Permission
|
||
49a5f57 — Docs database-guide + flows
|
||
702411f — Phase 1 foundation
|
||
25dad7f — Phase 0 scaffold
|
||
|
||
Branch: main
|
||
Remote: chưa (Gitea URL chờ user — cần cho Phase 5)
|
||
```
|
||
|
||
## Credentials + URLs
|
||
|
||
```
|
||
admin@solutionerp.local / Admin@123456
|
||
```
|
||
|
||
- API: http://localhost:5443 (swagger `/swagger`)
|
||
- Admin FE: http://localhost:8082
|
||
- User FE: http://localhost:8080
|
||
- SQL LocalDB: `(localdb)\MSSQLLocalDB` / Database=`SolutionErp_Dev`
|
||
|
||
## Đánh giá nhanh
|
||
|
||
**Tốt:**
|
||
- Build pass 100% cả BE + FE
|
||
- E2E test full 9-phase workflow end-to-end — mã HĐ gen đúng format RG-001
|
||
- Docs đầy đủ: 26 file, session log mỗi chunk, gotchas tích lũy 17 pitfall
|
||
- Cả 2 FE đều có Contract detail page + timeline + comment thread + state machine action
|
||
|
||
**Rủi ro còn:**
|
||
- SLA chỉ set deadline — không có job auto-approve (Phase 3.2)
|
||
- Không có notification (email + in-app) — user phải F5 inbox
|
||
- Form render chỉ MVP — loop table + PDF chưa có
|
||
- Permission matrix chưa test thực với non-admin user
|
||
- 3 file .doc chưa convert (carryover Phase 2)
|
||
- Không có upload attachment endpoint (chỉ có entity + DTO)
|