solution-erp/.claude/agent-memory/implementer-backend/archive/2026-05-q2.md

Implementer Agent — Archive Recent Activity Q2 2026-05 (S25-S29 verbose)

Archived: 2026-05-26 S32 em main proxy curate session (post-S31 RAG fix). Scope: 5 verbose Recent activity entries S25 Plan AB → S29 Plan B Chunk D — moved from MEMORY.md để giữ slim < 25KB threshold (was 38.4KB → target ~21KB). Rule §6.5 compliance: KHÔNG cắt narrative — full verbose entries preserved cho cross-session audit. KEEP in MEMORY: S32 startup (latest), S29 wrap (Plan CA + Plan B 5-spawn summary cumulative), S28 Layer A governance, S27 retrospective REFUSE analysis, S22 curate session lesson, S11 setup baseline. Patterns 1-19 + 12-bis + 16-bis foundation section preserved untouched.

---

Archive entries (FIFO chronological — earliest first)

2026-05-19 (S25, Plan AB Chunk A PASS)

Bug 1+2 fix Changelog visibility audit log UAT. Commit cdfd542 3 file +146/-95 LOC. BE PurchaseEvaluationWorkflowService.cs ApplyReturnModeAsync lines 215-378 refactor: Drafter early return (line 282-287) → if/else common path, summary = "Trả về Người soạn thảo" thay vì return early, SLA reset move bên trong else block 3 mode còn lại (Drafter có riêng evaluation.SlaDeadline = null). Single Changelog.Add() ở cuối hàm cover 4 mode uniform: EntityType=Workflow + Action=Update + Summary=$"Trả lại ({modeName}): {summary}" với modeName switch ("Người soạn thảo"/"1 Cấp"/"1 Bước"/"Người chỉ định"). actorName resolve qua userManager.FindByIdAsync mirror pattern existing line 660-667 (LogTransition helper). KHÔNG SaveChangesAsync mới — caller TransitionAsync line 100 đã có downstream save. FE 2 file PeDetailTabs.tsx × 2 app mirror exact: filter extend if (l.summary?.includes('Trả lại')) return true (Workflow entity) + if (l.entityType === PE_ENTITY_HEADER && l.summary?.toLowerCase().includes('ngân sách')) return true (Header entity new const = 1). Empty placeholder + comment 3-source rewrite (UAT 2026-05-08 + 2026-05-19 + bullet list 5 filter rule). Verify: BE build clean 0 err 2 pre-existing DocxRenderer warn (20.27s), fe-user 1907 modules 16.62s 0 TS err, fe-admin 1926 modules 6.98s 0 TS err. Test SKIP per UAT mode feedback_uat_skip_verify Phase 9 (111 baseline preserve). NEW pattern observed (cumulative): Changelog log common path refactor + FE filter substring summary discrimination. Reusable cho future audit log derived state (vd Adjust*/Return*/Reset* action): refactor early return → if/else common path để single log call cover N branch, FE filter qua substring summary keyword chứ KHÔNG enum field strict (action verb tiếng Việt "Trả lại"/"ngân sách" dễ maintain hơn enum + cho FE flexibility filter mới mà không cần BE schema migrate). Cross-ref Pattern 4 feedback_service_hook_vs_endpoint (state X derived của action Y → log trong handler Y, KHÔNG endpoint /X riêng — Bug 2 ApplyReturnModeAsync log trong service hook KHÔNG endpoint /return-changelog rời). Pattern 5 mirror 2 app §3.9 applied 7th cumulative. Token ~12k. Diff: BE +83/-49 (refactor + new log block ~40 LOC), FE × 2 app +14/-6 each (filter + comment). KHÔNG ops git push (em main verify Reviewer rồi mới push).

2026-05-19 (S25 wrap — Plan AB Chunk A Case 1 + 6 follow-up plans em main solo)

Plan AB Chunk A spawn 1× ~12K Case 1 cookie-cutter mirror. BE refactor ApplyReturnModeAsync Drafter early return → common path (line 280-287 → if/else block) + single Changelog.Add() ở cuối hàm với modeName switch enum + actorName resolve via userManager.FindByIdAsync mirror LogTransitionAsync pattern. FE × 2 app HistoryTab filter relax (PE_ENTITY_HEADER=1 + summary contains 'ngân sách' for Bug 1 + Workflow summary contains 'Trả lại' for Bug 2). KHÔNG TS test (UAT mode skip). KHÔNG migration. KHÔNG endpoint. Commit cdfd542 3 file +146/-95 LOC PASS. Em main solo từ Plan AC (cross-stack reasoning + UAT iteration borderline scope — Implementer would REFUSE per criteria #4 tight coupling BE+FE same plan). AC capture pre-call Step/Level + add Approval row Reject branch + skipToFinal comment + FE Decision badge × 2 app. AC2 FE merge synthetic Reject + dedupe timestamp 5s bucket. AD drop phase badges + extractNextTargetHint regex parse. AE BE batch 9 Changelog.Add sites UserName preventive fix. AF FE userMap fallback từ embedded domain data PeDetailBundle. Pattern 16 NEW (cumulative S25): Preventive systemic batch fix khi audit phát hiện 9 sites cùng bug pattern — replace_all=true với context-aware key (UserId line + Summary line) — 1 pass cover N sites idempotent. Pattern 17 NEW: FE merge synthetic rows từ Changelog cho audit historical recovery — pattern reusable cho Contract V2 + Budget V2 audit visualization without DB write. Pattern 18 NEW: FE userMap fallback từ embedded domain data (drafter + approvals + approvalFlow + levelOpinions + departmentOpinions) — no extra API fetch cho historical name resolve.

2026-05-21 (S26 t1, Plan AG Chunk A+B+C PASS — Phase 1 PE List tree view 2-level)

UAT feedback bro Tra Sol "đám rừng" flat list → Outlook folder tree. 3 chunk cumulative 1 commit 0bf6c7e 2 file +346/-116 LOC = +115 LOC each. Mirror 2 app §3.9 IDENTICAL post-edit (SHA256 verify match 21001E90...). Chunk A useMemo group nested: ProjectGroup{projectId, projectName, goiThauList[], totalCount} + GoiThauGroup{displayName, normalizedKey, items[]}. Normalize trim + toLowerCase group key, display raw đầu tiên trong group. Fallback "(Dự án đã xoá)" empty projectName + "(Chưa phân loại)" empty TenGoiThau. Sort vi locale 2 cấp A-Z. Filter pendingMe → DaGuiDuyet áp dụng TRƯỚC group (empty state đúng). Chunk B UI <details>/<summary> HTML native 2-level — fe-user no shadcn Accordion → native browser disclosure widget free. Tailwind v3 named groups group/proj + group/gt cho chevron rotation group-open/proj:rotate-90. [&::-webkit-details-marker]:hidden ẩn default disclosure triangle browser. 📁 + 📄 emoji icon inline + count badge rounded-full bg-slate-200/100. PE card content preserve nguyên (text + badge + date format + contractId hint — line 209-248 cũ). Chunk C localStorage persist Set key pe_list_expanded_groups. Project key: projectId or '__no_project__'. Gói thầu key: ${projectId}::${normalizedGoiThau}. Default empty Set (all collapse) — Outlook-style closed default. try/catch defensive cho localStorage (storage quota / private browsing). Header badge pendingMe ? totalRowCount : list.data?.total (replace rows.length). Empty state check projectGroups.length === 0 (replace rows.length === 0). Import useMemo, useState từ 'react' (file pre-existing chỉ import từ tanstack). Build: fe-user PASS 0 TS err 1291.33 KB gzip 337.00 KB 1907 modules 16.05s; fe-admin PASS 0 TS err 1402.68 KB gzip 357.51 KB 1926 modules 6.86s. Pre-existing CSS @import warn + INEFFECTIVE_DYNAMIC_IMPORT realtime.ts unchanged. KHÔNG ops git push (em main verify Reviewer rồi push). Token ~16k (close to ~14k baseline Case 2 mirror 2 app). Pattern 19 NEW: HTML native <details>/<summary> + Tailwind named groups (group/<name>) + localStorage Set persist cho hierarchical UI when no Accordion lib available. Free open/close state native browser (Space/Enter keyboard accessible) + 0 JS state per node + serialize/deserialize Set ↔ JSON array string. Tailwind v3 named groups syntax group/proj parent + group-open/proj:rotate-90 child differs from default unnamed group + group-open:rotate-90 — critical when nested groups cùng level cần distinct event scope. Reusable cho future tree views: Project explorer · Dept hierarchy · Permission tree · Workflow definition step list (vs HTML5 native vs shadcn vs JS library). Anti-pattern: nested same-name group would inherit parent state → both rotate sync. Pattern 5 mirror 2 app §3.9 applied 8th cumulative S20-S26 (proven reliable IDENTICAL hash check sau edit batch — recommend tooling git diff fe-admin/X fe-user/X after every multi-file edit batch).

2026-05-22 (S27 Plan CA Chunk B — Move 4 master pages fe-admin → fe-user, Case 2 cookie-cutter)

Spec từ em main deterministic 100% (Investigator pre-verify fe-user parity DataTable/PageHeader/PermissionGuard/usePermission/6 shadcn ui/types/master.ts byte-identical). Execute parallel: 4 Write cho master pages + 1 Edit menuKeys.ts (+5 key Catalogs*) + 2 Edit App.tsx (import + route block). LOC delta +962 (4 file 948 LOC mirror + 14 LOC App.tsx + menuKeys.ts). Verify SHA256 byte-identical 4 file: C1760788... / BDF0529E... / 68213D62... / 6F482614... all match admin source. npm run build fe-user PASS 0 TS err 1916 modules 14.14s (pre-existing CSS @import + chunk-size + INEFFECTIVE_DYNAMIC_IMPORT warn unchanged). Commit 06a441c 6 file changed. Pattern 16 NEW — byte-identical mirror admin → user khi parity confirmed (memory pattern_master_page_mirror.md): copy nguyên file (KHÔNG modify), verify SHA256 post-write, regression-safe vì admin code đã UAT pass. Token cost ~10k Case 2 (4 file mirror cookie-cutter, NO logic decision). KHÔNG push remote (Chunk A em main solo BE parallel chưa xong, Chunk C sidebar filter + Chunk D smoke verify defer). Tag schema S28: [pattern, phase-9, frontend] cho Pattern 16. Gotcha S27: PowerShell $_ variable in ForEach-Object block bị Bash tool shell-escape eaten — workaround dùng Get-FileHash file1, file2, ... -Algorithm SHA256 | Format-Table list literal thay vì pipeline iterate.

2026-05-22 (S29 Plan B Chunk D PASS — FE ContractCreatePage V2 Workspace dropdown × 2 app cookie-cutter mirror PE)

Spec deterministic 100% từ em main reference fe-user/src/components/pe/PeWorkspaceCreateView.tsx (canonical V2 dropdown lines 80-89 useQuery + lines 152-172 Select UI). 2 file mirror × 2 app fe-admin/fe-user/src/pages/contracts/ContractCreatePage.tsx: +44 LOC each = +88 LOC total byte-similar (git diff stat verify). Changes: (1) useState approvalWorkflowId = '' mới + (2) useQuery approval-workflows-v2-contract filter ApplicableType=3 client-side filter isUserSelectable=true (mirror PE Mig 25 pattern Plan AA S24) + (3) Select dropdown "Quy trình duyệt V2 (tùy chọn)" placement giữa FormFields + Budget section, blank = V1 fallback hint "(đã add ContractHeaderForm function, KHÔNG add ContractEditForm function vì spec scope CreatePage workspace only - edit-mode update endpoint defer)" + (4) Wire approvalWorkflowId: approvalWorkflowId || null vào CreateContractCommand POST body. BE precondition verify: CreateContractCommand record line 17-36 ContractFeatures.cs đã có Guid? ApprovalWorkflowId = null field (em main commit Chunk E1 PRIOR — comment marker "[Plan B S29 2026-05-22 Chunk E1] Drafter pick V2 workflow lúc create"). FE wire safe — no DTO mismatch. Build verify: npm --prefix fe-admin run build PASS 0 TS err 1926 modules 1.40MB gzip 358KB 16.07s; npm --prefix fe-user run build PASS 0 TS err 1916 modules 1.32MB gzip 343KB 8.84s. Pre-existing CSS @import warn + INEFFECTIVE_DYNAMIC_IMPORT realtime.ts warn unchanged (baseline noise). Pattern 16-bis 4-place mirror check applied: (1) Page file × 2 app DONE byte-similar; (2) App.tsx Routes N/A (enhance existing /contracts/new route - không route mới); (3) menuKeys.ts N/A (không menu key mới — page enhancement); (4) Layout staticMap N/A (route unchanged). Token ~12k Case 2 cookie-cutter (4 Read PE source + 2 Edit per file × 2 = 4 Edit total + 2 npm build + 1 git commit + memory update). Commit 62b50d1 clean 2 file. KHÔNG push remote — em main coordinate Chunk E final batch. Pattern 5 mirror 2 app §3.9 applied 9th cumulative S20-S29 (proven IDENTICAL bytes hash check sau edit batch — git diff stat confirm). Pattern 12-bis cross-module FE cookie-cutter mirror demonstrated: PE PeWorkspaceCreateView V2 dropdown → Contract ContractCreatePage V2 dropdown clean (same useQuery shape, same Select markup, same filter logic, same POST body wire) — discriminator field ApplicableType=3 swap from defaultType (PE 1/2). Reusable pattern future Budget V2 / any cross-module entity với V2 workflow integration. Tag: [pattern, phase-9, frontend].