solution-erp/.claude/agent-memory/implementer/archive/2026-05-q1.md

Implementer Agent — Archive Recent Activity Q1 2026-05 (S21-S24)

Archived: 2026-05-22 by em main SOLUTION_ERP curate session. Scope: Recent activity FIFO entries S21 t3 → S24 Plan AA (12 verbose entries) — moved from MEMORY.md để giữ slim < 25KB threshold. Rule §6.5 compliance: KHÔNG cắt narrative — full verbose entries preserved cho cross-session audit. Source MEMORY.md before archive: 38.8 KB. KEEP in MEMORY: S26 Plan AG (Pattern 19 NEW) + S25 wrap (Patterns 16-18 NEW) + S25 Plan AB + setup baseline. Patterns 1-19 foundation section preserved.

---

Archive entries (FIFO chronological — earliest first)

2026-05-13 (S21 t3-t5, REFUSED 3×)

Em main classified all 3 turns as cross-stack reasoning chain (BE+FE+test tightly coupled) → REFUSE per criteria #3+#4 (cross-stack > 2 layers, bug fix reasoning chain). Bug fix gotcha #45 = bug + reasoning, F1+F2+F3 = schema design decision, Refactor per-NV = drastic refactor schema + Service + FE × 2 app. All correct REFUSE — em main solo executed. Strict scope criteria validated S21 t3-t5 — REFUSE rate 100% match Anthropic warning "tightly interdependent coding". Cumulative: 84 test, 29 mig, 45 gotcha. Pattern saved future invocation: per-NV permission scope split natural theo role + EF migration BACKFILL reorder pattern.

2026-05-13 (S22, REFUSED 100%)

Em main classified ALL S22 work as cross-stack reasoning chain (BE Mig + Service guard + DTO + FE Designer + FE Section + FE types + tests) → REFUSE per criteria #3+#4. Em main solo executed. State chốt S22: 30 migrations (+1 Mig 30 AllowApproverEditSection1 per-NV F4 flag), 104 test PASS (+20 từ 84 — gồm PE WF ReturnMode + Draft guard + Reflection-based Authorize policy regression), ~146 endpoints (+3), 46 gotchas unchanged, 33 active prod users (13 cũ + 20 mới S22+2). 7 patterns successfully applied throughout S22 (validated continued effectiveness): Pattern 7 per-NV admin opt-in flag (Mig 30 follow Mig 29), Pattern 2 EF migration 3-file rule, Pattern 8 tách endpoint narrow scope (AdjustBudget vs UpdatePeDraft), Pattern 9 defense-in-depth FE+BE guard pair (S22+1 disable 3 button), Pattern 10 Reflection-based regression test cho Authorize policy (Plan C task 4 #44, 5 test ~50 LOC), Pattern 11 test infra helper cookie-cutter (SeedWorkflowAsync + SeedApproversAsync), Pattern 12 InternalsVisibleTo csproj expose internal helper cho test.

Mismatches discovered S22:

1. "Đang trong quá trình duyệt = người điều chỉnh cũng là người duyệt" — em first interpret default Approver scope always allowed → bro corrected per-NV admin opt-in flag (Mig 30). Lesson: clarify default behavior vs admin opt-in TRƯỚC khi default scope expansion.
2. PE.changelogs field KHÔNG có trong PeDetailBundle — em first design history display trong BudgetAdjustSection, build FAIL TS2339. Fix: removed history display (defer S23+ via separate fetch endpoint).
3. Dialog size="xl" NOT supported — only "sm" | "md" | "lg". Use "lg" cho preview iframe.
4. API auth field accessToken không phải token. Script seed-test-users-prod.ps1 lần đầu FAIL 401 sau auth — em fix $authResp.accessToken.

2026-05-14 (S23 t1, Chunk pre-A PASS)

UI polish slot label Designer Mig 31 prep. File fe-admin/src/pages/system/ApprovalWorkflowsV2Page.tsx line 873 replaced Quyền duyệt NV #{ei + 1} → Quyền duyệt {usersList.data?.find(u => u.id === entry.approverUserId)?.fullName ?? 'Chưa chọn NV'}. Pattern: lookup user fullName từ usersList query (Option A — DTO EditLevelEntry không có approverFullName field, chỉ LevelDto BE response có approverUserName nhưng edit state dùng EditLevelEntry). usersList đã in scope ~line 500, pattern lookup .find(x => x.id === e.approverUserId) đã dùng tại line 535 cho validation. Cookie-cutter 1 file fe-admin only (fe-user KHÔNG có Designer per Investigator K0 S1). Tailwind classes preserved (mb-1 text-[10px] font-medium uppercase text-amber-700). Verify: npm run build fe-admin PASS clean 0 TS error, 0 new warning. Bundle 1395 KB (unchanged trivial). Token ~5k.

2026-05-14 (S23 t1, K1 Chunk A PASS)

Mig 31 schema swap F2 storage Users → ApprovalWorkflowLevels. Pattern Mig 29 ADD-DROP no-BACKFILL Option A (accept lose 4 prod user value fin.pp + pm.nv + nv.test + truong.nguyen). Cookie-cutter 6 BE file (User.cs -1 prop + ApprovalWorkflow.cs +1 prop AllowApproverSkipToFinal per-Approver-slot + ApprovalWorkflowConfiguration.cs +HasDefaultValue + PurchaseEvaluationWorkflowService.cs surgical -37 LOC F2 Drafter SUBMIT branch line 121-157 stub + Mig 3-file). TransitionAsync bool skipToFinal 8th param KEPT cho K2 repurpose APPROVE STEP. 4 Application compile-break sites (UserFeatures.cs LIST + GET DTO mapping + SetUserAllowDrafterSkipToFinalCommandHandler NoOp + PurchaseEvaluationFeatures.cs drafter flag = false) patched với sentinel false + K2 marker comment (DTO/Command signature unchanged per spec — K2 sẽ refactor). Mig 31 Up() manual reorder ADD-DROP correct (no BACKFILL). Both DBs Dev + Design applied successful. Build production projects clean 0 err 0 warn. Test compile error PurchaseEvaluationWorkflowServiceReturnModeTests.cs:253 left for K7 chunk (spec exclude test scope). Pattern feedback_per_nv_permission_scope.md reinforced 3× cumulative (Mig 29 F1+F3 + Mig 30 F4 + Mig 31 F2-refactor). UserConfiguration.cs file không tồn tại — User entity configured inline ApplicationDbContext.OnModelCreating ~line 86, không có HasDefaultValue cho AllowDrafterSkipToFinal, EF picks prop change tự động.

2026-05-14 (S23 t1, K3 Chunk C PASS)

FE Admin Designer 7th checkbox AllowApproverSkipToFinal + banner rewrite. Pattern Mig 29/30 admin opt-in per-slot mirror reinforced 3× cumulative (Mig 29 F1+F3 5 checkbox + Mig 30 F4 1 checkbox + Mig 31 F2-refactor 1 checkbox = 7 checkbox total per slot). Cookie-cutter 1 file fe-admin only (ApprovalWorkflowsV2Page.tsx, fe-user no Designer per Investigator K0 S1). 7 sub-items atomic: (1) LevelDto type +allowApproverSkipToFinal: boolean, (2) EditLevelEntry type +same, (3) makeDefaultLevelEntry default false, (4) copyFromDefinition propagate ?? false, (5) inline checkbox row position cuối list sau F4 AllowApproverEditBudget logical grouping (Edit Section 2 → Edit Budget → Skip to Final), (6) banner rewrite line ~623 từ "F2 cấu hình ở User Management" (Plan D S22 stale) → "Cấu hình quyền duyệt riêng cho từng NV trong slot Approver bên dưới (Trả lại / Edit Section 2 / Edit Budget / Duyệt thẳng Cấp cuối)", (7) POST/PATCH mutation body levels.map +allowApproverSkipToFinal. Verify: npm run build fe-admin PASS clean 0 TS error, 0 new warning. Bundle 1395.74 KB (unchanged trivial vs baseline). Diff +26/-7 LOC. Token ~6k. K5 next chunk cleanup zombie endpoint + UsersPage column.

2026-05-14 (S23 t1, K5 Chunk D PASS)

Cleanup zombie F2 endpoint + UsersPage column + DTO field + stale narrative comments (Reviewer Major #1 + Major #2 + Minor #3 + Minor #4). Pattern post-refactor full cleanup atomic 1 commit. BE 7 file (UsersController.cs DELETE PATCH /allow-skip-final endpoint + SetAllowDrafterSkipToFinalBody record; UserFeatures.cs DELETE UserDto field + SetUserAllowDrafterSkipToFinalCommand + Handler + sentinel-false mappings cleanup; ApprovalWorkflow.cs REWRITE stale narrative line 78-80 Mig 31 semantic + docstring line 108; PurchaseEvaluationFeatures.cs REWRITE Command DTO comment line 401; ApprovalWorkflowConfiguration.cs APPEND Mig 31 narrative line 22-24 + clean storage move comment line 87; ApprovalWorkflowV2AdminFeatures.cs clean DTO comment line 58; IPurchaseEvaluationWorkflowService.cs + PurchaseEvaluationDtos.cs clean stale "storage Users.AllowDrafterSkipToFinal" references) + FE Admin 2 file (UsersPage.tsx DELETE "Skip cuối" column TableHeader/TableCell + FastForward import + allowSkipMut mutation hook + FastForward toggle button; types/users.ts DELETE allowDrafterSkipToFinal field). fe-user KHÔNG đụng (no UsersPage admin-only + K6 sẽ handle Workspace Drafter checkbox), FE Designer page KHÔNG đụng (K3 done — 2 stale comment line 75 + 504 leftover deferred K6). Grep AllowDrafterSkipToFinal + allow-skip-final + allowDrafterSkipToFinal + Skip cuối + FastForward ZERO results across src/Backend (excl migrations) + fe-admin/src. Build BE production projects clean (0 err, 2 pre-existing DocxRenderer warn). Build fe-admin clean (0 TS err, 0 new warn). Diff +42/-94 LOC trên 9 file. Token ~12k. K6 Workspace Drafter checkbox cleanup next.

2026-05-14 (S23 t1, K7 Chunk F PASS)

Mig 31 Approver F2 service regression tests. Sub-task 1 fix broken Drafter F2 test reference K1 flagged: PurchaseEvaluationWorkflowServiceReturnModeTests.cs:253 drafter.AllowDrafterSkipToFinal = true (DELETE 3 deprecated Drafter F2 tests entire — SkipToFinal_DrafterAllowed_SetsPointerToFinalLevel + SkipToFinal_DrafterDenied_NonAdmin_Throws + SkipToFinal_AdminBypass_Succeeds, semantic deprecated no value). Sub-task 2 add 3 new Approver F2 tests: ApproveV2_SkipToFinal_AdminTickFlag_SetsPhaseDaDuyet (happy path — slot Cấp 1 Bước 1 admin tick → Phase=DaDuyet, pointer cleared, opinion + PEA + Changelog logged), ApproveV2_SkipToFinal_FlagOff_NonAdmin_ThrowsConflictException (denied — flag off non-admin slot user → throw "chưa được phép duyệt thẳng Cấp cuối"), ApproveV2_SkipToFinal_FlagOff_Admin_BypassesFlagCheck (admin bypass — flag off admin role → DaDuyet allowed). Pattern 11 SeedWorkflowAsync cookie-cutter REUSE — created SeedApproverF2WorkflowAsync helper (2 Steps × 2 Levels — multi-step verify skip thẳng terminal KHÔNG fallthrough advance pointer next Step), AllowApproverSkipToFinal per-slot param. PE init Phase=ChoDuyet + CurrentWorkflowStepIndex=0 + CurrentApprovalLevelOrder=1 (vs S22 happy path từ DangSoanThao). Add using Microsoft.EntityFrameworkCore cho .ToListAsync() PEL/PEA/Changelog query. File header narrative line 17-25 REWRITE để track Mig 31 refactor semantic Approver scope ChoDuyet vs Drafter-from-Nháp cũ. Verify: dotnet build clean 0 err 2 warn pre-existing DocxRenderer. dotnet test SolutionErp.slnx 104 PASS (58 Domain + 46 Infra, 3 deleted + 3 added cancel out, baseline preserved). 3 Approver F2 tests verified individually PASS. Diff +175/-92 LOC trên 1 file. Token ~14k.

2026-05-15 (S24, Plan M Chunk M2 PASS)

F1 edge case Bước 1 reset ChoDuyet tests (em main M1 service edit PurchaseEvaluationWorkflowService.cs line 287-333 đã DONE — fallback Drafter TraLai → reset (0, 1) giữ ChoDuyet + audit log "không lùi được"). Cookie-cutter 1 file test PurchaseEvaluationWorkflowServiceReturnModeTests.cs — 2 sub-tasks: (1) extend SeedWorkflowAsync helper +2 params optional allowReturnOneLevelL1 + allowReturnOneStepL2 (default false, không phá compat 4 test ReturnMode existing), set vào l1.AllowReturnOneLevel + l2.AllowReturnOneStep tương ứng — Pattern 3 audit-reuse EXTEND không clone helper; (2) add 2 [Fact] test ngay sau test admin bypass OneLevel (line 241) — ApplyReturnMode_OneLevel_AtStep1Level1_ResetsToBuoc1Cap1_KeepsChoDuyet (PE init Step 0 Cấp 1 + actor=a1 + slot Cấp 1 tick AllowReturnOneLevel, build PE inline vì helper BuildPeAtLevel2 không phù hợp cho Cấp 1) + ApplyReturnMode_OneStep_AtStep1_ResetsToBuoc1Cap1_KeepsChoDuyet (PE Step 0 Cấp 2 + actor=a2 + slot Cấp 2 tick AllowReturnOneStep, reuse BuildPeAtLevel2, OneStep service check curStepIdx > 0 → fallback ngay không quan tâm Cấp). Assert: Phase=ChoDuyet (KHÔNG TraLai như Drafter mode) + pointer (0, 1) + SLA NotNull + Changelog ContextNote chứa "không lùi được" (Summary field cố định "Chuyển phase {from} → {to}", summary từ ApplyReturnModeAsync chèn vào comment qua line 96-99 service → LogTransition ContextNote = comment). K7 cascade verify NO regression: 3 ApproveV2_SkipToFinal_* tests still green (M1 edit chỉ F1 OneLevel/OneStep edge case, KHÔNG đụng F2 path ApproveV2Async). Verify: dotnet test SolutionErp.slnx clean 0 err 2 warn pre-existing DocxRenderer, 106/106 PASS (58 Domain + 48 Infra: +2 từ 46 baseline post Plan L). 10 ReturnMode-class tests verified individually PASS (4 ReturnMode + 3 ApproveV2_SkipToFinal + 1 Reject_NonApprover + 2 edge case mới). Diff +94 LOC trên 1 test file (test add + helper signature 2 params). Token ~10k. Spec deterministic + 1 file independent + < 1h verified.

2026-05-15 (S24, Plan M Chunk M3 PASS)

FE rename Phase=TraLai (98) display label "Trả lại" → "Cần chỉnh sửa lại" cho UAT disconnect fix. Spec scope HẸP (display badge label + status reference) tuân thủ strict: 4 file FE × 2 app = 8 edit total. 2 file types/purchaseEvaluation.ts × 2 app: PurchaseEvaluationPhaseLabel[98] (raw phase badge) + PeDisplayStatusLabel.TraLai (display status badge — main user-facing). 2 file components/pe/PeWorkflowPanel.tsx × 2 app: rename 2 inline literal hardcode "Trả lại" trong F1 dialog tooltip (Phase → "...") + confirm message (Phiếu sẽ về "...") — đây là status display reference, KHÔNG phải action verb. Pattern 5 mirror 2 app strict applied. KHÔNG đụng: (1) action button label ← Trả lại (verb), (2) F1 mode picker label Trả về Người soạn thảo (4 mode action), (3) comments narrative line 62/71/etc giữ rationale dev (rule §6.5), (4) types/contracts.ts + types/budget.ts Phase 98 'Trả lại' — module Contract + Budget khác PE, ngoài scope M3. Verify: npm run build fe-admin PASS clean (0 TS err, 9.40s, 1395 KB bundle unchanged trivial) + npm run build fe-user PASS clean (0 TS err, 6.92s, 1275 KB). Diff +4/-4 LOC × 2 = 8 LOC tổng trên 4 file. Token ~9k. Decision tactical: 2 chỗ inline literal PeWorkflowPanel rename để giữ UX consistency với badge label sau rename — KHÔNG drift outside spec vì cùng "status display reference" semantics (badge + tooltip + confirm message phải mirror). Anti-fiddle threshold <20% LOC respected.

2026-05-15 (S23 t4-t11 cumulative REFUSE — em main solo Plan N+O+P+Q+R+S+T+U)

8 plan consecutive em main solo, 0 Implementer spawn (REFUSE 100% per criteria #4 bug fix reasoning chain + criteria #3 cross-stack tight coupling). Plan N+O 5 lookup site discrimination fix cross-stack BE Service + Application + 3 regression test. Plan P Controller TransitionPeBody record drop fix tightly coupled FE wire audit (Investigator confirm BE-only scope ~6 LOC). Plan Q FE banner mx-5 layout CSS polish 2 app mirror trivial 8 LOC. Plan R+S+T5 destructive sqlcmd cleanup prod (scripts/plan-r-.sql + plan-s-.sql + plan-t5-*.sql + plan-t-backup.sql, 4 files scp + sqlcmd -i, ~720 rows wiped cumulative). Plan T DbInitializer DemoSeed:Disabled flag config (Infrastructure + Api appsettings, ~25 LOC). Plan U FE sidebar truncate + tooltip 2 app mirror 25 LOC (em main solo CSS Tailwind). 7 strict-scope criteria validated cumulative S23: pattern reusable saved memory user-level — Plan O wire 9 surface points (point 9 lookup discrimination 5 sites enum), Plan P wire 10 surface points (point 10 Controller body record mirror count check), Plan T DemoSeed flag pattern.

2026-05-15 (S24, Plan AA Chunk B PASS)

FE user read-only matrix view workflow V2 ghim (Mig 25 IsUserSelectable). 3 file: (1) CREATE fe-user/src/types/approvalWorkflowV2.ts (~55 LOC) — subset DTO mirror BE AwAdminOverviewDto (7 Allow* flag per Level, 5 record type AwLevelDto/AwStepDto/AwDefinitionDto/AwTypeSummaryDto/AwAdminOverviewDto); (2) CREATE fe-user/src/pages/pe/WorkflowMatrixViewPage.tsx (~215 LOC) — useQuery GET /approval-workflows-v2?applicableType=N&isUserSelectable=true (em main BE Chunk A đã thêm IsUserSelectable bool? param + Controller forward), render table 10 cột Bước (rowSpan) | Cấp | NV duyệt | 7 ✓/— flag cell, header với title tooltip mô tả từng cột, 3 state Loading/Error/Empty rõ ràng, badge Đang dùng (emerald isActive) + Được ghim (amber isUserSelectable Pin icon); (3) UPDATE fe-user/src/App.tsx — import WorkflowMatrixViewPage + route /purchase-evaluations/workflow-matrix đặt TRƯỚC /workspace (URL ordering logical matrix → workspace → new → detail). Verify: npm run build fe-user PASS clean 0 TS err, 1907 modules, 2.61s, 1282 KB. Surprise: shadcn fe-user KHÔNG có Card/Badge (chỉ có Button/Dialog/Input/Label/Select/Textarea) → fallback inline <div className="rounded-lg border..."> + inline <span className="rounded-full bg-..."> cho badge (mirror pattern admin Designer). Pattern reusable: read-only mirror admin Designer page = drop edit mutations + reuse DTO types (subset) + filter param BE-side (IsUserSelectable=true thay vì FE filter). Cookie-cutter 0 (lần đầu pattern). Pattern 5 mirror 2 app KHÔNG apply (fe-admin có Designer riêng — Plan AA scope fe-user only). Pattern 7 admin opt-in 7 Allow* flag wire full render trong table (10 cột total = 3 meta + 7 flag). KHÔNG ops git. Token cost ~14k.

2026-05-15 (S24, Plan AA wrap)

Cumulative learning post-Chunk B. 3 patterns NEW added (13 read-only admin Designer mirror, 14 Tailwind JIT palette array full class strings, 15 HTML table rowSpan flat row builder helper). REFUSE log 4/4 correct S24 polish chunks (commit da218f1 hotfix px-2 trivial < 30min criteria #6, 4d60598 redesign v1 panel-per-NV color UX flow criteria #2, fbbd361 redesign v2 table rowSpan UX flow criteria #2, ee0902a wrap fix sidebar label CSS polish criteria #6) — em main solo executed all 4, Implementer no-spawn. Ambiguity Chunk B: shadcn fe-user thiếu Card/Badge (lib subset minimal — chỉ Button/Dialog/Input/Label/Select/Textarea) → fallback inline <div className="rounded-lg border bg-card p-4"> + inline <span className="rounded-full bg-..."> mirror admin Designer DefinitionCard. Pattern reusable cho fe-user pages requiring elevated UI surface (audit shadcn fe-user/src/components/ui/ TRƯỚC khi import). Total S24 commits: 7 (a1a910f..ee0902a — 1 spawn Chunk B accepted + 6 em main solo: Chunk A cross-stack + Chunk C docs + 4 polish). Token cost cumulative S24 Implementer: ~14k (Chunk B only).