solution-erp/docs/changelog/sessions/2026-05-27-s34-plan-1234-deploy.md

Session 34 — Plan 1+2+3+4 ALL DONE end-to-end prod deploy

Date: 2026-05-27 Duration: ~6h (init + 4 plan execute + wrap) Branch: main Push range: edba4ae..1849197 (7 commits) CI Runs: #238 + #239 + #240 + #241 all PASS

Context

Anh main authorize sequence "1 → 2 → 3 → 4" sau S34 init 10-mục report. Continued với "OK làm tiếp" cho Plan 3 Item 3 + Plan 4. Em main thực thi cumulative 4 plan + 6 mục wrap (curate MEMORY mid-session + commit batch + push + UAT smoke + CICD verify + docs wrap).

Plan execution timeline

Plan 1 — Curate 4 MEMORY sub-agent (~30 phút em main proxy)

Agent	Before	After	Δ
🟩 CICD	32.9KB	27.3KB	-5.6KB
🟨 Implementer	30.5KB	24.6KB	-5.9KB
🟦 Investigator	26KB	21.8KB	-4.2KB
🟥 Reviewer	28.5KB	25.7KB	-2.8KB
Total	118KB	101KB	-15%

Archive 4 file archive/2026-05-q3.md (Investigator/Implementer/CICD) + archive/2026-05-q2.md (Reviewer first q2). Foundation Patterns 1-15+12-bis+16-bis + Smart Friend 6× + 10-surface-point per-NV preserved 100%.

Commit: 7b0781b (docs+memory CI skip per gotcha #41)

Plan 2 — Phase 10.2 G-O1 Danh bạ nội bộ (~1.5h)

BE (em main solo):

• Application/Office/DirectoryFeatures.cs — GetDirectoryQuery + DirectoryItemDto 12 field LEFT JOIN Users + Departments + EmployeeProfiles
• Api/Controllers/DirectoryController.cs — GET /api/directory?search=&departmentId= class-level [Authorize]

Permission (em main solo):

• MenuKeys Off + OffDanhBa Order=29 + DbInitializer SeedMenuTreeAsync

FE 2 app (🟨 Implementer Case 2 cookie-cutter mirror — Pattern 16-bis 5×):

• SHA256 IDENTICAL × 2 app:
  • types/directory.ts 7349d9f64e78
  • pages/office/InternalDirectoryPage.tsx 2aa7e0eed2c8
• Card grid responsive 1/2/3/4 col + avatar PALETTE 6 màu (Pattern 14 Tailwind JIT) + filter dept + search input + email mailto + phone tel + Ext: amber badge

Verify (🟩 CICD Run #238 PASS 3m30s):

• Run #238 sha=ea440da status=success
• 5 endpoint smoke 200 (contracts/PE/employees/menus + NEW /api/directory 34 row)
• Bundle hash rotate × 2: CqGMUMOr→ChA9_vP5 admin + C_HKyxBe→DCpX7akt user
• sqlcmd verify: MenuItems Off + Off_DanhBa seeded (Order 29 root + Order 1 leaf)

Commit: ea440da (15 file +676/-1)

Plan 3 — Phase 1.5 backlog 6/6 items

Items 6+2+1+4 batch (~1h em main solo + Implementer test bundle):

• Item 6 (em main): menuKeys × 2 app sync mirror BE 28 key cumulative
  • fe-admin add: Catalogs + 4 leaf + Workflows + Budgets + 3 Bg leaf (10 key)
  • fe-user add: Budgets + 3 Bg leaf + ApprovalWorkflowsV2 + 2 AwV2 + MenuVisibility + Workflows (8 key)
• Item 2 (em main): UpdateEmployeeProfileCommand 3 bool → bool? safe partial update + HasValue check trong handler (Reviewer minor #(b) S33 fixed)
• Item 1 (em main): EmployeesController per-action policy Hrm_HoSo.{Read|Create|Update|Delete} (gotcha #44 mitigation active)
• Item 4 (🟨 Implementer Case 3 test gen): +10 [Fact] 120 → 130 PASS:
  • EmployeeCodeGeneratorTests (3 [Fact]): first call + sequential + year boundary
  • CreateEmployeeProfileCommandTests (4 [Fact]): first + duplicate Conflict + soft-deleted restore + UserNotFound
  • ListEmployeesQueryTests (3 [Fact]): status filter + departmentId + search by code

Implementer Case 3 caught spec mismatch: spec said "allow new after soft-delete" vs actual code "throws Conflict-restore". Implementer chose CODE source of truth + renamed test discriminator message branch. Em main accept (admin UX khôi phục thay vì silent re-create).

Commit: 61e9ce5 (9 file +521/-9) + 🟩 CICD Run #239 PASS 3m48s

Item 5 UAT smoke (em main fallback after CICD partial):

Endpoint	Admin	nv.test	Verdict
/api/employees	200	403	gotcha #44 per-action policy ACTIVE ✓
/api/directory	200	200	class-level [Authorize] only đúng spec ✓

Item 3 BE 5 satellite CRUD scaffold (🟨 Implementer Case 2 ~22K spawn):

• Application/Hrm/EmployeeSatelliteFeatures.cs 621 LOC NEW — 5 region cookie-cutter (WorkHistory/Education/FamilyRelation/Skill/Document)
• EmployeesController.cs 70 → 234 LOC extend +15 endpoint scaffold (5 × POST/PUT/DELETE)
• Per-action policy override Hrm_HoSo.{Create|Update|Delete}
• BadRequest guard ID mismatch + Soft delete pattern (IsDeleted + DeletedAt + DeletedBy)
• Document satellite metadata-only (file upload IFileStorage body wire defer S35)

Pattern 12-ter NEW saved Implementer MEMORY: within-module N-satellite scaffold (vs Pattern 12-bis cross-module mirror).

Commit: e506cd8 (3 file +806) + 🟩 CICD Run #240 PASS

FE inline forms 5 satellite DEFER S35 (heavy ~1.5h em main scope reduction).

Plan 4 — G-H2 Mig 35 schema foundation (~1.5h em main solo)

Mig 35 AddHrmConfigs (em main solo):

4 entity HRM catalog:

• LeaveType — Code unique + Name + DaysPerYear decimal(5,2) + IsPaid + RequiresAttachment
• Holiday — Year + Date UNIQUE composite + Name + IsRecurring + IsPaid
• ShiftPattern — Code unique + Name + StartTime/EndTime TimeOnly + BreakMinutes + WorkDays comma string
• OtPolicy — Code unique + 3 Multiplier decimal(4,2) + 3 MaxHours int

4 EF Config UNIQUE indexes + IApplicationDbContext + ApplicationDbContext + Mig 35 3-file rule + apply Dev DB.

DbInitializer SeedHrmConfigsAsync ~120 LOC (em main solo):

19 sample row seed (NOT gated DemoSeed flag per gotcha #51):

• 5 LeaveType: ANNUAL 12d + SICK 30d + MATERNITY 180d + COMPASSIONATE 3d + UNPAID 0d
• 10 Holiday VN 2026: Tết Dương (1/1) + 5 Tết Nguyên đán placeholder (16-20/2) + Giỗ tổ (14/4) + 30/4 + 1/5 + 2/9 + Quốc khánh
• 3 ShiftPattern: HC 8-17 T2-T6 + CA1 6-14 T2-T7 + CA2 14-22 T2-T7
• 1 OtPolicy STANDARD: 1.5x/2.0x/3.0x + 4h/40h/200h cap (Luật Lao động VN 2019)

Permission menu (em main solo):

MenuKeys HrmConfig sub-group + 4 leaf:

• Hrm_Config Order=2 dưới Hrm Order=28 (parent)
• Hrm_Config_LeaveTypes Order=1
• Hrm_Config_Holidays Order=2
• Hrm_Config_Shifts Order=3
• Hrm_Config_OtPolicies Order=4

FE 2 app menuKeys sync 5 const mirror (Pattern 16-bis 5× preserve).

Verify:

• dotnet build PASS (2 warn DocxRenderer baseline, 0 error)
• dotnet test 130/130 PASS baseline preserve
• 🟩 CICD Run #241 PASS — Mig 35 applied prod (DbInitializer auto-migrate startup) + 4 catalog table + 6 menu Hrm_Config seeded prod verified via /api/menus
• Bundle hash rotate × 2: UPGBL5nz→RNTX6Fvo admin + C_Ei3hkW→29A1LuMm user

Commit: 07b3f3b (17 file +5739 LOC) + Run #241 PASS

Defer S35:

• Task 3 BE CQRS 4 catalog CRUD (16 endpoint) — Implementer Case 2
• Task 4 FE 2 app 4 catalog page (list/create/edit dialog)

Wrap docs (em main solo)

2 docs commit:

• 57099c5 Plan 1+2+3 wrap mid-session
• 1849197 Plan 1+2+3+4 FULL wrap end-session

State delta cumulative S34

Metric	S33	S34	Δ
Migrations	34	35	+1 (AddHrmConfigs)
Tables	67	71	+4 (LeaveType + Holiday + ShiftPattern + OtPolicy)
Endpoints	~153	~169	+16 (1 directory + 15 satellite)
FE pages	40	42	+2 (Directory × 2 app)
Menu keys	62	69	+7 (Off + OffDanhBa + HrmConfig + 4 leaf)
Tests	120	130 PASS	+10
Gotchas	52	52	unchanged
Memory user-level	26	27	+1 (Pattern 12-ter feedback)
Skills	6	6	unchanged
Sub-agent MEMORY total	~118KB	~109KB	-9KB (Plan 1 curate -15% rolling)

Multi-agent ROI S34 ~150K total

• 🟨 Implementer 3 spawn ~80K
  • Plan 2 G-O1 Task 3 FE 2 app cookie-cutter mirror (Pattern 16-bis 5×)
  • Plan 3 Item 4 test bundle Case 3 +10 [Fact]
  • Plan 3 Item 3 BE 5 satellite Case 2 scaffold (Pattern 12-ter NEW)
• 🟩 CICD Monitor 2 spawn ~40K
  • Run #238 G-O1 full verify (UAT smoke nv.test gotcha #44)
  • Run #239 Plan 3 batch partial → em main fallback manual
• 👤 Em main solo ~30K
  • BE Plan 2 G-O1 (DirectoryFeatures + Controller)
  • Phase 1.5 items 6+2+1+5 (menuKeys + bool? + policy + UAT smoke)
  • Plan 4 Mig 35 schema + DbInitializer seed + Permission menu
  • 7 commit/push batch + 4 docs update
• 🟦 Investigator: 0 spawn S34
• 🟥 Reviewer: 0 spawn S34

Patterns reinforced cumulative S34

Pattern	Status	Count
Pattern 12-bis cross-module mirror (PE → Contract)	preserved	4× (S29+S33)
Pattern 12-ter NEW within-module N-satellite scaffold	NEW	1× (S34)
Pattern 16-bis 4-place mirror cross-app	reinforced	5× (S29 Plan CA HF1 + S29 Plan B Chunk D + S33 Task 5 + S34 G-O1 + S34 menuKeys sync)
Smart Friend 6× clean	preserved	6× cumulative (S22+S25+S29×2+S33×2) — 0 new catches S34
10-surface-point per-NV checklist	preserved foundation	—
Pattern 11 test infra helper cookie-cutter	reinforced	Plan 3 Item 4 test bundle
Pattern 14 Tailwind JIT palette	reinforced	DirectoryPage avatar gradient 6 màu
bool→bool? safe partial Pattern NEW	NEW	Item 2 cross-project applicable

NEW capability prod end-to-end S34

1. Sidebar Văn phòng số > Danh bạ nội bộ /directory — 34 row card grid avatar + filter dept + search
2. 15 satellite endpoint scaffold /api/employees/{id}/{work-history|education|family-relations|skills|documents} — Hrm_HoSo.* per-action policy wired
3. 4 HRM catalog seeded prod — admin tinh chỉnh sau qua Designer UI (BE CRUD endpoint defer S35)
4. Per-action policy gotcha #44 mitigation ACTIVE — verified live nv.test 403 /api/employees + 200 /api/directory

Defer S35

1. Plan G-H2 Task 3+4 BE CRUD 4 catalog + FE Admin 4 page (~3-4h Implementer Case 2)
2. FE inline forms 5 satellite section Hồ sơ NS Phase 1.5 (~1.5h em main solo)
3. Test bundle satellite CRUD (~30 phút Implementer Case 3)
4. Curate 4 MEMORY again — CICD 30.9KB + Implementer 30.2KB borderline post-S34 spawn entries
5. RAG re-ingest SOLUTION_ERP — last index 2026-05-26 stale 1 ngày, S34 content (7 commit + Pattern 12-ter feedback) chưa retrievable qua RAG

Anh main coordinate (Phase 9 Ops backlog)

• SMTP host/user/pass → appsettings.Production.json
• Rotate creds approve cycle (admin + 30 demo + SA + vrapp + JWT secret + Gitea runner)
• Register Task Scheduler SQL backup daily 03:00
• win-acme cert auto-renew verify (notAfter 2026-07-23, auto-renew ~2026-06-23)
• UAT 2-3 user 1 tuần

4 sub-agent reuse-able S35

• 🟦 Investigator afaf6d52a6a59a844 — idle S34, last activity S33 t1 NamGroup audit
• 🟨 Implementer a5b7154286dad03f5 — last spawn Plan 3 Item 3 BE 5 satellite (NEW S34 agentId)
• 🟥 Reviewer a0aa13093d14f3bca — idle S34, last activity S33 Plan B Phase 2 review
• 🟩 CICD a520665a07ea4e8c4 — last spawn Plan 3 partial S34

Lessons learned S34

1. Sequence cuối cùng > Mục tiêu rộng: anh main set sequence "1→2→3→4" + "tiếp" → em main thực thi linear, không cố làm thêm scope ngoài. Plan 4 G-H2 BE CRUD + FE defer S35 = đúng scope realistic.
2. Implementer Case 2 cookie-cutter 5× = ~22K efficient: Pattern 12-ter proven viable cho N-satellite scaffold trong 1 mega file (vs N file split clutter).
3. bool→bool? safe partial pattern: Cross-project applicable cho any Update command (Contract/PE/Budget Update có thể apply tương tự).
4. Em main fallback manual UAT smoke khi CICD spawn partial: ROI cao khi token budget tight — direct curl 5 endpoint × 2 role = 10 cell matrix verify gotcha #44 active ≤5 phút.
5. Mid-session curate ROI: Plan 1 curate 4 MEMORY (-15%) trước heavy plan execution → mỗi spawn sau load context sạch hơn. Foundation Patterns preserved.