Files
solution-erp/.claude/agent-memory/reviewer/archive/2026-07.gist.md

16 KiB
Raw Blame History

distill-gen: 1 period: 2026-07 (45 review-record, S65→S133-era) source-verbatim: archive/2026-07.md (45 record, 39.791B, gen-0 — snapshot tại GATHER S140; 2 entry S139/S134b được reviewer tự-curate moved-not-cut từ L1 vào verbatim NGAY SAU đó [batch S140-curate, +7 dòng] = NGOÀI scope gist này, sống ở verbatim) pointer-style: substring (Ctrl-F) back-resolve vào archive/2026-07.md; mỗi cụm kết → substring:"" (40 anchor GATHER-verified count==1-line [mega-line: 1-line⇔1-entry] + em-main spot-check 8/8) fields-per-line: VIỆC · KẾT-LUẬN(+file:line/commit) · BÀI-HỌC · BẤT-NGỜ · [confidence]

Gist 2026-07 — reviewer (distilled S140 sleep-compress)

TỔNG-HỢP (5 ý — số/mốc truy về CỤM dưới)

  1. Kỳ = 45 review-record → 9 CỤM. Verdict-phổ: 2 FAIL (S108 fable-real first-run 1C+4M · S88 fabrication-by-merge) · ~14 PWC/PWF/GO-WITH-FIXES · ~17 PASS-clean. Teeth chứng qua fault-inject -RepoRoot 4/4 + independent-recompute + re-run 2-CHIỀU.
  2. PE = mảng domain lớn nhất (11 record S65→S133, CỤM 2a). Pattern lặp: fail-closed guard TOP-of-method · FE/BE byte-mirror bit-exact · single→multi consumer-sweep · menu-hide≠API-lock. Mig covered 54/56/59/60(+61)/63/67.
  3. Reviewer-craft đúc (CỤM 1+4): fidelity-gate 3-lớp (verbatim + pointer-arithmetic count==1 + ground-truth-code) · byte-conservation moved-not-cut (sha256 line-level + arithmetic full-accounting) · Windows byte-verify KHÔNG-MSYS · verify-command-as-CODE · negative-control cho token-count.
  4. #53 return-garble dai (S101/S123/S124/S128/S129) → luật "ghi diary TRƯỚC return" tự-rút từ S123 (CỤM 8); scribe từ journal khi garble.
  5. Anti-pattern governance-review tái diễn: mirror-a-toggle drops-reader · exact-token-sweep misses-paraphrased · cumulative-count-not-outward · fencepost/hero-ratio overclaim · Goodhart-rời-tập-đo · direction-of-error quyết mức lỗi.

CỤM 1 [cao] — Memory-curate fidelity + byte-conservation verify (S98 3-lane · S88)

VIỆC: gate 3-lane curate S98 (gist impl-fe 10rec→6cụm · cicd L1 moved-not-cut · mega-line re-tier) + L2 distill test-spec S88. KẾT-LUẬN: S98 3-lane PASS (1 minor gist + 3 minor cicd + 0-mismatch); S88 FAIL 1 fabrication-by-merge (gist gán "Mig 45" cho cluster 2-episode, thật Master=Mig 47). Evidence: 34/34 substring count==1 · sha256 line-level backup==archive + byte-arithmetic 19917→17059 EXACT (43091451=2858) · mega-line arithmetic full-accounting ×2 file (STATUS 9412/11090 · HANDOFF 6147/7775). BÀI-HỌC: fidelity-gate 3 lớp cho MỌI chỗ gist DIỄN-GIẢI vượt verbatim; QUALITY-gate SAU presence-gate (token-PRESENCE mù cross-episode mis-attribution); Windows byte-verify CẤM MSYS grep/sed/awk (TEXT-MODE strip \r) → .NET ReadAllBytes/wc -c/od -c; commonPrefix lấn 1-char → IndexOf(blurb) FULL line. BẤT-NGỜ: honest-empty "không" > bịa filler; verbatim TỰ mâu-thuẫn (S52-vs-S53) → gist FLAG discrepancy KHÔNG resolve-bịa. [cao] → substring:"anti-S88-fabrication-by-merge" · "token-split artifact" · "commonPrefix lấn 1-char" · "fabricates false specificity"

CỤM 2a [cao] — PE financial-invariant close-reviews (11 record)

VIỆC: chuỗi review PE cross-stack (EndsBeforeCeo Mig60/61 · badge/checkbox UAT · giá-đề-xuất Mig59 · budget Mig56 · Mig54 finalize · multi-winner · negative-quote · budget-freeze Mig67). KẾT-LUẬN: đa số PASS 0-issue; S133 PWF (0must/2should CÙNG root #81 indirect-writer WorkflowService:308 + DbInitializer:1323); S89-bis 4/4-confirm + 1 NEW joint-winner DEAD-END. Guard: S72* fail-closed throw BEFORE Phase=DaDuyet + server-recompute no-trust-client · S86 byte-mirror NotFound→Forbidden + canEditCcm bit-exact · S97-bis EndedByLevelFinalize set DUY-NHẤT service:873 (5 nhánh) + repro peFinButWentCeo · S91 codegen flushes ONLY seq-row · S117 UpsertQuote writes-0-budget-field · SHA256 FE 2-app IDENTICAL b7abbc2f/bcf812fd. BÀI-HỌC: terminal/finalize-lock gác FROM-state; single→multi = grep MỌI consumer (dừng ở detail-display = bug); "mọi nhánh set X" phải grep CẢ assignment-qua-BIẾN (#81 indirect); FE badge/gate mirror BE bit-for-bit; echo-all-siblings convention rots khi thêm field mới; backfill LIKE-VN-wildcard = false-pos-risk. BẤT-NGỜ: S76 spec "KHÔNG migration" FALSE (đọc changed-set thật, đừng tin scope-framing); S89-bis nút FE some(isWinner) nhưng BE hard-block. [cao] → substring:"peFinButWentCeo" · "opt-out→opt-in" · "UpdatePeSuggestedPriceCcm" · "server-recompute amount no-trust-client" · "flushes ONLY seq-row" · "joint-winner DEAD-END" · "echo-all-siblings convention rots" · "winnerQuoteTotal<CeoApprovalThreshold" · "DbInitializer:1323"

CỤM 2b [vừa] — Authz / prod-security reviews (S92 · S69 · S65)

VIỆC: review authz (hide 5 menu-group admin-only · Office golive public-grant · HRM Hồ-sơ upgrade-path). KẾT-LUẬN: 3/3 PASS. S92 A-E upheld + CatalogManager Danh-mục stripped (intended, flag em-main); S69 re-skin proof grep api-call+queryKey byte-equal + granted-root NOT inherit-root; S65 upgrade-path MUST MUTATE row. BÀI-HỌC: menu-hide ≠ API-lock (2 tầng độc lập); upgrade-path MUTATE row (if(!row.CanRead)) KHÔNG skip-existing khi prior-revoke pre-set false (S58-class); public-grant KHÔNG cascade sibling. BẤT-NGỜ: S69 accent thiếu -800 stop = silent no-class Tailwind v4. [vừa] → substring:"CatalogManager Danh-mục access stripped" · "granted root NOT inherit-root" · "upgrade-path MUST MUTATE row"

CỤM 3 [cao] — Harness governance adopt-reviews (H10/15/16/18/19)

VIỆC: review adopt/re-run harness (H18 detector-teeth wf_955643c3-f7d · H19 wf_5f308fd8-744 + fable-clone toggle · H16 MFE wf_13e3d35a · H15-v2 · H10). KẾT-LUẬN: PASS/PWC. H18 fault-inject 4/4 -RepoRoot proved FLAGS injected-stale + caught 1 CONCERN em-main missed (workflows/README:51 stale); H19 12/12 honest + hysteresis 0.85/5/2; fable-clone 3 Lane-A CONFIRMED + marker write-only dead; H16 denom-29 re-derived + BLOCKING vocab-fork memory-fidelity H6.7≠H16. BÀI-HỌC: exact-token sweep misses paraphrased → widen concept-phrase khi retire artifact; mirror-a-toggle copies WRITER, silently drops READER (persist cần CẢ write + read-on-session-start); hex→SHA disambiguation = recompute BOTH strip/no-strip; leading-verb-trap DEFEATED; index-vs-file sha = đọc frontmatter self-declared TRƯỚC flag. BẤT-NGỜ: marker fable-real-mode.on = WRITE-ONLY dead artifact. [cao] → substring:"exact-token sweep misses paraphrased labels" · "hex→SHA disambiguation" · "mirror-a-toggle copies the WRITER side" · "leading-verb-trap DEFEATED"

CỤM 4 [cao] — fable-real single-pass adversarial + D-review lanes

VIỆC: single-deep-pass Fable + 2-lane D-review adap 16-07 (spec-execute · errata-EOL wf_8a0249f6). KẾT-LUẬN: S108 FAIL 1C (email "đã sửa comment" khi hmw.js:31-32 chưa sửa) + 4M; S125 PASS-WITH-SELF-FIXES (re-stamp 58f5afd8); S127 GO-ADAP bác claim hub (rag.json:26 override ACTIVE); S128 GO-COMMIT + GO-WITH-FIXES; S129 GO-WITH-FIXES ×2 (P1 writer-only NỬA-VÁ, reader mfe-eval.ps1:193 thiếu -Encoding UTF8, BOM ef bb bf). BÀI-HỌC: verify-command trong spec = CODE chạy thử (2/4 sai thật); encoding-bệnh ở CMDLET không ở shell (Get-Content -Raw ANSI-decode UTF8-no-BOM → mojibake); sibling-test 2-CHIỀU (sibling-MATCH⇒file-bệnh · sibling-CŨNG-FAIL⇒verifier-bệnh); direction-of-error quyết mức lỗi (lệch CONSERVATIVE=minor); Get-FileHash so _index = SAI-LOẠI-HASH (body≠whole-file); doc assemble-từ-N-worker → grep stale-claim theo CLASS; consumer-sweep S87 áp CẢ ĐỀ-XUẤT-VÁ. BẤT-NGỜ: S108 đoạn drift-note (viết ĐỂ cảnh báo drift) là chỗ DUY NHẤT mô tả sai canonical. [cao] → substring:"assemble-từ-N-worker" · "stamp_verify.py" · "rag.json:26 override ACTIVE" · "SAI-LOẠI-HASH" · "mfe-eval.ps1:193"

CỤM 5 [vừa] — Supplier Excel-import S112 close-reviews (5-lane)

VIỆC: close-review PRE-deploy Supplier-import (Mig62/63) + PE sign-off, FINAL bó 2-feature. KẾT-LUẬN: GO-WITH-ADJUSTMENTS → FINAL GO 0-must. Independent MAJOR: Import button reuse Suppliers.Create guard nhưng endpoint=Admin/CatalogManager → non-functional cho fe-user drafter. NFC/NFD: test literal-NFC KHÔNG chứng file Excel thật → NormalizeHeader FormC:306/313. EDGE-5 gác ĐỈNH SVC:66 (bỏ sót admin-override SVC:290 → fix TOP). Evidence: 24 clamp-consts=EF-len byte-exact · 30 tokens==test byte-identical · Mig63 additive-nullable prod-safe · tests 458. BÀI-HỌC: reuse sibling menu-guard cho Admin-scoped action = under-restrict → derive từ ENDPOINT authz; self-flip token-test = internal-consistency KHÔNG external-acceptance; terminal-lock ĐỈNH method KHÔNG rải per-branch; Case-9 self-adjusting PASS ≠ real==expected → diff byte 2 mảng TAY. BẤT-NGỜ: A1 bỏ auto-terminal = UAT behavior-change by-design; CEO-skip decision mở đường skip MỚI. [vừa] → substring:"24 clamp-consts=EF-len byte-exact" · "KHÔNG rải per-branch" · "internal-consistency KHÔNG external-file-acceptance" · "Case-9 self-adjusting"

CỤM 6 [vừa] — Outward email-hub gates (H22/H23/H24 closure-cadence)

VIỆC: gate outward email SE→ai_infra ×4. KẾT-LUẬN: PASS/PWF, bắt lỗi TRƯỚC stamp. S116 PASS 0-over-claim (6/6 re-run MATCH HEAD 88bd8e6 · A7 246/246 pointers · crystallized 382713B); S126 gate FAIL bắt 3 thật ("Audit 2/2/0" session-cumulative NON-REPRODUCIBLE + "3 việc"=2 + "hub 17/17"=SE-self-obs) → stamp 945cf3ad; S131 PWF fencepost "8 nhãn/+4" khi atomic ĐÚNG HẾT; S131b PWF inflate "hàng loạt" + homophone x/s. BÀI-HỌC: số AGGREGATE cumulative KHÔNG vào outward (evidence bền = per-lane theo run-id); "đã đo" chỉ pass khi trỏ disk-measure; verbatim-quote owner so TỪNG CHỮ kể cả homophone; hero-ratio re-derive từ raw; persist-claim trên git-tracked = verify tracked+0-drift TRƯỚC. BẤT-NGỜ: fencepost đẻ 2×-overclaim DÙ mọi số atomic đúng. [vừa] → substring:"246/246 pointers 0-fail" · "session-cumulative" · "fencepost = liệt-kê từng nhãn" · "homophone x/s"

CỤM 7 [vừa] — do-token calibration + adap-wave-reply (S124/S125)

VIỆC: review plan adap-wave-reply + L2 fidelity + relabel do-token. KẾT-LUẬN: PWF (0C/3M/2m). do-token trap committed WHILE adopting do-token (spec "STATUS=26075 tok" nhưng re-Read truncation=70892, 2.72× under); relabel bằng negative-control 3-probe ('a'×150K→"150,006 tokens" content-independent) ⇒ notice-N = heuristic CẬN-TRÊN KHÔNG real-token; push-guard "ahead-of-broadcast" OVERCLAIM (trailing-K looser≠ahead). BÀI-HỌC: verify do-token = re-Read full + đọc dòng truncation; nhãn "real-N" tự nó = mislabel → negative-control phân biệt heuristic/tokenizer; "ahead" verify vs ACTUAL requirement; meta-count self-blindspot (R5 highest-value dropped); nấc "verified" trên cadence NEVER-RAN sai. BẤT-NGỜ: do-token bẫy CHÍNH lúc ĐANG adopt do-token; notice-N content-independent. [vừa] → substring:"committed WHILE adopting do-token" · "REFINEMENT ahead-of-broadcast" · "negative-control 3-probe"

CỤM 8 [cao] — Governance-code review (Goodhart/citation/acceptance-grep)

VIỆC: review governance-code (S123 backtick-guard+H24-3+retire-dạng-3 · S115 presence-not-age D1/D2/D3). KẾT-LUẬN: PWF. S123 3must/1MAJOR/3m + #53 garble TẠI TAO (đĩa KHÔNG cứu vì chưa ghi diary); S115 0C/2M/5m (M1 acceptance-grep 1/3 doc-line=false-PASS; M2 skip-element bolted-on contiguous-cut = correctness-inversion). BÀI-HỌC: ghi diary TRƯỚC return (chống #53); vá-1-lớp ⇒ grep MỌI matcher cùng-lớp TRONG diff; đổi-format-cho-trượt-mẫu = Goodhart rời-tập-đo; acceptance-grep bare-token + human-classify (verify TỪNG regex-alt vs TỪNG target-line); node --check HAS teeth; parallel() unverifiable-from-source nhưng robust-under-BOTH-truth-values = endorse-with-caveat. BẤT-NGỜ: acceptance-grep KHÔNG detect miss của CHÍNH deliverable mình. [cao] → substring:"Goodhart rời-tập-đo" · "detect its OWN deliverable's miss" · "node --check HAS teeth"

CỤM 9 [vừa] — Whole-session + close-review khác (gộp phổ verdict)

VIỆC: các record còn lại (whole-session S97/S97-bis · S90 re-key · S91 stability · S116-PE-neg-quote 3-lane · S117-close · S133-freeze). KẾT-LUẬN: verdict-phổ toàn kỳ: FAIL ×2 (S108 · S88) · PWC/PWF/GO-WITH-FIXES ~14 · PASS-clean ~17; mọi PASS đều kèm evidence độc lập (re-run/re-grep/sqlcmd), 0 rubber-stamp. BÀI-HỌC: re-key/re-derive luôn đi kèm consumer-sweep; UAT-facing fix cần repro-test RED→GREEN trước. BẤT-NGỜ: phổ 45-record cho thấy tỉ lệ PASS-clean ~38% — reviewer "đắt" nhất ở chỗ bắt 2 FAIL + ~14 có-fix, không phải ở đóng dấu. [vừa] → substring:"re-key SelectedSupplierId" · "useIsFetching gate"

COVERAGE-TOKENS (per-file đóng-kín — nguồn: archive/2026-07.md của reviewer)

Gotcha: #50(bẫy "gotcha #50"≠"gotcha#50") · #53(S101-LaneC/S123/S124/S128/S129) · #69 · #70 · #73 · #81(S117 · indirect-assignment S133). Mig: 54 56 59 60+61(wrong-table→fix) 62/63(778fc98) 67. SHA/hash/wf: f229b07 5ee32c0 e350660 b7abbc2f bcf812fd DxUomy4C/DkyQ0xCd/l_kwCZIF wf_31ea3985-92c wf_955643c3-f7d wf_5f308fd8-744 6909299a/ee00d253/a7ff304b/eed277f7 5f511fe5→5f8b8504 wf_13e3d35a 88bd8e6 382713B wf_8a0249f6 ef bb bf c0ac7486447e 181a6d19/f29247cf bf93abd 945cf3ad 58f5afd8 wf_f9c0b939-181 e46863c8 778fc98. file:line: backup-L73/74==archive-L7/8 · STATUS 9412/11090 · HANDOFF 6147/7775 · PE-service 671/873/911/943/1049 · projections :1153/:647/:767 · workflows/README:51 · budget.json:35-37 · hmw.js:31-32 · PurchaseEvaluationDetailFeatures.cs:282-366 · ContractFeatures.cs:46 · CreateContractFromEvaluation:88-90 · FE:201/BE:206 · ExpectedHeaderTokens:37-66 · RealFileHeaderTokens:420-451 · NormalizeHeader:306/:313 · SVC:53/:66/:92/:265/:290 · ultra-on:21/README:208 · WorkflowService:308 · DbInitializer:1323 · mfe-eval.ps1:193 · rag.json:26. Guard: fail-closed BEFORE Phase=DaDuyet · server-recompute no-trust-client · EDGE-5 TOP-of-method · byte-mirror bit-exact · all-or-nothing gate:137-152 · upgrade-path MUTATE row · UpsertQuote 0-budget-field · backfill LIKE marker · fingerprint-Ordinal + FormC · node --check · archive-gate 12/12 + A7 246/246 · fault-inject -RepoRoot 4/4. Root-cause: cut-not-moved f229b07 · fabrication-by-merge · single→multi-stops-at-display · echo-siblings-rots · #81 via-BIẾN · sibling-guard under-restrict · terminal-rải-per-branch · mirror-a-toggle drops-reader · exact-token misses-paraphrased · fencepost/hero-ratio · session-cumulative · Goodhart-rời-tập-đo · do-token mislabel-chunk-as-whole · heuristic-cận-trên≠real · P1 writer-only reader-thiếu-UTF8 · Get-FileHash SAI-LOẠI · Get-Content-Raw ANSI-mojibake · NFC-literal≠external. Surprise: honest-empty>bịa · spec-KHÔNG-migration-FALSE · drift-note-chỗ-duy-nhất-sai · marker-WRITE-ONLY-dead · joint-winner-FE-hiện-BE-block · accent-800-silent · A1-UAT-behavior-change · fencepost-2×-dù-atomic-đúng · do-token-bẫy-lúc-adopt · notice-N-content-independent · acceptance-grep-mù-deliverable-mình. Verdict-phổ: FAIL ×2 · PWC/PWF/GWF ~14 · PASS ~17. Drop thấp: 0 cụm.