Files
solution-erp/.claude/agent-memory/implementer-backend/archive/2026-06.md
pqhuy1987 f36aab8934
All checks were successful
Deploy SOLUTION_ERP / build-deploy (push) Successful in 4m52s
[CLAUDE] Docs: adopt Harness-9 — L2 archive dark-matter recovery (4 sub) + adap 2-workflow mandate (S70)
3-stage Workflow run-id evidence: investigate wf_be952f3c-97f / implement wf_a58e0d15-beb / audit wf_9520d8cd-4fe.

PART 1 (L2 recovery): 4 over-cap sub (cicd-monitor/investigator-codebase/reviewer/implementer-backend)
curated L1->L2 byte-exact + archive/_INDEX.md (substring sha-keyed pointers, no line-hints)
+ <period>.gist.md (4-field distill, distill-gen:1, verbatim frozen). All 4 MEMORY.md now < 25KB
auto-inject cap (closes P1 curate-debt). ~240KB archive no longer RAG-dark. 0-byte-loss git+sha
verified (Stage C audit + em-main self-gate on 2 reviewer StructuredOutput no-returns). Read-side
gap fixed (MEMORY.md L5 header -> _INDEX). + memory-budget.json (seed-by-measure) +
scripts/measure-agent-memory.ps1 + .ragignore guard.

PART 2/3 (process mandate): every adap = 2 separate workflows (implement + review) + report with
run-id; short-but-needs-confirm still requires review. Codified in .claude/commands/adap-apply.md
+ agents/README.md (Upgrade S70) + session-start.md (§2.1.2 budget-audit, pending-restart).

adap-report + email-back to AI_INFRA (body-hash 7c07b716e775).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-17 23:52:51 +07:00

16 KiB
Raw Blame History

Implementer-Backend — Archive 2026-06 (S41-S55 verbose, curated S? Harness-9)

Archived: 2026-06-17 Harness-9 Stage B curate (em main proxy). 14 verbose Recent-activity bullets moved BYTE-EXACT from MEMORY.md (L87-L104) to keep L1 HOT slim < 25KB. Scope: S55 master-import → S41 P11-A Wave 1 schema (+ 3 already-condensed Archived-stubs pointing git d2f52ba / earlier q4). FIFO chronological NEWEST-first as they appeared in L1. FROZEN: entries below are verbatim copies — do NOT reflow/edit. Re-grounding of stale counts is a separate pass (additive-only). KEEP in MEMORY.md: header+role+split boundary + BE Patterns 1-4/7-9/12-bis/12-ter + anti-patterns+BE conventions + Curate trigger + 6 newest Recent-activity (06-17 Off_Dashboard → S56 GOLIVE-HARDEN).


Moved Recent-activity entries (verbatim, FIFO newest-first as in L1)

  • S55 master-data import (Mig 48 AddProjectMasterFields 4 AddColumn no-table + SeedRealMasterDataAsync 62 Project+71 WorkItem+3 Supplier) [proxy by em main — agent return truncated gotcha #53 before MEMORY step]: Project entity +4 prop (Year int?, Investor/Location/Package string?, maxlen 250/500/300 ProjectConfiguration). ProjectFeatures.cs DTO+CreateCmd+UpdateCmd+validators+handlers+List/Get projections +4 (all nullable, appended end). SeedRealMasterDataAsync = 3 tuple-loop per-code idempotent (mirror SeedDemoMasterDataAsync:2185 existingCodes.Contains→skip) wired UNGATED line 118 AFTER SeedCatalogsAsync → reaches prod (DemoSeed:Disabled=true KHÔNG gate, by-design như SeedDemoMasterData/Catalogs). Project Name=Code khi Excel blank. WorkItem 4 Category (Vật tư16/Thầu phụ30/MEP9/Thiết bị16, gen Code VT/TP/MEP/TB-NN; divider "THIẾT BỊ" dropped). Supplier NTP→NhaThauPhu/NCC→NhaCungCap, extras→Note. FLOCK01 collision demo↔real → per-code skip (demo thắng, real code+year only, OK). Compile-fix MasterCatalogFilteredUniqueTests.cs +4 null args CreateProjectCommand (necessary build-green). Runtime Dev proof (em main): app-start seeded 62proj/71wi/3sup landed, CAL01.Investor col populates, 0 overflow/dup. Build 0/0, test 216. Data spec scripts/master-import-data.generated.md. Tag [s55, master-import, mig48, seed-real-ungated, project-4field].

  • S54 ItTicket reassign cross-stack — IT-staff self-service (NO migration, 2 BE file edit): NEW GetAssignableItStaffQuery+AssignableStaffResult(CanReassign,Staff)+AssignableStaffDto(Id,FullName) capability endpoint (REGION 5 WorkflowAppsFeatures.cs) + MODIFIED AssignItTicketHandler: authz Admin-OR-dept-IT → ForbiddenException; assignee-must-be-IT → ConflictException. Controller /assign hạ [Authorize(Roles="Admin")][Authorize] (handler enforce fine-grained data-driven) + NEW GET /assignable-staff. Predicate IT = reuse round-robin S52 Departments.Where(Code=="IT" && !IsDeleted). ICurrentUser KHÔNG có DepartmentId → query db.Users.Where(Id==cu.UserId).Select(DepartmentId). 2 pattern split (em main reconciled từ stray src/Backend/.claude — cwd-relative Write mishap): pattern-controller-lower-authorize-handler-finegrained + pattern-scoped-capability-endpoint-anti-silent-403. Build 0/0, test 203→216 (test-specialist +13 authz), reviewer PASS (role-string "Admin" chain-verified real: AppRoles→SeedRoles→JWT ClaimTypes.Role→cu.Roles). Tag [s54, it-ticket-reassign, capability-endpoint, authz-handler, no-mig].

  • S54 Task D BE — promote AttendanceReport to sidebar menu leaf (NO migration, 2 file edit): Case 1 mechanical, menu = DbInitializer idempotent seed (not schema). 3 insert: (1) MenuKeys.cs const OffAttendanceReport = "Off_AttendanceReport" after OffChamCong:124 · (2) MenuKeys.cs All[] Off-group line +OffAttendanceReport after OffChamCong:158-159 · (3) DbInitializer.cs menu tuple (OffAttendanceReport, "Báo cáo chấm công", Off, 8, "FileBarChart") after OffChamCong:1787 (Order 8, parent Off, mirror Vehicle/Driver S51). adminPermAutoViaAll=TRUE verified 2-point: SeedAdminPermissionsAsync DbInitializer:1916 iterates MenuKeys.All → full-CRUD Permission row per missing key (idempotent existingMenuKeys.Contains); Program.cs:78 iterates All × Actions → policy registration. +All[] = both auto, NO manual grant. Idempotent-add verified: menu upsert loop DbInitializer:1845-1862 existingItems.TryGetValue(key) miss → MenuItems.Add (existing prod gets leaf on restart, existing rows only Order-reconciled — same as S51). Build 0 err (2 pre-existing DocxRenderer warn). KHÔNG touch FE (menuKeys.ts/Layout = implementer-frontend) / tests / commit. Tag [s54, task-d, menu-leaf, no-mig, admin-perm-via-all].

  • S53 gotcha #57 EXT BE — filter 3 Master Code unique indexes + Mig 46 local catch-up (Mig 47 FilterMasterCatalogUniqueIndexesByIsDeleted, index-only no-table): Test-before RED→GREEN driven (test-specialist MasterCatalogFilteredUniqueTests, 3 FAIL on unfiltered → must turn GREEN). gotcha #57 4th+5th+6th cumulative (S45 Holiday Mig 43, S51 HRM×3 Mig 45 → now Department/Project/Supplier). Edit 3 config Code unique: b.HasIndex(x=>x.Code).IsUnique()+.HasFilter("[IsDeleted] = 0"). KEY: copied EXACT filter string byte-for-byte from HolidayConfiguration:18 + LeaveTypeConfiguration:19 (spaces around =, NOT guessed) → snapshot+SQL Server consistent with 13 existing filtered indexes. SupplierConfiguration: ONLY Code index filtered, HasIndex(x=>x.Type) :25 LEFT untouched (verified snapshot 3590 Type no-filter). Mig diff CLEAN: Up=3×DropIndex+3×CreateIndex filtered, Down=3×reverse unfiltered (no drift, no extra table/col). Master entities HAVE global HasQueryFilter(!IsDeleted) (unlike HRM) — app-check db.X.AnyAsync(Code==req.Code) filters soft-deleted → passed; then bare DB index counted it → UNIQUE violation 500. Filter aligns DB index with app-check. Mig 46 local catch-up: S52 left local LocalDB stuck at Mig 45 (prod had 46 via CI, local gap). database update to BOTH DBs applied Mig 46 (AddSlaFieldsToItTicket) THEN Mig 47 — residual closed. Dev override --connection SolutionErp_Dev; Design factory-default SolutionErp_Design (both (localdb)\MSSQLLocalDB). Build 0 err (2 pre-existing DocxRenderer warn). Full suite 203 GREEN (58 Domain + 145 Infra, +3 new). KHÔNG touch FE/test/commit (em main commits). Tag [s53, gotcha-57-ext, mig47, mig46-catchup, filter-byte-for-byte].

  • S52 P11-D Wave2 BE — ItTicket round-robin + SLA (Mig 46 AddSlaFieldsToItTicket, 3 AddColumn no-table) [proxy by em main: agent killed session-limit trước MEMORY step]: Entity +SlaDueAt/SlaWarnedSent/SlaBreached. CreateItTicketHandler: SlaWindow static map (Urgent4/High8/Medium24/Low72h) shared với ItTicketSlaJob (single-source) → e.SlaDueAt=CreatedAt+window. Round-robin least-loaded: db.Users.Where(DepartmentId==itDeptId && IsActive).OrderBy(db.ItTickets.Count(assigned && !Closed && !Resolved)).ThenBy(Id).First() (itDept = Departments.Code=="IT"); no IT-staff → unassigned. NEW ItTicketSlaJob:BackgroundService mirror SlaExpiryJob (30s warmup/15min loop/scope) NHƯNG KHÔNG auto-transition — chỉ breach (SlaDueAt<now & !breached & open → SlaBreached=true + notify assignee) + warning (≤20% window → notify + SlaWarnedSent), idempotent qua guard. DI AddHostedService<ItTicketSlaJob> sau SlaExpiryJob. AssignItTicketCommand + PUT /{id}/assign [Authorize(Roles=Admin)]. DTO +SlaDueAt/SlaBreached + projection. DbInitializer SeedItDepartmentStaffAsync KEY ordering: PHẢI chạy SAU SeedDemoUsersAsync (method đó reconcile 2 user dept về PRO/CCM mỗi boot → override về IT sau, end-state deterministic) + dept "IT" thứ 10 + gán nv.cao/nv.truong (sample user, idempotent). Build 0-err. Tag [s52, p11-d, mig46, round-robin, sla-job, seed-ordering].

  • S52 P11-E+F Wave1 BE migration-FREE (4 file new + 3 edit, NO mig): Case 1/2 deterministic ~98% em main. P11-F (2 LOC): CreateItTicketHandler set e.MaTicket = WorkflowAppCodeGen.GenerateMaDonTuAsync(db,"IT",clock.Now.Year,clock,ct) TRƯỚC db.ItTickets.Add — gen lúc Create (kanban no-workflow, khác Leave/OT gen lúc Submit). Helper = internal static cùng ns Office, gọi trực tiếp no-using. Format IT/2026/001. P11-E report chấm công: NEW AttendanceReportFeatures.cs (DTO 3 record EXACT + GetAttendanceReportHandler) + NEW IAttendanceReportExcelExporter(App/Reports/Services) + NEW Infra AttendanceReportExcelExporter(ClosedXML mirror ContractExcelExporter, sync Export(dto) no-DB) + DI scoped + Controller +2 endpoint [Authorize(Roles=Admin)]. KEY gotcha day-type: DayOfWeek+holidaySet KHÔNG EF-translate → .ToListAsync() rồi group/classify IN-MEMORY C#. KEY gotcha type: Holiday.Date=DateOnly KHÔNG DateTime (spec viết HashSet nhầm) → HashSet<DateOnly> + so DateOnly.FromDateTime(a.AttendanceDate.Date). OtPolicy active fallback 1.5/2.0/3.0. Day-type prio: holiday→weekend(Sat/Sun)→weekday. OtWeighted=Σ(cấp×hệ số). FullName denorm ưu tiên Attendance.UserFullName rồi User.FullName. DeptName LEFT JOIN. RenderResult=(Content,FileName,ContentType) ns Forms.Services. Controller inject exporter ctor. Build 0 err (2 pre-existing DocxRenderer warn). KHÔNG touch FE/test/mig/ItTicket-khác. Routes: GET /api/attendances/report?year&month&departmentId + /report/excel. Tag [s??, p11-e-f, wave1, no-mig, day-type-in-memory, dateonly-holiday].

  • S51 P11-C HMW W1 — Vehicle+Driver catalogs HrmConfigs (Mig 44 AddVehicleAndDriverCatalogs, 9 add-point ~12 file/edit): Pattern 12-bis catalog-mega 4th cumulative. 2 entity (Vehicle/Driver:AuditableEntity Domain/Hrm) + 2 EF config (mirror HolidayConfiguration filtered, NOT buggy bare LeaveType) + 2 DbSet (IAppDbContext+ApplicationDbContext) + Mig 3-file + HrmConfigFeatures Region5/6 (DTO+List/Create/Update/Delete CQRS mirror Region1 EXACT) + Controller +2 route group (8 endpoint, GET public + POST/PUT/DELETE [Authorize(Roles=Admin)]) + MenuKeys +2 const +All array + DbInitializer (menu 2 leaf + SeedHrmConfigsAsync guard&seed 2 veh+2 drv). gotcha #57 KEY: Code UNIQUE .HasFilter("[IsDeleted]=0") — Mig diff verified CLEAN 2 CreateTable + 2 filtered IX no drift. Validator MaxLength = em main schema (Code50/Name200/Plate20/Phone20/LicNum50/LicClass20/Desc500), SeatCount GreaterThanOrEqualTo(0). Admin perm AUTO-grant: SeedAdminPermissionsAsync + Program.cs:78 both iterate MenuKeys.All → +All array = 8 policy + Admin row auto (no manual grant code). HRM no HasQueryFilter → .Where(!IsDeleted) manual. Applied BOTH DB. Build 0 err (2 pre-existing DocxRenderer warn). RAG/Qdrant DOWN → all Read/Grep on-disk. Spec deterministic ~98% em main → ACCEPT Case 1. KHÔNG touch FE/test/commit. Tag [s51, p11-c, mig44, vehicle-driver, catalog-mega].

  • S43 P11-B Wave 1 — LeaveBalance business logic (Mig 42 AddLeaveBalances, 7 file: 1 entity + 1 config + 2 DbSet edit + Mig 3-file + 1 hook edit + 1 Features + 1 Controller): Case 1/3 deterministic ~98% em main spec. Pattern 12-ter-adjacent single-entity: entity LeaveBalance:AuditableEntity (UserId/LeaveTypeId/Year + EntitledDays/UsedDays/AdjustmentDays decimal(5,2), nav LeaveType). Config FK LeaveType WithMany() Restrict (catalog no cascade) + UNIQUE composite (UserId,LeaveTypeId,Year) + IX UserId. Mig diff CLEAN: 1 CreateTable + 3 IX, no drift. Applied BOTH DB (Dev SolutionErp_Dev + Design default). Deduction hook: insert in ApproveLeaveRequestHandler terminal else (DaDuyet branch) ONLY — UPSERT LeaveBalance, bal.UsedDays += p.NumDays, exactly-once guaranteed by early guard Status != DaGuiDuyet throw. OtRequest/Travel/Vehicle UNTOUCHED (only Leave has balance). CQRS Application.Hrm: DTO RemainingDays=Entitled+AdjustmentUsed COMPUTED (not stored) + GetMy/GetUser lazy-merge (load active LeaveTypes + balances → in-memory merge, synth default when no row — KHÔNG EF LEFT JOIN translate) + AdjustLeaveBalanceCommand admin upsert (HasValue-gated). Policy resolved: HRM admin convention = [Authorize(Roles="Admin")] NOT menu policy (verified HrmConfigsController write endpoints) — used on GET-by-user + PUT /adjust; /my = [Authorize]. Controller injects IDateTime for year default clock.Now.Year (thin, no DateTime.Now hardcode). HRM no HasQueryFilter → .Where(!IsDeleted) manual everywhere. KHÔNG touch FE/test/commit. Build 0 err (2 pre-existing DocxRenderer warn). Tag [s43, p11-b-w1, mig42, leave-balance, single-entity].

  • S42 P11-A SEED — 4 sample ApprovalWorkflow V2 for WorkflowApps (DbInitializer.cs only, +4 method ~210 LOC + 4 call): Case 1 mechanical mirror SeedSampleProposalWorkflowV2Async EXACT × 4 (Leave5/Ot6/Travel9/Vehicle7). Each: idempotent AnyAsync(ApplicableType==X) guard → resolve approver binh.le@solutions.com.vn (SAME user as Proposal/Contract seed, null→LogWarning+return) → 1 ApprovalWorkflow (Version=1, IsActive+IsUserSelectable=true, ActivatedAt=UtcNow) + 1 Step (Order=1, Name="Cấp duyệt", DepartmentId=CCM?.Id) + 1 Level (Order=1, ApproverUserId). Codes QT-NP/OT/CT/XE-V2-001. Wired 4 calls after SeedSampleProposalWorkflowV2Async (NOT gated DemoSeed, gotcha #51 infra seed). Enum verified Grep. Build 0 err 0 warn. Bash tool = bash NOT PowerShell despite env hint (use cd && cmd | grep). Spec deterministic 100% → ACCEPT Case 1. NOT touched App/Controller/FE/test/Mig. Tag [s42, p11-a, seed, mirror-proposal-exact].

  • S42 P11-A Wave 2b APP — wire ApproveV2 CQRS Travel+Vehicle (TravelVehicleApprovalFeatures.cs ~830 LOC + 2 controller edit): Cookie-cutter mirror Wave 2a / ProposalFeatures Region 2. 1 new file ns Application.Office: 2 module × (DetailDto + LevelOpinionDto + GetById JOIN Step/Level metadata + UpdateDraft + Submit + Approve UPSERT+advance + Reject TuChoi + Return TraLai+RejectedFromStatus) + 1 shared internal static TravelVehicleCodeGen.GenerateMaDonTuAsync (Serializable tx, WorkflowAppCodeSequences Prefix-keyed, prefix DT/CT/{year} Travel & DX/XE/{year} Vehicle, format {prefix}/{seq:D3} — D3 no year segment per spec). KEY gotcha: WorkflowAppStatus enum DIFFERS from ProposalStatus int values (DaGuiDuyet=2 not 1, TraLai=3) → mirror by SEMANTIC enum member not literal. Owner = RequesterUserId (not DrafterUserId). Submit verify wf.ApplicableType==Travel9/Vehicle7 else Conflict. 2 controller +6 route each (GET{id}/PUT/submit/approve/reject/return) nested body records, CreatedAtAction. KHÔNG sửa WorkflowAppsFeatures.cs/Leave/Ot/FE/test/seed. Build 0 err. Spec deterministic ~98% em main → ACCEPT Case 1/2. Tag [s42, p11-a, wave-2b, mirror-proposal-region2].

  • Archived S42 P11-A Wave 2a APP (LeaveOt ApproveV2 CQRS) → git history (S65b FIFO trim): KEY absorbed Pattern 4 + WorkflowAppCodeGen Serializable-tx Prefix-keyed {prefix}/{year}/{seq:D3} + WorkflowAppStatus enum DIFFERS ProposalStatus (mirror SEMANTIC member not literal) + Owner=RequesterUserId. Detail in Wave 2b entry above + S56 em-main Serializable note.

  • S41 P11-A Wave 1 SCHEMA — wire ApproveV2+LevelOpinions 4 WorkflowApps (Mig 41 WireWorkflowAppsApprovalV2): Pattern 12-bis cookie-cutter mirror Proposal Mig 38, 13× cumulative. 11 file: 5 entity (4 {Leave,Ot,Travel,Vehicle}RequestLevelOpinion + shared WorkflowAppCodeSequence Prefix-PK) + 5 EF config (auto-discover ApplyConfigurationsFromAssembly, no manual register) + edit 4 parent (nav LevelOpinions + WorkflowAppStatus? RejectedFromStatus) + edit enum (TravelRequest=9) + 2 DbSet (IAppDbContext+ApplicationDbContext, 5 each). Mig diff CLEAN: 5 CreateTable + 4 AddColumn (no drift). FK Cascade parent + Restrict Level + UNIQUE composite ({Parent}Id, ApprovalWorkflowLevelId). Applied BOTH DB (Dev + Design). Build 0 err. Wave 2 (App/Controller) + Wave 4 (test) deferred per spec. Spec deterministic 100% (em main chose schema) → ACCEPT Case 1. Tag [s41, p11-a, 12-bis-13x, mig41].

  • Archived S35 G-H2 BE-CRUD-4-catalog + S29 Plan-B-Chunk-C Contract-V2-mirror → archive/2026-05-q4.md (S65 FIFO trim): KEY absorbed Pattern 12-bis foundation above (catalog-mega + HRM .Where(!IsDeleted) manual + Validator MaxLength=EF-source).

  • Archived FE/test + older BE entries → archive/2026-05-q4.md + git d2f52ba (S40 curate): S35 FE inline forms 5 satellite (→ frontend domain) · S34 test bundle +10 [Fact] 130 PASS (→ test-specialist domain) · S33 Task 5 EmployeesListPage · S32 wrap/startup. KEY absorbed in Patterns above + split pointers.