vietreport-admin/solution-erp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
5113e4c771b3a14a32ce558bea368ff9b19da017
solution-erp/docs/changelog/migration-todos.md
pqhuy1987 5113e4c771 [CLAUDE] Phase2: Form Engine MVP + docs (gotchas, skill, handoff) 
Backend Forms:
- Domain/Forms: ContractTemplate (FormCode, Name, ContractType, FileName, StoragePath, Format, FieldSpec JSON, IsActive) + ContractClause
- EF config voi unique FormCode + query filter IsDeleted
- DbSets + IApplicationDbContext update
- Migration AddForms (bang 14 total)
- Packages: DocumentFormat.OpenXml 3.x + ClosedXML 0.105+
- Application/Forms:
  - IFormRenderer interface + RenderResult record
  - FormFeatures.cs: List/Get/Render CQRS
  - IWebHostEnvironmentLocator (abstract IWebHostEnvironment)
- Infrastructure/Forms:
  - DocxRenderer: OpenXml-based placeholder {{field}} replace, handle split runs (gom text tat ca <w:t> trong paragraph, replace, gan lai text dau + clear rest)
  - XlsxRenderer: ClosedXML cell value replace
  - FormRenderer router theo format docx/xlsx
- Api:
  - FormsController: GET /templates (filter type, onlyActive), GET /templates/{id}, POST /templates/{id}/render (return file)
  - WebHostEnvironmentLocator impl
- DbInitializer SeedContractTemplatesAsync: seed 8 template metadata, IsActive=true chi khi file ton tai

Templates vat ly:
- Copy 5 .docx/.xlsx tu FORM/ sang wwwroot/templates/
- 3 .doc (FO-002.02/03/06) chua convert: IsActive=false (Word COM bi stuck luc test, can retry voi DisplayAlerts=0 hoac LibreOffice)
- scripts/convert-doc-to-docx.ps1 (Word COM automation)

Frontend fe-admin:
- types/forms.ts: ContractTemplate + ContractTypeLabel
- pages/forms/FormsPage.tsx: list templates + Render dialog (paste JSON data → download .docx/.xlsx)
- Route /forms them vao App.tsx

Bug fix:
- SpaceProcessingModeValues namespace: wrap EnumValue<> full path
- SaveAs2($path, 16) thay vi SaveAs([ref], [ref]) — PowerShell type issue
- Word COM stuck: kill process, skip .doc cho MVP

Docs (theo yeu cau user):
- docs/gotchas.md MOI: 17 pitfalls nhom theo tech stack / EF Core / OpenXml / JSON / dev workflow
- .claude/skills/form-engine/SKILL.md: placeholder → full spec (algorithm + code pointers + API + limitations)
- .claude/skills/permission-matrix/SKILL.md: placeholder → full spec (BE policy + FE guard + seed + pitfalls)
- docs/HANDOFF.md MOI: brief 5 phut cho session sau (run quickstart + where we are + next steps + file tree + gotchas ref)
- docs/STATUS.md: update cumulative stats + next up Phase 3
- docs/changelog/migration-todos.md: tick Phase 2 iteration 1 items + add iteration 2 list
- docs/changelog/sessions/2026-04-21-1200-phase2-form-engine.md: session log
- CLAUDE.md root: them reference den gotchas + HANDOFF

E2E verified:
- GET /api/forms/templates (onlyActive=false) → 8 templates
- POST /api/forms/templates/{FO-002.05}/render voi data dict → HTTP 200 + file .docx 482KB (Microsoft Word 2007+ OK)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-21 12:01:11 +07:00

11 KiB
Raw Blame History

Migration To-dos — Atomic Roadmap

Mỗi item là 1 task atomic (~2-8h work). Tick [x] khi xong. Link session log nếu có.

Phase 0 — Draft Scaffold (T1)

  • Tạo cấu trúc thư mục SOLUTION_ERP/
  • Scaffold .NET 10 solution SolutionErp.slnx
  • Scaffold 4 project: SolutionErp.{Domain, Application, Infrastructure, Api}
  • Wire Clean Arch references (Api → App/Infra, Infra → App, App → Domain)
  • Install NuGet base: MediatR, FluentValidation, AutoMapper, EF Core SqlServer, Identity, JWT, Swagger, Serilog
  • Scaffold 2 React + Vite apps fe-admin + fe-user với TS template
  • Config vite.config.ts: port, strictPort, proxy /api, alias @
  • Pin Node >=20 trong package.json + .nvmrc cho CI
  • Parse 8 form → docs/forms-spec.md
  • Parse quy trình → docs/workflow-contract.md
  • Viết docs/{CLAUDE,STATUS,PROJECT-MAP}.md
  • Viết docs/database/database-guide.md (conventions + schema + ERD + migration workflow)
  • Viết docs/flows/ — README + 6 flow doc (auth, permission, contract-create, contract-approve, form-render, sla-expiry)
  • Viết .gitignore, README.md, global.json, docker-compose.yml
  • Tạo placeholder skill folders: contract-workflow, form-engine, permission-matrix
  • git init + commit đầu (25dad7f)
  • Push Gitea remote (chờ URL từ user)

Phase 1 — Alpha Core (T2-4)

Foundation (đã xong Session 2)

  • Domain/Common/BaseEntity.cs (Id Guid, CreatedAt, UpdatedAt, CreatedBy, UpdatedBy)
  • Domain/Common/AuditableEntity.cs (IsDeleted, DeletedAt, DeletedBy)
  • Domain/Contracts/ Enums: ContractType, ContractPhase (9 state), ApprovalDecision
  • Domain/Identity/User.cs (IdentityUser + FullName + RefreshToken + IsActive)
  • Domain/Identity/Role.cs (IdentityRole + Description)
  • Domain/Identity/AppRoles.cs — 12 role constants
  • Application/Common/Interfaces/: IApplicationDbContext, ICurrentUser, IDateTime, IJwtTokenService
  • Application/Common/Exceptions/*
  • Application/Common/Behaviors/ValidationBehavior.cs
  • Application/DependencyInjection.cs — MediatR + FluentValidation
  • Infrastructure/Persistence/ApplicationDbContext.cs : IdentityDbContext
  • Infrastructure/Persistence/Interceptors/AuditingInterceptor.cs
  • Infrastructure/Persistence/DbInitializer.cs — seed 12 role + admin
  • Infrastructure/Persistence/DesignTimeDbContextFactory.cs
  • Infrastructure/Identity/{JwtSettings, JwtTokenService}.cs
  • Infrastructure/Services/DateTimeService.cs
  • Infrastructure/DependencyInjection.cs
  • Api/Services/CurrentUserService.cs
  • Api/Middleware/GlobalExceptionMiddleware.cs
  • Api/Controllers/AuthController.cs (login, refresh, me, logout)
  • Api/Program.cs (Serilog, JWT, CORS, Swagger, middleware)
  • Api/appsettings.{json, Development.json} + launchSettings.json (port 5443)
  • Migration 1 Init + apply to SolutionErp_Dev LocalDB
  • FE: Vite config (Tailwind 4 + proxy + alias)
  • FE: src/{index.css, lib/api.ts, lib/cn.ts, types/auth.ts} cho 2 app
  • FE: src/contexts/AuthContext.tsx, components/{ProtectedRoute, Layout}.tsx
  • FE: components/ui/{Button, Input, Label}.tsx
  • FE: pages/LoginPage.tsx, pages/DashboardPage.tsx (admin) + pages/InboxPage.tsx (user)
  • FE: App.tsx với Router + AuthProvider + Toaster
  • FE: main.tsx với QueryClient (TanStack Query)
  • E2E verified: login qua Vite proxy cả 2 app → JWT + user info

Phase 1 đợt 2 — CRUD master + Permission Matrix (sắp tới)

  • Domain/Master/Supplier (+ SupplierType enum 5 loại) / Project / Department (AuditableEntity)
  • EF IEntityTypeConfiguration<T> cho mỗi entity (unique Code + query filter IsDeleted)
  • CQRS CRUD: Create/Update/Delete/GetById/List (PagedResult) cho 3 entity
  • Api/Controllers/{SuppliersController, ProjectsController, DepartmentsController}
  • Migration 2: AddMasterData
  • Domain/Identity/MenuItem (Key PK, Label, ParentKey, Order, Icon) + MenuKeys const class
  • Domain/Identity/Permission (RoleId, MenuKey, CanRead/Create/Update/Delete)
  • Seed default menu tree (12 menu) + admin full access trong DbInitializer
  • Application/Permissions/Queries/GetMyMenuTreeQuery — resolve per-user, union OR, tree filter
  • Api/Controllers/{MenusController, RolesController, PermissionsController}
  • Migration 3: AddPermissions
  • Authorization handler MenuPermissionHandler + register 48 policy {menu}.{action}
  • Domain/Entities/Contract skeleton (Id, Type, SupplierId, ProjectId, Phase=DangChon, DraftData JSON) — deferred Phase 2/3
  • Contract CRUD draft only (không workflow Phase 3) — deferred
  • FE: <PermissionGuard menuKey="Suppliers" action="Update"> + usePermission() hook
  • FE Admin: 3 trang CRUD Supplier/Project/Department với DataTable + Dialog modal + search/sort/paging
  • FE Admin: Permission Matrix grid page (role × menu × CRUD checkbox)
  • FE Admin: Layout menu động từ /api/menus/me
  • FE User: trang "HĐ của tôi" list + filter — Phase 3
  • FE Admin: Users management page (tạo user + gán role) — sắp tới
  • FE Admin: Roles CRUD — sắp tới
  • Route guard theo role admin-only — có PermissionGuard ở button, route cần thêm

Exit criteria Phase 1

  • Admin login → tạo NCC/Project → tạo role "Nhân viên CCM" → gán permission menu "Contracts.Read"
  • User CCM login → thấy menu Contracts, không thấy menu Admin
  • Tạo Contract draft → list hiển thị, không bị 403 sai

Phase 2 — Form Engine (T5-6)

MVP xong (Phase 2 iteration 1)

  • Khảo sát: chọn OpenXml + ClosedXML (free, không cần license)
  • Domain/Forms/ContractTemplate (Id, FormCode, Name, ContractType, FileName, StoragePath, Format, FieldSpec JSON, IsActive)
  • Domain/Forms/ContractClause skeleton
  • EF config + Migration AddForms
  • Application/Forms/Services/IFormRenderer interface
  • Infrastructure/Forms/DocxRenderer (OpenXml, handle placeholder split runs)
  • Infrastructure/Forms/XlsxRenderer (ClosedXML)
  • Application/Forms/FormFeatures.cs — List/Get/Render CQRS
  • Api/Controllers/FormsController — GET templates, GET single, POST render
  • Copy 5 .docx/.xlsx template → wwwroot/templates/
  • Seed 8 ContractTemplate rows (5 IsActive=true, 3 chờ convert)
  • FE admin: FormsPage — list + render dialog điền JSON + download
  • E2E verified: render FO-002.05 → file .docx 482KB mở được bằng Word

Iteration 2 (optional — enhance)

  • Convert 3 file .doc → .docx (retry Word COM với DisplayAlerts=0 + timeout, hoặc LibreOffice headless)
  • Parse chi tiết field của 5 template HĐ — mỗi form thành JSON FieldSpec
  • Support {{#loop}}...{{/loop}} block cho table lặp (hạng mục HĐ giao khoán, PO)
  • FE user: form builder dynamic — render từ fieldSpec thay vì điền JSON tay
  • FE admin: upload template mới qua UI (POST multipart) + edit field mapping
  • Lưu ContractClause (FO-002.04) dạng rich text, admin edit qua TipTap/TinyMCE
  • PDF convert via LibreOffice headless (soffice --headless --convert-to pdf)
  • Import/export template (backup/restore)
  • Format helpers: number → 150,000,000 VND, date → dd/MM/yyyy
  • Content preservation test: render → diff layout với template gốc

Phase 3 — Workflow State Machine (T7-9)

  • Domain/Entities/ContractApproval + ContractComment + ContractAttachment
  • Domain/Entities/Contract update: thêm Phase, SlaDeadline, BypassProcurementAndCCM
  • Domain/Services/IContractWorkflowService.TransitionAsync(...) — state guard + role guard + side effects
  • Infrastructure/Services/ContractCodeGenerator (implement RG-001) với locking cho seq
  • Infrastructure/HostedServices/SlaExpiryJob — check mỗi 15min, auto-approve quá hạn
  • Infrastructure/Services/NotificationService — email (MailKit) + in-app (SignalR optional)
  • MediatR behavior: AuditBehavior — log mọi command
  • API: POST /api/contracts/{id}/transitions body: {targetPhase, comment}
  • FE user Inbox: list "HĐ chờ tôi xử lý" (query by current phase + user role)
  • FE Contract detail page: timeline 9 phase, approval panel, comment thread
  • Upload attachment (scan có chữ ký đối tác)
  • Notification UI: badge count, dropdown, click → detail
  • E2E test: happy path end-to-end 1 HĐ qua 9 phase
  • E2E test: reject → quay về DangSoanThao
  • E2E test: SLA expired → auto-approve + log

Phase 4 — Reporting + Polish (T10-11)

  • Dashboard admin: số HĐ theo phase, top NCC, top dự án, tổng giá trị theo tháng
  • Excel export theo bộ lọc (dùng EPPlus)
  • Report: HĐ quá hạn SLA bao nhiêu lần theo phase/role
  • UX polish: skeleton loader, empty state, error boundary có recovery button
  • Accessibility: keyboard nav, focus trap modal, aria labels
  • Dark mode (optional, nếu rảnh)
  • Performance: index DB cho query hot (SupplierId, ProjectId, Phase)
  • Tài liệu user guide: quy trình tạo HĐ + duyệt
  • UAT với 5-10 HĐ dữ liệu thật từ bộ phận Cung ứng

Phase 5 — Production (T12-13)

  • docs/guides/cicd.md — CI/CD runbook
  • Gitea Actions workflow .gitea/workflows/deploy.yml — build .NET + 2 FE, deploy IIS qua SSH/WinRM
  • Pin Node 20.x trong workflow, test CI sớm (không để surprise cuối dự án)
  • scripts/deploy-iis.ps1 — stop app pool, xcopy, start app pool
  • Windows Server setup: IIS + URL Rewrite + ARR (reverse proxy FE → IIS)
  • SQL Server prod: backup plan daily + weekly full
  • HTTPS certificate (Let's Encrypt qua win-acme hoặc mua cert)
  • appsettings.Production.json + user secrets
  • Security audit: owasp top 10 check
  • Rate limiting middleware (AspNetCoreRateLimit hoặc built-in)
  • Health check endpoint /health cho IIS probe
  • Error tracking: Serilog → file rolling daily, retention 30 ngày
  • Runbook: restart app, rollback migration, restore backup
  • UAT production 1 tuần với 2-3 user thật
  • Go-live checklist: backup, rollback plan, on-call contact

Post-launch (Phase 6+ — future)

  • E-signature integration (VNPT CA hoặc FPT CA)
  • Tích hợp Bravo / SAP ERP import NCC
  • Mobile app (React Native?) cho BOD duyệt ngoài giờ
  • AI: gợi ý điền form dựa HĐ cũ, OCR scan HĐ đối tác
  • Multi-tenant nếu có công ty thứ 2