3c4931687a
All checks were successful
Deploy SOLUTION_ERP / build-deploy (push) Successful in 3m15s
3 endpoint mới + Notify TPB + Docs update để chốt session 8.
Application:
- PurchaseEvaluationDepartmentApprovalFeatures.cs (NEW):
* ListPeDepartmentApprovalsQuery + DTO PeDepartmentApprovalDto
* Join Departments (lấy Name) + lookup Users.FullName denorm cho FE timeline
- UserFeatures.cs: SetUserBypassReviewCommand + Handler dùng UserManager.UpdateAsync
- IApplicationDbContext: thêm DbSet<User> Users + DbSet<Role> Roles (cần cho lookup)
Api:
- PurchaseEvaluationsController: GET /api/purchase-evaluations/{id}/department-approvals
- UsersController: PATCH /api/users/{id}/bypass-review (Authorize Users.Update)
Infra:
- PurchaseEvaluationWorkflowService: notify TPB cùng dept khi NV review.
Query db.Users.Where(DeptId match + IsActive) → UserManager.GetRolesAsync
filter DeptManager → notifications.NotifyAsync. Best effort fail non-critical.
Docs:
- STATUS.md: Recently Done thêm row session 8 + Phase header update
count 52→55 tables, 15→16 migrations, 128→131 endpoints
- HANDOFF.md: TL;DR session 8 + 8 cảnh báo session 9 (FE chưa làm,
test flow anh Kiệt, smart reject test, lock edit test, ...)
- migration-todos.md: Phase 9 done section đầy đủ 3 ràng buộc + pending Chunk E-bis
- CLAUDE.md: count 52→55 + migration 16 description
- session log: 2026-05-04-1230-chot-session-8-2-stage-dept-approval.md (full report)
Verify final:
- Build pass 0 warning 0 error
- 77 unit test pass (54 Domain + 23 Infra)
- Migration 16 applied LocalDB OK + schema verified
Total session 8 cumulative: 5 commit per-chunk:
- 5fe61cc (A: Migration 16 schema)
- 14f3c9f (B: Lock edit guards 17 handler)
- 9747f8c (C: Smart reject + Resume 3 module)
- a532ba6 (D: PE 2-stage logic)
- (current E1: List + Notify + Bypass + Docs)
Pending Chunk E-bis (defer cho session 9 sau UAT PE):
- FE Workflow Panel hiển thị 2-stage timeline
- FE UserManager toggle CanBypassReview
- HĐ + Budget 2-stage extension
- Tests Phase 3 mini cho 2-stage Service-layer logic
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
145 lines
8.4 KiB
Markdown
145 lines
8.4 KiB
Markdown
# CLAUDE.md — AI Agent Context
|
||
|
||
> **Full content:** [`docs/CLAUDE.md`](docs/CLAUDE.md)
|
||
|
||
---
|
||
|
||
**SOLUTION_ERP** — Hệ thống Quản lý Hợp đồng Nhà cung cấp / Thầu phụ / Tổ đội + **Phiếu Duyệt NCC tiền-HĐ** cho Công ty TNHH Xây dựng Solutions.
|
||
|
||
Kiến trúc: **.NET 10 Clean Architecture + 2 React FE (admin + user) + SQL Server + IIS**.
|
||
|
||
## 🚀 BẮT ĐẦU SESSION — 5 file đọc trước tiên
|
||
|
||
```
|
||
1. docs/STATUS.md ← Snapshot HIỆN TẠI (phase nào, việc gì đang làm — PE module CÒN CHỈNH NHIỀU)
|
||
2. docs/HANDOFF.md ← Brief 5 phút: session trước làm gì + cảnh báo session tiếp
|
||
3. docs/PROJECT-MAP.md ← Bản đồ toàn cảnh
|
||
4. docs/changelog/migration-todos.md ← Atomic tasks theo phase (Phase 7 PE refinement mới)
|
||
5. docs/workflow-contract.md ← ⭐ State machine 9 phase HĐ — base pattern cho PE workflow
|
||
```
|
||
|
||
## ⚡ Quick Rules
|
||
|
||
### Backend — `.NET 10` Clean Architecture
|
||
|
||
- Solution: `SolutionErp.slnx` ở root, projects ở `src/Backend/`
|
||
- **4 layer:** `Api → Application ← Domain` + `Infrastructure → Application`
|
||
- Pattern: **CQRS + MediatR**, **FluentValidation**, **AutoMapper**
|
||
- Repository qua `IApplicationDbContext` interface (Application layer)
|
||
- Auth: **JWT Bearer + ASP.NET Identity**
|
||
- DB: **SQL Server** (LocalDB dev / SQL Server prod), **EF Core 10 Code-First migrations**
|
||
- Error handling: `GlobalExceptionMiddleware` map exception → HTTP status
|
||
- Commit scope tech stack: `Api` · `App` · `Domain` · `Infra`
|
||
|
||
### Frontend — 2 app React 18 + Vite + TS + shadcn/ui + TanStack Query
|
||
|
||
- `fe-admin/` (port **8082**) · `fe-user/` (port **8080**)
|
||
- Vite proxy `/api → http://localhost:5443` (SolutionErp.Api)
|
||
- **Named export**, không default export (trừ `App`)
|
||
- shadcn/ui copy-paste, **duplicate giữa 2 app là CÓ CHỦ ĐÍCH** (mỗi app UX riêng)
|
||
- Auth context: `solution-erp-admin-token` / `solution-erp-user-token` ở `localStorage`
|
||
- TanStack Query cho data fetching
|
||
- **Node pin `>=20`** trong `engines`; CI pin `20.x` qua `.nvmrc` (bài học NamGroup — KHÔNG dùng Node latest trên CI)
|
||
- UI **100% tiếng Việt**
|
||
|
||
### Database conventions
|
||
|
||
- Schema: `dbo` (single schema)
|
||
- Table: **PascalCase tiếng Anh** (Contracts, Suppliers, Projects, ContractApprovals, PurchaseEvaluations, ...)
|
||
- PK: `Id` (Guid), FK: `{Entity}Id`
|
||
- Audit fields: `CreatedAt`, `UpdatedAt`, `CreatedBy`, `UpdatedBy` (`BaseEntity`)
|
||
- Soft delete: `IsDeleted`, `DeletedAt`, `DeletedBy` (`AuditableEntity`)
|
||
- Migrations: `dotnet ef migrations add <Name> --project src/Backend/SolutionErp.Infrastructure --startup-project src/Backend/SolutionErp.Api`
|
||
- **Hiện có 16 migration → 55 bảng** (Phase 9 — Migration 16 `AddTwoStageDeptApprovalAndSmartReject` — 3 bảng `*DepartmentApprovals` + `Users.CanBypassReview` + 3 `RejectedFromPhase` cho smart reject + 2-stage NV/TPB approval per dept)
|
||
|
||
### Modules
|
||
|
||
| Module | Namespace | Migration | Trạng thái |
|
||
|---|---|---|---|
|
||
| Contract (HĐ) | `Domain/Contracts/` | 1-11 | Feature-complete (7 ContractType × 9 phase) |
|
||
| PurchaseEvaluation (Duyệt NCC tiền-HĐ) | `Domain/PurchaseEvaluations/` | 12, 13, 15 | Feature-complete — chỉ Export PDF còn pending (không quan trọng) |
|
||
| Budget (Ngân sách dự án) | `Domain/Budgets/` | 14 | **Feature-complete** — BE + FE 3-panel + integration với PE/HD |
|
||
| Master (Supplier/Project/Department) | `Domain/Master/` | 2, 10 | Feature-complete |
|
||
| Identity (User/Role/Permission/MenuItem) | `Domain/Identity/` | 1, 3, 11 | Feature-complete (30 demo user — 16 sample + 14 Solutions thật) |
|
||
| Forms (Template + Clause) | `Domain/Forms/` | 4 | Feature-complete |
|
||
| Notifications | `Domain/Notifications/` | 6 | In-app + SignalR OK, email SMTP TODO |
|
||
| **Tests** | `tests/SolutionErp.{Domain,Infrastructure}.Tests/` | — | **77 test pass** (54 Domain + 17 Infra + 6 PE WF Application Phase 3 mini) — CI gate + path filter docs-only skip |
|
||
|
||
### Commit convention
|
||
|
||
```
|
||
[CLAUDE] <scope>: <imperative message>
|
||
```
|
||
|
||
**Scope:** `Contract` · `PurchaseEvaluation` · `Budget` · `Form` · `Workflow` · `Supplier` · `Auth` · `Admin` · `Api` · `App` · `Domain` · `Infra` · `FE-Admin` · `FE-User` · `Tests` · `Docs` · `CICD` · `Scripts` · `Skill`
|
||
|
||
## 🧪 Tests (Phase 8 — Session 5)
|
||
|
||
```
|
||
tests/
|
||
├── SolutionErp.Domain.Tests/ (54 test - Phase 1: WorkflowPolicy / PEPolicy / BudgetPolicy)
|
||
└── SolutionErp.Infrastructure.Tests/ (17 + 6 = 23 test)
|
||
├── Services/ (17 test - Phase 2: Contract + PE Code Generator)
|
||
└── Application/ (6 test - Phase 3 mini: PeWorkflowDefinition versioning)
|
||
```
|
||
|
||
**77 unit test pass** / ~3s. CI gate + path filter live.
|
||
|
||
```bash
|
||
dotnet test SolutionErp.slnx # chạy cả 2 test project
|
||
```
|
||
|
||
**Quy tắc timing test:** feature mới = test-after (UAT ổn → viết). Bug fix = test-before BẮT BUỘC (reproduce → fix). Critical algorithm (codegen/guard/financial/security) = test-before merge. Spec change = update test cũ + code chung commit. Skip: DTO mapping, CRUD master, FE snapshot. Detail `docs/rules.md §7`.
|
||
|
||
### CI/CD pipeline (3 fix lớn 29/04)
|
||
|
||
- ✅ Manual checkout bypass github.com (fix gotcha #39 TCP timeout)
|
||
- ✅ Path filter docs-only skip — `paths-ignore` (gotcha #41)
|
||
- ⏸️ npm cache (gotcha #40 — failed, rolled back)
|
||
|
||
**Tốc độ:** code commit ~3 phút / docs-only commit **0s** (skip).
|
||
|
||
## 🛠️ Skills (.claude/skills/) — 6 skill PHẢI dùng khi task khớp
|
||
|
||
| Domain (3) | Ops (3) |
|
||
|---|---|
|
||
| `contract-workflow` — state machine + versioned WF | `dependency-audit-erp` — npm/dotnet CVE scan |
|
||
| `form-engine` — render docx/xlsx + PDF | `ef-core-migration` — EF migration + 3-file rule |
|
||
| `permission-matrix` — role × menu × CRUD | `iis-deploy-runbook` — 3 site IIS + win-acme + runner |
|
||
|
||
**Audit định kỳ:** đầu mỗi tháng — combined skill + doc drift audit theo `docs/rules.md §6.4 + §9.4`. Cron `solution-erp-skill-audit-monthly` fire 9:00 ngày 1. Lần kế: **2026-05-01**.
|
||
|
||
Quy tắc:
|
||
- KHÔNG bulk-clone repo skill 3rd party. Chỉ thêm skill PROJECT-SPECIFIC. Xem `docs/rules.md §9` đầy đủ.
|
||
- KHÔNG rewrite toàn bộ MD định kỳ. Chỉ compact + patch drift. Xem `docs/rules.md §6.4` đầy đủ.
|
||
|
||
## 📖 Tài liệu quan trọng
|
||
|
||
| File | Nội dung |
|
||
|---|---|
|
||
| [`docs/STATUS.md`](docs/STATUS.md) | **🔥 Current state** — đọc đầu tiên |
|
||
| [`docs/HANDOFF.md`](docs/HANDOFF.md) | Brief 5 phút: session trước làm gì + next tasks |
|
||
| [`docs/rules.md`](docs/rules.md) | ⭐ Coding conventions (BE Clean Arch, FE React, DB, Git, Docs) |
|
||
| [`docs/architecture.md`](docs/architecture.md) | ⭐ Layered architecture + request lifecycle + deployment |
|
||
| [`docs/PROJECT-MAP.md`](docs/PROJECT-MAP.md) | Bản đồ tổng quan |
|
||
| [`docs/changelog/migration-todos.md`](docs/changelog/migration-todos.md) | Roadmap 5 phase + atomic tasks |
|
||
| [`docs/CLAUDE.md`](docs/CLAUDE.md) | Full context — tech stack chi tiết |
|
||
| [`docs/workflow-contract.md`](docs/workflow-contract.md) | State machine 9 phase HĐ + role matrix |
|
||
| [`docs/forms-spec.md`](docs/forms-spec.md) | Catalog 8 form + quy định mã HĐ RG-001 |
|
||
| [`docs/database/database-guide.md`](docs/database/database-guide.md) | DB conventions + migration workflow + cheatsheet |
|
||
| [`docs/database/schema-diagram.md`](docs/database/schema-diagram.md) | ⭐ ERD + luồng DB + data flow 52 table (+ §11 PE module + §12 Budget module + §13 PEDeptOpinions) |
|
||
| [`docs/flows/README.md`](docs/flows/README.md) | Index 6 flow (auth, permission, contract, form, SLA) |
|
||
| [`docs/gotchas.md`](docs/gotchas.md) | ⭐ 26 bẫy đã gặp — đọc trước khi debug tương tự |
|
||
| [`.claude/skills/`](.claude/skills/README.md) | 6 skill: contract-workflow, form-engine, permission-matrix, dependency-audit-erp, ef-core-migration, iis-deploy-runbook |
|
||
| [`docs/guides/vps-setup.md`](docs/guides/vps-setup.md) | ⭐ Master runbook deploy VPS shared với VIETREPORT |
|
||
|
||
## ⚠️ Kết thúc session
|
||
|
||
1. Update `docs/STATUS.md` (`In Progress` → `Recently Done`)
|
||
2. Tick checklist tương ứng trong `docs/changelog/migration-todos.md`
|
||
3. Tạo session log `docs/changelog/sessions/YYYY-MM-DD-HHMM-{topic}.md` nếu đáng ghi
|
||
4. Commit `[CLAUDE] <scope>: <message>`
|
||
5. ⚠️ **Update `SolutionErp.slnx`** nếu có `.cs/.csproj` mới
|
||
|
||
> Bỏ qua nếu chỉ trả lời câu hỏi, không sửa file nào.
|