- Session log S42-S43 (P11-A WorkflowApps ApproveV2 + P11-B LeaveBalance, 8 commit chain) - HANDOFF tiering: +S43 +S42, trim S40-S38 → session logs - gotcha #56 CWD-drift stray memory (cd trước spawn → agent ghi nhầm fe-user/.claude, 3× S42-S43) - STATUS gotchas 55→56 - cicd-monitor MEMORY (Run #367 P11-B verdict) User memory: +feedback_high_to_max_multiagent_quality (High lọt 2 bug, Max 0 bug; WIRE FE đọc reference proven + FK-invariant-at-write-doors + Max re-review cross-stack). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
12 KiB
STATUS — Snapshot hiện tại
Update rule: trước khi bắt đầu 1 task → ghi row
🔥 In Progress. Xong →✅ Recently Done. Tiering rule (S40): chỉ giữ state hiện tại + 3 session gần nhất ở file này. Session cũ hơn →docs/changelog/sessions/. Full history pre-S40 →docs/_archive/STATUS-preS40-fullhistory.md. (Tránh over-context — xóa double, không cắt nội dung.)
Last updated: 2026-05-30 (Session 42 — Phase 11 P11-A SHIPPED: wire ApproveV2 + LevelOpinions cho 4 WorkflowApps module (Leave/OT/Travel/Vehicle). Mig 41 + 30 handler + 8 route + FE detail ×2 + 11 test. Run #250 PASS, deployed prod.)
🎯 CURRENT STATE (verified S40)
| Metric | Value | Note |
|---|---|---|
| Migrations | 42 | last AddLeaveBalances (20260530034336) |
| SQL tables | 91 | +1 S43 LeaveBalances (verified prod, UNIQUE composite + FK LeaveTypes Restrict) |
| API endpoints | ~241 | +3 S43 (leave-balances my/admin/adjust) |
| FE pages | 67 | WorkflowAppDetailPage (admin+user SHA256 identical) |
| Menu keys | ~53 | BE MenuKeys const (FE menuKeys.ts mirror 54) |
| Tests | 154 PASS | 58 Domain + 96 Infra · 0 fail / 0 skip · +11 LeaveBalance/guard S43 |
| Gotchas | 56 | docs/gotchas.md (latest #56 CWD-drift stray memory S42-43) |
| User memory | 27 | + MEMORY.md index |
| Skills | 6 | 3 domain + 3 ops |
| Sub-agents | 7 | Opus 4.8 1M (S39 split 4→7) |
| RAG chunks | 2406 | ✅ S41 re-bootstrap clean (3080→2406, −674 junk: node_modules+_archive now excluded; user-memory 60 chunks/10 files slug-fixed + S38-S41 indexed) |
Bundle hash live (prod): admin Krjvg_3j · user 6sNStgxa (Gitea #367, S43 P11-B). Auth-verified prod: /leave-balances/my?year=2026 → 5 LeaveType lazy-default (Used=0, remaining=entitled).
Phase: ✅ Phase 10 COMPLETE · 🔄 Phase 11 IN PROGRESS — P11-A + P11-B DONE (deployed prod) · ⬜ P11-C..F pending · 🚫 Phase 9 Ops blocked (anh main coordinate).
⚠️ Count drift fixed S40: endpoints ~223→211, FE pages 53→65, menu keys 85→~53. Tables 84 confirmed correct (DbSet 77 + Identity 7). 3 số "khó fake" (mig/gotcha/git) luôn đúng. Cause: số "incremented mỗi session" over/under-count optimistic — re-ground định kỳ.
🔥 In Progress (S43)
| Task | Owner | Status |
|---|---|---|
| (none — P11-A + P11-B SHIPPED + verified prod. Next: P11-C..F khi anh chọn) | — | ✅ |
S40 done: ✅ Consolidation (d2f52ba) · ✅ Curate 4 agent MEMORY >25KB→<8.4KB (78c9de3) · ✅ RAG catch-up chunk S37-S40 (rerank 0.867) · ✅ AI_INFRA bulletin 2026-05-29 adopt 4/4 (MỤC2 Tiered Memory Policy v1 6f08d1f + MỤC3 /session-start+/session-end slash commands c8ff5e1). ⏳ Full RAG re-index = AI_INFRA op (cần VOYAGE_API_KEY).
⚙️ NEW slash command (
.claude/commands/) — anh main restart CLI để activate (không hot-reload) → session sau gõ/session-start+/session-endthay paste prompt thủ công.
✅ Recently Done (newest on top — 3 session; cũ hơn → session logs)
S43 (2026-05-30) — 🔄 Phase 11 P11-B: LeaveBalance business logic (trừ phép + số dư)
- Commit
82d7fcf→ Gitea #367 PASS ~4m08s, deployed prod. 7-agent (recon → BE → FE ∥ test → reviewer → cicd), agents Max → 0 bug lọt. - Mig 42
AddLeaveBalances(additive):LeaveBalances(User×LeaveType×Year + Entitled/Used/Adjustment, UNIQUE composite + FK LeaveTypes Restrict). 90→91 tables. - Trừ phép: hook
ApproveLeaveRequestHandlernhánh terminal DaDuyet — exactly-once (guard chặn re-approve), upsert auto-create từDaysPerYear,UsedDays += NumDays, Year=StartDate.Year. Policy cho phép âm + cảnh báo (anh chốt). - FK invariant guard (em Max-review thêm sau test reveal): Create + UpdateDraft validate LeaveTypeId tồn tại → ConflictException (đóng cửa, tránh 500 kẹt đơn lúc deduction FK insert).
- CQRS
LeaveBalanceFeatures.cs: GetMy (self lazy-merge active LeaveType) + GetUser (admin) + Adjust (admin upsert). Embed balance NGƯỜI TẠO vào leave detail (approver xem đúng). - FE:
WorkflowAppDetailPage×2 block "Số dư phép" + cảnh báo vượt (kind=leave, SHA256 identical, tích hợp trang đơn nghỉ — không trang riêng). - Test: 144→154 (+11 LeaveBalance/guard + repair 2 template terminal FK). Reviewer Max PASS (deduction exactly-once + FK fully closed; 2 minor defer: concurrency lost-update no-RowVersion + stale comment).
- Verified prod: Mig 42 applied, LeaveBalances UNIQUE+FK ✓,
/leave-balances/my200 → 5 LeaveType lazy-default, bundle rotate.
S42 (2026-05-30) — 🔄 Phase 11 P11-A: wire ApproveV2 + LevelOpinions 4 WorkflowApps module
- Commit
e7b66cd(Gitea #364) + fix75df04e(#365) → PASS, deployed prod. Cookie-cutter mirror Proposal (Mig 38). 7-agent end-to-end (recon → BE×3 → FE → test → reviewer → cicd). (Run-id "#250" memory truncated ghi sai → Max re-verify reconcile #364/#365.) - Mig 41
WireWorkflowAppsApprovalV2(additive): +4 bảng{Leave,Ot,Travel,Vehicle}LevelOpinions(UNIQUE composite + Cascade/Restrict) +WorkflowAppCodeSequences(shared atomic MaDonTu) + 4 cộtRejectedFromStatus+ enumTravelRequest=9. - BE: 30 handler (
LeaveOt+TravelVehicleApprovalFeatures.cs) — GetById/Update/Submit/Approve(UPSERT+advance)/Reject/Return + verify ApplicableType per module. 8 controller route. Seed 4 WF mẫu (QT-NP/OT/CT/XE-V2-001, AppType 5/6/7/9) — gotcha #51 INFRASTRUCTURE-gated PASS prod. - FE:
WorkflowAppDetailPage.tsxdeclarative 4-kind (admin+user SHA256 identical) — workflow status + opinion timeline + Submit/Approve/Reject/Return actions; gỡ banner skeleton + row nav. - Test: +11
WorkflowAppApproveV2Tests(130→141) — state machine + UPSERT invariant + guards + forbidden + placeholder + codegen. No prod bug. - Verified: Mig 41 applied prod (5 bảng EXIST) · bundle rotate cả 2 app · 4 endpoint live · seed prod · reviewer checklist (no copy-paste bug, [Authorize] OK).
- ⚠️ Gotcha #53/#55 tái diễn 3× session này (FE + reviewer + cicd-monitor truncate output cuối) — mỗi lần recover qua MEMORY + em main manual verify. Anti-truncation lesson reinforced.
- 🔬 Max re-review (agents chạy High) phát hiện + fix 2 bug FE picker (chưa commit lúc deploy đầu): (#1)
pinWorkflowPUT/{id}partial → 400 validator; (#2) fetch expect array nhưng endpoint trả{types}object → picker rỗng. Fix: thêm endpoint chuyên dụngPUT /{id}/workflow(set workflow only, verify ApplicableType) + sửa fetch mirror PE/Contractdata.types.find().history.filter(isUserSelectable). +3 test SetWorkflow (141→144). Bonus phát hiện:ProposalCreatePage(S37) có bug #2 có sẵn → spawn task riêng. - 📌 Follow-up minor (non-blocking): known-minor unreachable (Reject/Return actor-check khi CurrentApprovalLevelOrder null) · deploy.yml stale comment "54/17 test" (cosmetic) · test Travel/Vehicle mirror pending (Leave full + Ot smoke có).
S41 (2026-05-29) — RAG corpus cleanup (w/ AI_INFRA)
- AI_INFRA RAG audit → SE-side prep:
.claude/rag.jsonexclude root-anchored→**/-anchored (defeats gotcha #10:node_modules/**+docs/_archive/**weren't matching nested paths) + retired stale_decision_log"+321%/11,922". - store_memory reconcile (anti-data-loss, NAMGROUP lesson): unified at-risk rule = content reproducible từ file {exists ∧ matches corpus glob ∧ not excluded}. 5/5 accounted: 3 broadcasts disk-twinned +
16a6b6dbaudit-response twin-safe +0307141bS37-S40 catch-up promoted-to-disk (docs/changelog/sessions/2026-05-29-S37-S40-rag-catchup.md— anchor was virtual, not real STATUS section). - AI_INFRA re-bootstrap host-side
--config: 3080→2406 (−674 junk), node_modules=0 / _archive=0 / manual-marker=0, user-memory 60 chunks (slug fix). SE post-verify PASS (promoted catch-up returns file-indexed real heading, not(manual)). Commits282cbd0+e8cbbe5pushed (docs/infra → CI skip). - ⏳ Standing infra backlog (AI_INFRA, non-blocking): bootstrap glob→0 warn · auto_reindex hook fire · search_code corpus gap (src/.cs+fe/.tsx, v0 design) · registry sync.
S40 (2026-05-29) — Init audit + doc consolidation
- 7-agent smoke verify (🟪 test-specialist + 🟦 investigator-api load OK), RAG re-rank PASS (top 0.8789 Voyage rerank-2.5), 130 test confirm.
- Doc consolidation: STATUS 170KB→5.7KB + HANDOFF 224KB→3.4KB (archive full →
docs/_archive/). Count re-ground (endpoints 211, FE pages 65, menu ~53; tables 84 confirmed). Stale credentialadmin@solutionerp.local→admin@solutions.com.vnfixed. CLAUDE.md root patch (mig/table/test). - Curate 4 agent MEMORY >25KB→<8.4KB (~130KB→41KB, foundation preserved + verbatim git). RAG store_memory S37-S40 catch-up chunk. 2 commit push
d2f52ba+78c9de3(docs-only CI skip).
S39 (2026-05-29) — ⚙️ INFRA: Opus 4.8 1M + Multi-agent 4→7 + budget +50%
- Pure infra/governance, 1 commit
fd0554a(docs CI skip). Model default Opus 4.8 1M. investigator→codebase+api · implementer→backend+frontend · +test-specialist (purple). 5 RAG MCP/agent. 2 gotcha NEW #54 (529 fallback) + #55 (truncation mid-exploration). CLI restart → registry hot-reload (done S40). - →
docs/changelog/sessions/2026-05-29-S36-S39-phase10-complete-7agent.md
S38 (2026-05-28) — 🎊 PHASE 10 COMPLETE 11/11 (SKELETON combo)
- Mig 39+40 + BE ~1100 LOC + FE 5 file × 2 app + 8 menu. Run #247 PASS 3m25s. G-O4/O5/O6/P1/H3 skeleton. Trade-off DEFER Phase 11: ApproveV2 wire + LevelOpinions per-module + LeaveBalance + CodeGen atomic + Vehicle/Driver catalog + ItTicket auto-assign/SLA.
- → same session log
🎯 Next up
🔄 Phase 11 — Polish/wire skeleton (IN PROGRESS)
- ✅ P11-A wire ApproveV2 + LevelOpinions 4 module (Leave/OT/Travel/Vehicle) — DONE S42 (Run #250, deployed prod). CodeGen MaDonTu cho 4 module ĐÃ gộp luôn (WorkflowAppCodeSequences) → P11-F phần ItTicket MaTicket còn lại.
- ✅ P11-B LeaveBalance business logic — DONE S43 (Mig 42, trừ phép terminal + số dư + FK guard, Gitea #367 prod).
- P11-C Vehicle+Driver catalog Mig 43 · P11-D ItTicket auto-assign + SLA timer · P11-E AttendanceReport + Excel + OtPolicy multiplier · P11-F CodeGen atomic MaTicket (MaDonTu xong S42)
🔧 Maintenance backlog
- Curate 4 agent MEMORY >25KB: investigator-codebase 35.7 / cicd-monitor 35.3 / implementer-backend 30.9 / reviewer 28.4
- RAG re-ingest
solution_erpS37-S39 content (Proposal/WorkflowApps/7-agent) - Test coverage gaps: Gap1 HrmConfig Holiday composite UNIQUE (🔴 CRITICAL) · Gap2 EmployeeSatellite cascade · Gap3 gotcha #44 regression
EmployeesController+HrmConfigsController - Skill + doc drift audit cron 2026-06-01
🚫 Phase 9 Ops (blocked — anh main coordinate)
- SMTP email outbound · Rotate prod creds · SQL auto-backup (backup-sql.ps1 ready, chờ Task Scheduler register) · UAT 2-3 user 1 tuần
🚨 Blockers / risks
- ⚠️ Email SMTP chưa có — blocker notification outbound
- ⚠️ Credentials trong chat — rotate trước go-live thật
- ⚠️ SQL backup chưa auto — risk data loss (script ready, chờ register)
- ⚠️ UAT real user chưa chạy — risk edge-case bug
- ⚠️ Cert
api.solutions.com.vnexpire ~2026-07-23 (auto-renew ~06-23)
🔑 Credentials + URLs
Prod login: admin@solutions.com.vn / Admin@123456 (⚠️ rotate sau login đầu)
- API prod
https://api.solutions.com.vn(/health/live+/health/ready) · devhttp://localhost:5443(/swagger) - Admin FE prod
https://admin.solutions.com.vn· dev:8082 - User FE prod
https://eoffice.solutions.com.vn· dev:8080 - Gitea
https://git.baocaogiaoduc.vn/vietreport-admin/solution-erp· SSHssh vietreport-vps - SQL prod
.\SQLEXPRESS/SolutionErp· dev(localdb)\MSSQLLocalDB/SolutionErp_Dev
Session history: S0→S39 full detail trong
docs/changelog/sessions/+docs/_archive/STATUS-preS40-fullhistory.md. File này chỉ giữ state hiện tại + 3 session gần nhất.