All checks were successful
Deploy SOLUTION_ERP / build-deploy (push) Successful in 5m7s
Phase A of the NCC/TP Excel-import backlog (anh Kiet FDC). Supplier entity 9 -> 27 fields to hold the 30-column supplier database. Backend: - Supplier +18 nullable cols; SupplierType +CaHai=6 (append-only); new nullable SupplierStatus enum. - Mig 62 ExpandSupplierFields (3-file): AddColumn x18 + guarded un-cram Sql (clear legacy crammed Note on the 4 seeded rows, exact-match). No new table (89), reversible Down. - Seed fill-nulls-if-exists: populate 30 fields for TRUONGGIANG/TANPHU/ TGN/DONGDUONG from Excel; idempotent, never clobbers existing cols. - DTO + Create/Update commands + validators (MaximumLength-only, no NotEmpty so open-auth Create minimal payload stays valid) + 2 query projections. Frontend (fe-admin + fe-user, byte-identical SHA-mirror): - types/master.ts +18 fields +SupplierStatus; SuppliersPage form 4 section groups + Status select + 3 NAS links via new shared PathLink (extracted from PE HoSoLink render+Copy). All new fields optional. Excel upload auto-map = Phase B (deferred). Tests test-after (UAT mode). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
8.5 KiB
8.5 KiB
investigator-codebase — archive 2026-07 (L2 verbatim, frozen additive)
Curated 2026-07-06 (em-main, hook-triggered L1->L2)
- 2026-07-03 S101 H19-adopt Lane-2 (mapping + model-tier compliance, WF1 investigate — VERDICT SOUND): ⭐ Mapping CORRECT: reviewer=final-review-gate (Category 1-6 adversarial + Smart-Friend anti-rubberstamp
reviewer.md:268-276+ live-curl deploy-verify = H19 §3a "cổng rà-soát cuối" exact) · investigator-codebase=ground-truth-lane (investigator-codebase.md:23-26file:line-evidence + sqlcmd + grep + "if uncertain say uncertain" = H19 §3b "xác-minh sự-thật chống bịa-số/dẫn-chứng"). NO better-fit: investigator-api=EXTERNAL-docs (WebFetch, out-of-scope internal-truth) · database-agent=narrow DB-lens (subset không phải general fact-verify). Model-tier checklist 12-pt: SE meets A1✅(settings pinclaude-fable-5[1m]—[1m]VALID in settings.json ≠ frontmatter; Fable-down→Opus 1M H5-fallback = A1/A2 frontier-1M allowed) A2✅ A3✅(all-inherit=all-top, 5-fn map) A4/A5/A6 N/A-by-form(no tier-2/helper layer) B1✅ B2✅ B3✅(11 role-names SE-own, 0 copied) C1✅(11/11model: inheritgrep) C2✅(hmw.jstierfield) C3✅(0[1m]in FRONTMATTER model: line — 4 grep hits ALL prose: README:9/12/16 Upgrade-notes + database-agent:46 checklist). ⚠️ Toggle-marker template EXACT-exists:.claude/hmw-mode.ongitignored AFTER!.claude/**last-match-wins (.gitignore:87); new.claude/model-real-mode.onMUST copy placement or gets un-ignored. ⚠️ Ảo-ensemble reuse: hmw.jsparallel():97 + synthesis machinery PRESENT (grep 10 hits) — but "S101 WF2 3-lane" is LIVE-mechanism NOT persisted artifact (runs/ = old 06-18 only, HMW-ephemeral S94+ pattern). VACUOUS-MET nuance TRUE: under all-inherit+Fable, 2 positions ALREADY top → H19 §4 "allow reach top-model" adds 0 runtime-delta; new value = toggle depth-control + Fable-outage multi-Opus>single-Opus. Tag[s101-h19-lane2, mapping-sound, 12pt-compliance, marker-template, vacuous-met]. - 2026-07-02 (S100 H18-adopt WF1
wf_50a817ce-a69— 3 lane ∥, on-behalf em main APPEND B3, return-only 0-residual): L1 measurer-coverage: 3/3 script (mfe-eval:216/selfimprove:133-137/archive-gate:106) GLOB-LIVE 0-hardcode — agent thứ 12 tự-cử; ⭐ ghost-wire-class MỚI: config-key defined-but-unread (memory-budget.json:54-55role_file_glob/diary_path_pattern— script re-hardcode giá trị TRÙNG → không detector nào flag vì cả 2 phía "đúng"; catch = grep key-name across scripts/) + latent skip-if-no-tools:(selfimprove:147, 0 affected 11/11 có). L2 ghost-wire+taxonomy: MAST=0 repo-wide (grep PHẢI case-sensitive\bMAST\b— insensitive dính "Master" noise); cron monthly = ghost-wire THẬT (CronList=0 + scheduler RỖNG 05-04 log + S96 chạy 13:04 em-main in-session); convention "auto = step em-main kích, no-OS-hook" nhất quán 5 nơi. L3 ledger-đo:_ledger.mdtrue-orphan-catch 0/15 lifetime (single-day artifact 06-18, 15 row/14 folder — mig54-R2 share) · mode-A coverage 0/8 S93+ · ⭐ "S71harvest/rỗng" = criterion-wording KHÔNG phải incident (đính chính claim em-main) · repo có 5 "ledger" khác tên → sweep grep_ledgerEXACT · hmw.js 0-touch. Tag[s100-h18-wf1, 3-lane, ghostwire-configkey-class, ledger-0-15, on-behalf]. - 2026-07-02 S98 verify-lane V2 post-flush (VERDICT PASS): detector 28→25 (derived-stale 11→8; wikilink 14 + vocab-fork 3 giữ by-design). 8 derived-stale còn = 100% FP-class count-token soft-net: CLAUDE.md:84 tests-tree "(6 test…)" · ef-core SKILL :94/:95 ("2/1 migration tách/GỘP" history) + :103/:111/:114 ("4/3/1 bảng" Budget-defer/Mig-15 module-local) + :162/:179 (heading "Revert 1 migration" + comment "Script từ 1 migration") — 0 genuine drift vs canonical 61/89/440/79; SKILL edit sáng (+rows 60/61 @:82-83) chỉ shift line-number FP cũ, 0 flag MỚI. ⭐ Grep gotcha: "Fable RESTORED" exact-string CHỈ STATUS:24 + session-start:29; agents/README dùng biến-thể "Fable 5 1M RESTORED" (:3) + "Fable-restore" (:12) — exact-phrase grep miss README dù substance đủ. HANDOFF:5 mega-line: bundle mEGqlNWc/Dnrp4PU1=#484, CeTA7Z82 chỉ trong note "= #483" (1 line match duy nhất cả file). 3 on-behalf append đúng-chỗ: database-agent :36 (cuối Log = EOF) · reviewer addendum TRONG-entry S97-bis :68 (câu cuối + marker on-behalf @S98) · impl-fe S97-Part2 :16 giữa badge:9/S97:19. cicd "S98" = 2× "(curate S98)" stub :73/:74, 0 material-tag. Ledger :7 Mode-A ephemeral note (wf mode-A vắng ledger-row ≠ orphan) + bảng 15 row :11-25 nguyên.
- 2026-07-01 S97 session-end feedback-audit (VERDICT CLEAN): Grep-verified capture readiness pre-close. ✅ gotcha #77/#78/#79 present
docs/gotchas.md:1301/1317/1325(format### N.count=79 = STATUS header — no self-count drift; all 3 have Triệu-chứng+Cơ-chế+Fix+Quy-tắc root-cause). ✅ #53 return-garble x6 (cicd 5/6) in BOTHfeedback_agent_return_garble_recover.md(Why-line ×5→×6 + structural root-cause: cicd MEMORY self-target ~17.1KB→curate-at-return→thinking-step=message-cuối=return-value; fix=archive-cicd-sớm NOT instruction) AND S97-log Parts 1/2/4 (lần-4/5/6). cicd MEMORY LIVE=17.5KB (confirms self-target). ✅ Mig 60 wrong-table BUG = 2-fix present: code (Mig 6120260701142752query Changelogs) + guard (gotcha #79 "xác định ĐÚNG bảng writer" + "verify marker-count prod trước"). Mig 60 code:29-31confirmedPurchaseEvaluationApprovals a...a.Comment LIKE= wrong. Both Mig 60/61 have 3-file rule. ✅ git status CLEAN, 0 stray.claudemisland, 0git add -Ain log, S97 workflows HMW-ephemeral (NOT persisted run-folders — consistent S94+ pattern, runs/ only old 06-18). ✅ Product decisions captured (STATUS/HANDOFF/log + commit-msg): "duyệt là fix"→#480 price-lock, "fix trọn"→Mig 60 endsBeforeCeo-runtime, "hiện luôn CEO duyệt"→#483 badge, Supplier-backlog "15-18 field"→STATUS Next-up. MINOR only: S97-log per-Part State footers show progression (Part-1:47"88 bảng gotcha 77" stale vs session-end "89/79" Part-4:113) — intentional per-part snapshot but mid-log reader sees stale count. No BLOCKING/MAJOR gaps. - 2026-07-01 Supplier Excel-import GAP audit (anh Kiệt FDC — 30-col "Database NCC & Nhà thầu phụ" cho bên Pro): ⭐ Entity CỰC LEAN 9 domain-prop (
Domain/Master/Supplier.cs:5-16: Code·Name·Type·TaxCode·Phone·Email·Address·ContactPerson·Note) + 8 audit inherited (Base/AuditableEntity). EFSupplierConfiguration.cs: Code len50 UNIQUE-filtered[IsDeleted]=0(:24, Mig47 #57), Name200, TaxCode20, Phone30, Email100, Address500, ContactPerson200, Note1000. enumSupplierType.cs:3-10= NhaCungCap1/NhaThauPhu2/ToDoi3/DonViDichVu4/ChuDauTu5 — KHÔNG có "Cả hai/Both" (FE mirrorfe-admin/types/master.ts:11-16identical). GAP 30→entity: 6✅ · 7⚠️collision · 17❌ no-home — Excel splits Address×2(invoice/office), Phone×2(company/contact), ContactPerson+role; ❌ Fax·Bank-acct×2·Legal-rep+role·GUQ+3-NAS-links·Status/blacklist·Referral·PMH-owner. ⚠️ S55 seedSeedRealMasterDataAsync(DbInitializer.cs:2768-2787) crams NĐD/bank/status/category vào free-textNote(:2771-73 TRUONGGIANG/TANPHU/TGN) — proof entity thiếu home. Seed UNGATED (called :128, idempotent-key=Code:2780) — KHÁC demo-master (SeedDemoMasterDataAsyncGATEDDemoSeed:Disabled:117, #75). POST any-auth (SuppliersController.cs:37-42S59). FE SHA-identical 2-app (c1760788, 253L, 9 fields). Prod 20 NCC (Type1×3+Type2×17; type3/4/5 wiped go-live S91 → "Cả hai" enum genuinely-needed). Precedent NAS-link =PE.HoSoLink nvarchar(1000)Mig52. Fork→em-main: core-widen ~15col+CaHai=6 vs satelliteSupplierDetail. → _INDEX pending. - 2026-06-29 S93 Harness-16 MFE ground-truth (WF1
wf_4c63e1bd): ⭐ MFE denominator extraction (deterministic, status-field KHÔNG grep): marks Active(-High) (ACTIVE-MARKS.md) + AS-class + Active-Guards (error-ledger.mdVerified✅) + recurring-gotcha (gotchas.md); dedup-by-AS-cross-reference (gotcha/guard mà AS-row trỏ#N/AS-N→ gộp) = 29 item. Per-role sub-coverage: denom = numbered anti-pattern/NEVER trongagents/<role>.md; numer = diaryagent-memory/<role>/MEMORY.md(KHÔNG project/user — bẫy trùng-tên H15-v3) match exact-id OR ≥2 content-word sau stop-list (đánh bại leading-verb-9/9-giả). Codifiedscripts/mfe-eval.ps1+ engine §H. (WF1 self-write reverted AS-10; em-main harvest single-writer.) → _INDEX.