[CLAUDE] Docs: S48 adap-* verify closure post-restart + Gov-v2 error-ledger + §L.b
- store_memory strip VERIFIED-runtime (registry 0/8 subs) — adap-report updated - frontend-designer FD2 loop VERIFIED-RAN (first spawn) — adap-report updated - Gov-v2 delta CLOSED: NEW docs/governance/error-ledger.md (blameless RCA + Active-Guards index + AS-1..AS-9 deterministic-detect + 3-ledger triad) + session-end.md Phase 1.5 §L.b 6-step - STATUS/HANDOFF S48 + session log + frontend-designer MEMORY flush (FD2 rig + Tailwind-v4 fact) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@ -6,7 +6,7 @@
|
||||
`2026-06-02-Agent-frontend-designer-floor` (category: Agent · reviewer_gate: PASS · targets: all-fit)
|
||||
|
||||
## 2. nac G-011
|
||||
**executed** (file-level: 8th agent forked + roster doc synced) → **verified-pending** (restart + spawn-test FD2 visual loop).
|
||||
**executed** (S47 file-level) → **agent-load VERIFIED** (S48 post-restart) → **FD2 visual-loop VERIFIED-RAN** (S48 first spawn: full loop executed THẬT on fe-user `/login` — 4 screenshots taken+viewed @375/1440, FD4 rubric scored all-PASS, 1 bounded a11y fix applied, re-screenshot confirmed, `npm run build` PASS 0 TS error). Only remaining = AI_INFRA `/adap-audit` 2-way.
|
||||
|
||||
## 3. evidence
|
||||
- **NEW sub-agent (8th):** `.claude/agents/frontend-designer.md` — **forked** canonical `D:\...\AI_INFRA\docs\templates\frontend-designer.agent.template.md` (NOT copy-paste; tailored SE stack). FD1–FD10 floor present (FD2 visual loop + FD4 rubric kept verbatim-intent).
|
||||
@ -14,7 +14,7 @@
|
||||
- **Roster doc:** `.claude/agents/README.md` — header 7→8 · S47 upgrade note · decision-tree branch · split-boundary row · skill-matrix row · 8 memory folders.
|
||||
- **Frontmatter checks (sister-guide):** `model: inherit` (NOT `[1m]`, gotcha #37) · `color: pink` (unique vs {cyan,blue,yellow,orange,purple,red,green}) · `description: |` block-scalar (no colon-space parse risk) · `store_memory` STRIPPED (consistent w/ broadcast #1 — RAG-read only: search_memory/search_code/cross_project_search/list_projects).
|
||||
|
||||
commit-sha: _unpushed (working-tree) — batch with restart-verify._
|
||||
commit-sha: **`72bbfa5`** (committed S47). **S48 re-verify:** agent present in available `subagent_type` registry (loads OK) · frontmatter on disk = `model: inherit` / `color: pink` / `description: |` block-scalar / `effort: max` / 0 `store_memory` — all confirmed. (`effort: max` did NOT cause file-reject → registry accepted it.)
|
||||
|
||||
## 4. tailored-gì + skip-gì-vì-sao
|
||||
- **PROJECT-FIT decision (S47):** SE has FE (2 React apps) → NOT the "no-FE → n-a" skip. User chose **ADOPT** over defer-with-pushback (upcoming greenfield FE: P11-E AttendanceReport + dashboards).
|
||||
@ -28,7 +28,10 @@ commit-sha: _unpushed (working-tree) — batch with restart-verify._
|
||||
- **Floor NOT lowered** (add-only-increase §F4.1) — FD1–FD10 all present. Recommended ADD noted (design-review via existing `reviewer`).
|
||||
|
||||
## 5. honest-caveat
|
||||
- **VERIFIED-pending (§C5 no-fake):** agent `.md` no hot-reload → requires **restart + spawn-test** 1 small design task to confirm the FD2 screenshot loop runs THẬT. NOT claiming `verified`.
|
||||
- **FD2-loop VERIFIED-RAN (S48 spawn-test, §C5 — genuinely ran, not fake):** first real `frontend-designer` spawn executed the full loop on fe-user `/login`: read DS → Vite dev → Playwright screenshot 375+1440 → **Read/viewed the PNGs** → FD4 adversarial critique → bounded fix (`fe-user/src/pages/LoginPage.tsx:55` subtitle `text-slate-500`→`text-slate-600`, contrast ~7.5:1, on-scale no magic-number) → re-screenshot confirmed → build PASS 0 TS error. 4 screenshot artifacts exist. **Visual-verification-loop now runtime-PROVEN** (was the open item). Remaining external = AI_INFRA `/adap-audit`.
|
||||
- **Rig lessons captured in FD MEMORY** (reusable): Vite-dev `networkidle` never fires (HMR ws) → use `domcontentloaded` + `wait_for_selector('form')`; cold-start Vite dep-optimize >15s → warm-up `goto` 60s before viewport loop. **Template fact corrected:** SE = **Tailwind v4 CSS-first** (`@theme{}` in `fe-*/src/index.css`, brand-600 `#1f7dc1`) — **NO `tailwind.config.js`**.
|
||||
- **Still un-wired (quality-ADD, not floor):** ⭐ FD4-rubric design-review gate via existing `reviewer` — wire when a larger design task runs (§F4.1 add-only).
|
||||
- **Parity:** FD scoped fix to fe-user only; fe-admin `/login` parity handled by em main (see commit) to avoid 2-app inconsistency.
|
||||
- **FD2 rig not yet stood-up/run:** SE FE is an **authenticated ERP** (authed pages need API+SQL+login to render). The rig (webapp-testing + login fixture) is **documented in the agent body + memory**, but first-spawn (post-restart) validates it actually shoots. Fallback static-preview documented (no skip-soi).
|
||||
- **`effort: max`** included (canonical + dogfood-proven same-machine VIPIX/BVAAU); SE's 7 existing agents don't use it — if this CLI rejects the field, restart spawn-test will reveal (flagged). Floor unaffected either way (FD1–FD10 in body).
|
||||
- **Recommended quality-ADD not yet wired:** sister-guide ⭐ design-review-by-second-agent — SE HAS `reviewer`; wire FD4-rubric gate when first design task runs (quality-increase §F4.1, not floor).
|
||||
|
||||
@ -6,7 +6,7 @@
|
||||
`2026-06-02-Governance-gov-v2-session-cmd-framework` (category: Governance · reviewer_gate: PASS · targets: all-fit)
|
||||
|
||||
## 2. nac G-011
|
||||
**executed** (already-applied S44, file-committed) → **verified-pending** (full 5-axis function-completeness delta below + AI_INFRA cross-repo audit).
|
||||
**VERIFIED-2way core** (already-applied S44 `ae30f8f`, AI_INFRA RT3) + session-cmd **re-demonstrated S48** (#6 echo-body + #7 plan-tree this `/session-start`). **Delta now CLOSED at executed-file (S48):** error-ledger built + §L.b 6-step wired into session-end (see §3/§5). Full = verified-runtime on next `/session-end` run + AI_INFRA `/adap-audit`.
|
||||
|
||||
## 3. evidence
|
||||
- **ALREADY-APPLIED S44 (2026-06-01):** `docs/governance/README.md` "Cross-Project Adoption Ledger" logs bundle 2026-06-01 = §A auto · §B align (no new layer) · §C wording ×7 · §D #4 step · ✅ **VERIFIED 2-way** (AI_INFRA RT3). Commit chain `ae30f8f → 071c25c` (the broadcast precondition line cites `SE ae30f8f`).
|
||||
@ -21,6 +21,6 @@
|
||||
- **Helper-note (feature 8) = n-a** (roster-0-helper).
|
||||
|
||||
## 5. honest-caveat
|
||||
- **DELTA / partial (brutal-honest, §M):** SE has the session-cmd features + Gov-v2 *principles*, but a **formal, distinct 3-ledger** — specifically an **error-ledger with blameless RCA + Active-Guards index + 2-strike-promote**, and **§L.b 6-step session-end auto-maintain as an explicit deterministic checklist** — is **only PARTIALLY formalized** (function distributed across gotchas.md + STATUS + session-logs; dedicated-artifact form not fully built). This is the main open gap vs the broadcast floor.
|
||||
- **Proposed next:** formalize the error-ledger + §L.b auto-maintain checklist as a follow-up (candidate for `/adap-apply` post-restart or a small Gov hardening task). Flagged, not silently claimed-done.
|
||||
- **nac honesty:** executed (file-level S44 committed) — NOT claiming `verified` for full 5-axis completeness; that needs the delta above + AI_INFRA `/adap-audit`.
|
||||
- **DELTA CLOSED (S48, executed-file):** the formal 3-ledger is now explicit — **NEW `docs/governance/error-ledger.md`** (blameless RCA seed E-001..E-004 + Active-Guards index w/ 2-strike-promote + §L.a `AS-1..AS-9` deterministic-detect table + 3-ledger triad mapping: error-ledger=NEW / comms-ledger=governance-README adoption-ledger / summary-index=STATUS+session-logs). **§L.b 6-step** wired into `.claude/commands/session-end.md` **Phase 1.5**. This was the only open gap vs the broadcast floor.
|
||||
- **DONE (was "proposed next"):** error-ledger + §L.b checklist built this session (S48). Remaining = verified-runtime (steps run for real at `/session-end` — demonstrated manually this session since command `.md` no hot-reload; auto from next session).
|
||||
- **nac honesty (S48):** core Gov-v2 5-axis + session-cmd = VERIFIED-2way (S44 RT3). Delta artifacts = **executed-file S48** (created + committed). NOT claiming the §L.b checklist `verified-runtime` until it actually runs at session-end (this session demonstrates it manually; durable/auto from next session) + AI_INFRA `/adap-audit` cross-check.
|
||||
|
||||
@ -6,10 +6,10 @@
|
||||
`2026-06-02-Memory-store-memory-strip-global` (category: Memory · reviewer_gate: PASS · targets: all-fit)
|
||||
|
||||
## 2. nac G-011
|
||||
**executed** (file-level) → **verified-pending** (runtime needs Claude Code restart — agent `.md` no hot-reload).
|
||||
**executed** (S47 file-level) → **VERIFIED-runtime** (S48 post-restart, 2026-06-02). Loaded agent-registry this session grants **0 `store_memory`** to all **8** subs (strip took effect on reload). Remaining = AI_INFRA `/adap-audit` 2-way cross-check.
|
||||
|
||||
## 3. evidence
|
||||
Stripped `mcp__rag-unified__store_memory` from `tools:` frontmatter of **ALL 7** sub-agents (SE roster):
|
||||
Stripped `mcp__rag-unified__store_memory` from `tools:` frontmatter of **ALL 7** sub-agents at S47 (SE roster); the 8th sub `frontend-designer` (added same session) was forked already-stripped → **8/8 subs clean**:
|
||||
- `.claude/agents/investigator-codebase.md`
|
||||
- `.claude/agents/investigator-api.md`
|
||||
- `.claude/agents/implementer-backend.md`
|
||||
@ -23,7 +23,7 @@ SELF-CHECK (broadcast):
|
||||
- All 7 retain ≥1 RAG-read tool: `search_memory` ×7 (+ `search_code` + `cross_project_search` + `list_projects`).
|
||||
- Doc sync: `.claude/agents/README.md` §Tool-grant "5 RAG MCP → **4 RAG-READ**" + note "lead = sole RAG-writer · sub→MEMORY.md · G-015 not-read-only".
|
||||
|
||||
commit-sha: _unpushed (working-tree) — commit batched with restart-verify._
|
||||
commit-sha: **`72bbfa5`** (committed S47). **S48 re-verify (post-restart):** `grep store_memory` in agents `tools:` lines = **0** (only body/doc-notes remain) · loaded agent-registry = 0 `store_memory` across all 8 subs.
|
||||
|
||||
## 4. tailored-gì + skip-gì-vì-sao
|
||||
- **FUNCTION-floor adopted FULLY:** `store_memory` removed **GLOBAL** (all 7 subs, no per-context variant) → lead (em main) = sole RAG-writer (mechanized, failure-safe).
|
||||
@ -32,5 +32,5 @@ commit-sha: _unpushed (working-tree) — commit batched with restart-verify._
|
||||
|
||||
## 5. honest-caveat
|
||||
- **Accuracy (G-015):** `store_memory` now un-callable by subs — this is **NOT** "subs read-only". Subs retain `Bash` (+ `Write/Edit` for the 4 write-role subs) = open write channels. Real containment = defense-in-depth (git-diff + Qdrant chunk-count monitoring), NOT allowlist alone.
|
||||
- **VERIFIED-pending:** runtime effect requires **restart** (agent `.md` no hot-reload). Pre-restart, this session's spawns would still resolve `store_memory`. Proven at **file-level only** so far. Do NOT claim `verified` — that is AI_INFRA `/adap-audit` cross-repo call.
|
||||
- **VERIFIED-runtime (S48):** restart done → loaded registry grants 0 `store_memory` to all 8 subs (a spawned sub physically cannot call it this session). Upgraded from S47 file-level. Remaining external check = AI_INFRA `/adap-audit` cross-repo (2-way). **Still NOT "read-only"** (G-015) — caveat above holds: subs keep Bash/Write; containment = defense-in-depth, not allowlist alone.
|
||||
- **Aligns with SE's own prior lesson** (`feedback_store_memory_rebootstrap_protection`, S41): sub `store_memory` content was wiped on RAG re-bootstrap unless disk-twinned → centralizing RAG-write to lead removes that data-loss class. So this adopt is corroborated by SE dogfood, not just external mandate.
|
||||
|
||||
Reference in New Issue
Block a user