2 Commits

Author	SHA1	Message	Date
pqhuy1987	75df04ec82	[CLAUDE] Workflow: fix workflow picker 2 bug (P11-A Max re-review) + SetWorkflow endpoint ... Double-check chất lượng P11-A ở Max (agents trước chạy High + truncate 3×) → phát hiện 2 bug THẬT trong workflow-picker FE của WorkflowAppDetailPage (core approve/reject/return ĐÚNG, chỉ sub-flow chọn quy trình hỏng): Bug #1 (HIGH) — pinWorkflow PUT /{id} chỉ gửi {approvalWorkflowId} → UpdateDraft validator (Reason NotEmpty, NumDays>0...) fail → 400. Nút "Lưu quy trình" vỡ. Bug #2 (HIGH) — fetch workflow expect flat array nhưng endpoint trả AwAdminOverviewDto {types:[...]} → picker rỗng/crash. FE copy nhầm pattern hỏng của ProposalCreatePage thay vì PE/Contract proven. Fix: - BE: thêm endpoint chuyên dụng PUT /{id}/workflow + Set{Module}WorkflowCommand/Handler cho 4 module — chỉ set ApprovalWorkflowId trên draft Nhap/TraLai (verify ApplicableType per module), KHÔNG validate field khác. Single-responsibility, bulletproof. - FE: sửa fetch mirror PE/Contract (data.types.find(t=>t.applicableType===X)?.history .filter(isUserSelectable)) + pin gọi endpoint mới. fe-admin+fe-user SHA256 identical. - Test: +3 SetWorkflow (happy no-status-change / wrong ApplicableType Conflict / submitted guard) → 141→144 PASS. Verify: BE build 0 error · 144 test PASS · FE build ×2 · SHA256 identical. Bonus phát hiện: ProposalCreatePage (S37) có bug #2 có sẵn (latent, chưa exercise UAT) → flag spawn task riêng, KHÔNG fix trong commit này. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-05-30 10:14:34 +07:00
pqhuy1987	e7b66cd52b	[CLAUDE] Workflow: wire ApproveV2 + LevelOpinions cho 4 WorkflowApps module (Phase 11 P11-A) ... Wire full approval workflow V2 cho Leave/OT/Travel/Vehicle — cookie-cutter mirror Proposal (Mig 38). Trước đây skeleton Phase 1 (Create+List), giờ ApproveV2 advance-level + UPSERT LevelOpinion + atomic codegen. Schema (Mig 41 WireWorkflowAppsApprovalV2 — 84→89 tables, pure additive): - 4 bảng {Leave,Ot,Travel,Vehicle}LevelOpinions (UNIQUE composite + Cascade parent + Restrict Level — mirror ProposalLevelOpinion) - 1 bảng WorkflowAppCodeSequences (shared atomic MaDonTu, Prefix-keyed) - 4 cột RejectedFromStatus (smart return tracking) - enum ApprovalWorkflowApplicableType.TravelRequest = 9 Application (LeaveOt + TravelVehicle ApprovalFeatures.cs — 30 handler): - GetById detail (Include LevelOpinions + JOIN Step/Level) · UpdateDraft - Submit (gen MaDonTu + DaGuiDuyet + level=1, verify ApplicableType per module) - Approve (verify actor==ApproverUserId OR Admin, UPSERT opinion latest-write-wins, advance level OR terminal DaDuyet, empty comment → placeholder) - Reject (→TuChoi) · Return (→TraLai + RejectedFromStatus) Api: 4 controller +6 route mỗi cái (GET/{id}, PUT/{id}, submit/approve/reject/return) Infra: DbInitializer seed 4 workflow V2 mẫu (QT-NP/OT/CT/XE-V2-001) → UAT test ngay FE: WorkflowAppDetailPage.tsx declarative 4-kind (fe-admin+fe-user SHA256 identical) — workflow status + opinion timeline + action buttons; gỡ banner skeleton + row nav Tests: +11 WorkflowAppApproveV2Tests (130→141 PASS) — state machine + UPSERT invariant + guards + codegen + forbidden + placeholder (Leave full + Ot smoke) Verify: build 0 error · 141 test PASS · FE build ×2 · reviewer checklist (ApplicableType per-module + cross-module DbSet + [Authorize] — no copy-paste bug) Known-minor (unreachable): Reject/Return actor-check skip nếu CurrentApprovalLevelOrder null — nhưng DaGuiDuyet luôn có set (defer hardening). ItTicket KHÔNG đụng (kanban, no workflow V2). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-05-30 09:44:00 +07:00