[CLAUDE] App+Api+FE+Scripts: Edit detail row inline + deps audit helper
All checks were successful
Deploy SOLUTION_ERP / build-deploy (push) Successful in 2m45s

## Edit detail row inline (BE)

7 typed UpdateXxxDetailCommand handler trong ContractDetailsFeatures.cs
— pattern lặp giống Add commands, EnsureContractType guard + log
ChangelogAction.Update với summary "Sửa <hạng mục/SP/CV/...>".

7 PUT endpoints trong ContractsController:
- PUT /contracts/{id}/details/{thau-phu|giao-khoan|nha-cung-cap|dich-vu|
  mua-ban|nguyen-tac-ncc|nguyen-tac-dv}/{detailId}

## Edit detail row inline (FE)

ContractDetailsTab.tsx refactor:
- DeleteBtn → ActionBtns (Pencil + Trash) với onEdit + onDelete callbacks
- 7 XxxTable signatures + onEdit prop + pass row data via callback
- New EditRowDialog component:
  * useEffect populate form từ row data khi target thay đổi
  * Reuse FIELDS_BY_TYPE config + buildPayload (compute thanhTien)
  * Date field convert ISO → yyyy-MM-dd cho input[type=date]
  * PUT /contracts/{id}/details/{slug}/{detailId}
- Parent state editTarget — open dialog, close khi save thành công

Mirror fe-admin (file copy).

## Deps audit helper script

scripts/deps-audit.ps1 — chạy thủ công hoặc CI integration:
- dotnet list package --vulnerable --include-transitive (BE)
- npm audit --audit-level=moderate (fe-admin + fe-user)
- Color-coded output (green/red), summary cuối
- -FailOnHigh switch để CI gate

Skill ref .claude/skills/dependency-audit-erp/SKILL.md (đã có) cho
pin constraints + workflow fix.

## Build

- BE: dotnet build pass (0 error)
- fe-user: tsc + vite pass (11.52s)
- fe-admin: tsc + vite pass (577ms)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
pqhuy1987
2026-04-23 15:18:53 +07:00
parent 4edcd588d8
commit e53cd3a3b2
5 changed files with 594 additions and 80 deletions

View File

@ -276,6 +276,144 @@ public class AddNguyenTacDvDetailHandler(IApplicationDbContext db, IChangelogSer
}
}
// ========== UPDATE detail (per type — typed) ==========
// Mỗi type có handler riêng để TS strict + validation đúng schema. Pattern
// lặp giống Add commands. ID trong URL phải khớp với detail thuộc đúng
// contract + đúng type (EnsureContractType guard).
public record UpdateThauPhuDetailCommand(Guid ContractId, Guid DetailId, ThauPhuDetailDto Detail) : IRequest;
public class UpdateThauPhuDetailHandler(IApplicationDbContext db, IChangelogService changelog) : IRequestHandler<UpdateThauPhuDetailCommand>
{
public async Task Handle(UpdateThauPhuDetailCommand cmd, CancellationToken ct)
{
var contract = await EnsureContractType(db, cmd.ContractId, ContractType.HopDongThauPhu, ct);
var entity = await db.ThauPhuDetails.FirstOrDefaultAsync(x => x.Id == cmd.DetailId && x.ContractId == cmd.ContractId, ct)
?? throw new NotFoundException("ThauPhuDetail", cmd.DetailId);
var d = cmd.Detail;
entity.Order = d.Order; entity.HangMuc = d.HangMuc; entity.DonViTinh = d.DonViTinh;
entity.KhoiLuong = d.KhoiLuong; entity.DonGia = d.DonGia; entity.ThanhTien = d.ThanhTien;
entity.ThoiGianHoanThanh = d.ThoiGianHoanThanh; entity.GhiChu = d.GhiChu;
await changelog.LogDetailChangeAsync(contract.Id, entity.Id, ChangelogAction.Update,
summary: $"Sửa hạng mục: {d.HangMuc}", phaseAtChange: contract.Phase, ct: ct);
await db.SaveChangesAsync(ct);
}
}
public record UpdateGiaoKhoanDetailCommand(Guid ContractId, Guid DetailId, GiaoKhoanDetailDto Detail) : IRequest;
public class UpdateGiaoKhoanDetailHandler(IApplicationDbContext db, IChangelogService changelog) : IRequestHandler<UpdateGiaoKhoanDetailCommand>
{
public async Task Handle(UpdateGiaoKhoanDetailCommand cmd, CancellationToken ct)
{
var contract = await EnsureContractType(db, cmd.ContractId, ContractType.HopDongGiaoKhoan, ct);
var entity = await db.GiaoKhoanDetails.FirstOrDefaultAsync(x => x.Id == cmd.DetailId && x.ContractId == cmd.ContractId, ct)
?? throw new NotFoundException("GiaoKhoanDetail", cmd.DetailId);
var d = cmd.Detail;
entity.Order = d.Order; entity.MaCongViec = d.MaCongViec; entity.TenCongViec = d.TenCongViec;
entity.DonViTinh = d.DonViTinh; entity.KhoiLuong = d.KhoiLuong; entity.DonGia = d.DonGia;
entity.ThanhTien = d.ThanhTien; entity.ThoiGianHoanThanh = d.ThoiGianHoanThanh;
entity.YeuCauKyThuat = d.YeuCauKyThuat; entity.GhiChu = d.GhiChu;
await changelog.LogDetailChangeAsync(contract.Id, entity.Id, ChangelogAction.Update,
summary: $"Sửa công việc: {d.TenCongViec}", phaseAtChange: contract.Phase, ct: ct);
await db.SaveChangesAsync(ct);
}
}
public record UpdateNhaCungCapDetailCommand(Guid ContractId, Guid DetailId, NhaCungCapDetailDto Detail) : IRequest;
public class UpdateNhaCungCapDetailHandler(IApplicationDbContext db, IChangelogService changelog) : IRequestHandler<UpdateNhaCungCapDetailCommand>
{
public async Task Handle(UpdateNhaCungCapDetailCommand cmd, CancellationToken ct)
{
var contract = await EnsureContractType(db, cmd.ContractId, ContractType.HopDongNhaCungCap, ct);
var entity = await db.NhaCungCapDetails.FirstOrDefaultAsync(x => x.Id == cmd.DetailId && x.ContractId == cmd.ContractId, ct)
?? throw new NotFoundException("NhaCungCapDetail", cmd.DetailId);
var d = cmd.Detail;
entity.Order = d.Order; entity.MaSP = d.MaSP; entity.TenSP = d.TenSP;
entity.ThongSoKyThuat = d.ThongSoKyThuat; entity.DonViTinh = d.DonViTinh;
entity.SoLuong = d.SoLuong; entity.DonGia = d.DonGia; entity.ThanhTien = d.ThanhTien;
entity.ThoiGianGiao = d.ThoiGianGiao; entity.XuatXu = d.XuatXu; entity.GhiChu = d.GhiChu;
await changelog.LogDetailChangeAsync(contract.Id, entity.Id, ChangelogAction.Update,
summary: $"Sửa SP: {d.TenSP}", phaseAtChange: contract.Phase, ct: ct);
await db.SaveChangesAsync(ct);
}
}
public record UpdateDichVuDetailCommand(Guid ContractId, Guid DetailId, DichVuDetailDto Detail) : IRequest;
public class UpdateDichVuDetailHandler(IApplicationDbContext db, IChangelogService changelog) : IRequestHandler<UpdateDichVuDetailCommand>
{
public async Task Handle(UpdateDichVuDetailCommand cmd, CancellationToken ct)
{
var contract = await EnsureContractType(db, cmd.ContractId, ContractType.HopDongDichVu, ct);
var entity = await db.DichVuDetails.FirstOrDefaultAsync(x => x.Id == cmd.DetailId && x.ContractId == cmd.ContractId, ct)
?? throw new NotFoundException("DichVuDetail", cmd.DetailId);
var d = cmd.Detail;
entity.Order = d.Order; entity.MaDichVu = d.MaDichVu; entity.TenDichVu = d.TenDichVu;
entity.MoTa = d.MoTa; entity.DonViTinh = d.DonViTinh; entity.ThoiGian = d.ThoiGian;
entity.DonGia = d.DonGia; entity.ThanhTien = d.ThanhTien;
entity.TuNgay = d.TuNgay; entity.DenNgay = d.DenNgay; entity.GhiChu = d.GhiChu;
await changelog.LogDetailChangeAsync(contract.Id, entity.Id, ChangelogAction.Update,
summary: $"Sửa DV: {d.TenDichVu}", phaseAtChange: contract.Phase, ct: ct);
await db.SaveChangesAsync(ct);
}
}
public record UpdateMuaBanDetailCommand(Guid ContractId, Guid DetailId, MuaBanDetailDto Detail) : IRequest;
public class UpdateMuaBanDetailHandler(IApplicationDbContext db, IChangelogService changelog) : IRequestHandler<UpdateMuaBanDetailCommand>
{
public async Task Handle(UpdateMuaBanDetailCommand cmd, CancellationToken ct)
{
var contract = await EnsureContractType(db, cmd.ContractId, ContractType.HopDongMuaBan, ct);
var entity = await db.MuaBanDetails.FirstOrDefaultAsync(x => x.Id == cmd.DetailId && x.ContractId == cmd.ContractId, ct)
?? throw new NotFoundException("MuaBanDetail", cmd.DetailId);
var d = cmd.Detail;
entity.Order = d.Order; entity.MaSP = d.MaSP; entity.TenSP = d.TenSP;
entity.MoTa = d.MoTa; entity.DonViTinh = d.DonViTinh;
entity.SoLuong = d.SoLuong; entity.DonGia = d.DonGia;
entity.ThueVAT = d.ThueVAT; entity.ThanhTien = d.ThanhTien;
entity.XuatXu = d.XuatXu; entity.GhiChu = d.GhiChu;
await changelog.LogDetailChangeAsync(contract.Id, entity.Id, ChangelogAction.Update,
summary: $"Sửa SP: {d.TenSP}", phaseAtChange: contract.Phase, ct: ct);
await db.SaveChangesAsync(ct);
}
}
public record UpdateNguyenTacNccDetailCommand(Guid ContractId, Guid DetailId, NguyenTacNccDetailDto Detail) : IRequest;
public class UpdateNguyenTacNccDetailHandler(IApplicationDbContext db, IChangelogService changelog) : IRequestHandler<UpdateNguyenTacNccDetailCommand>
{
public async Task Handle(UpdateNguyenTacNccDetailCommand cmd, CancellationToken ct)
{
var contract = await EnsureContractType(db, cmd.ContractId, ContractType.HopDongNguyenTacNCC, ct);
var entity = await db.NguyenTacNccDetails.FirstOrDefaultAsync(x => x.Id == cmd.DetailId && x.ContractId == cmd.ContractId, ct)
?? throw new NotFoundException("NguyenTacNccDetail", cmd.DetailId);
var d = cmd.Detail;
entity.Order = d.Order; entity.NhomSP = d.NhomSP; entity.TenSP = d.TenSP;
entity.DonViTinh = d.DonViTinh; entity.DonGiaToiThieu = d.DonGiaToiThieu;
entity.DonGiaToiDa = d.DonGiaToiDa; entity.DieuKienGiaoHang = d.DieuKienGiaoHang;
entity.DieuKienThanhToan = d.DieuKienThanhToan; entity.GhiChu = d.GhiChu;
await changelog.LogDetailChangeAsync(contract.Id, entity.Id, ChangelogAction.Update,
summary: $"Sửa SP nguyên tắc: {d.TenSP}", phaseAtChange: contract.Phase, ct: ct);
await db.SaveChangesAsync(ct);
}
}
public record UpdateNguyenTacDvDetailCommand(Guid ContractId, Guid DetailId, NguyenTacDvDetailDto Detail) : IRequest;
public class UpdateNguyenTacDvDetailHandler(IApplicationDbContext db, IChangelogService changelog) : IRequestHandler<UpdateNguyenTacDvDetailCommand>
{
public async Task Handle(UpdateNguyenTacDvDetailCommand cmd, CancellationToken ct)
{
var contract = await EnsureContractType(db, cmd.ContractId, ContractType.HopDongNguyenTacDichVu, ct);
var entity = await db.NguyenTacDvDetails.FirstOrDefaultAsync(x => x.Id == cmd.DetailId && x.ContractId == cmd.ContractId, ct)
?? throw new NotFoundException("NguyenTacDvDetail", cmd.DetailId);
var d = cmd.Detail;
entity.Order = d.Order; entity.LoaiDichVu = d.LoaiDichVu; entity.TenDichVu = d.TenDichVu;
entity.DonViTinh = d.DonViTinh; entity.DonGiaToiThieu = d.DonGiaToiThieu;
entity.DonGiaToiDa = d.DonGiaToiDa; entity.PhamViDichVu = d.PhamViDichVu;
entity.SLA = d.SLA; entity.GhiChu = d.GhiChu;
await changelog.LogDetailChangeAsync(contract.Id, entity.Id, ChangelogAction.Update,
summary: $"Sửa DV nguyên tắc: {d.TenDichVu}", phaseAtChange: contract.Phase, ct: ct);
await db.SaveChangesAsync(ct);
}
}
// ========== DELETE detail (generic — dispatch theo Type) ==========
public record DeleteContractDetailCommand(Guid ContractId, Guid DetailId) : IRequest;