[CLAUDE] Tests Phase 1: Domain unit tests + CI gate (xUnit + FluentAssertions)
All checks were successful
Deploy SOLUTION_ERP / build-deploy (push) Successful in 3m25s
All checks were successful
Deploy SOLUTION_ERP / build-deploy (push) Successful in 3m25s
Phase 1 (MVP) — chống regression Workflow state machine. 54 test pure function (no DB / IO), all pass < 7 giây. Test project: - tests/SolutionErp.Domain.Tests/ (xUnit 2.9.3 + FluentAssertions 7.2 — pin trước v8 commercial license) - ProjectReference SolutionErp.Domain - Added vào SolutionErp.slnx folder /tests/ Test files: - Contracts/WorkflowPolicyTests.cs (~17 test): - Standard policy 9-phase: role transitions, CCM check, BOD signing, terminal - SkipCcm policy 7-phase: bypass CCM verify, no DangKiemTraCCM transition - Registry: DefaultPolicyName per ContractType (7 type), bypass flag override - FromDefinition versioned: build từ ordered steps + reject path + TuChoi auto-add + UserKindApprover populate UserTransitions - PurchaseEvaluations/PurchaseEvaluationPolicyTests.cs (~17 test): - NccOnly (A) 3-step: skip ChoDuAn + ChoCEODuyetPA, CCM đẩy thẳng CEO duyệt NCC - NccWithPlan (B) 5-step: có ChoDuAn (PM) + ChoCEODuyetPA (Director) trước - Reject path cả 2 quy trình về DangSoanThao - Registry mapping per PEType - Budgets/BudgetPolicyTests.cs (~13 test): - Default 3-step (Drafter→CCM→CEO) role guard - Reject paths về DangSoanThao - DaDuyet + TuChoi terminal (no NextPhases) - SLA spec 5d/3d/2d cho 3 phase đầu CI gate (.gitea/workflows/deploy.yml): - Step "Run unit tests (Domain)" thêm TRƯỚC build/publish/deploy - Test fail (LASTEXITCODE != 0) → exit → KHÔNG deploy - TRX log saved + upload artifact (continue-on-error nếu Gitea runner thiếu actions/upload-artifact) Verify local: - dotnet test tests/SolutionErp.Domain.Tests → Total tests: 54 / Passed: 54 / 6.4s - dotnet build SolutionErp.slnx (full solution incl. test project) → 0 error Phase 2-5 pending (xem plan ở chat): - Code generator atomic concurrency tests (Infra) - DbInitializer reconcile drift tests (Infra) - Application handler smoke tests (CQRS) với EF InMemory - API smoke tests qua WebApplicationFactory - FE Vitest cho lib utility (queryMatches, fmtMoney) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
pqhuy1987
227
tests/SolutionErp.Domain.Tests/Contracts/WorkflowPolicyTests.cs
Normal file
227
tests/SolutionErp.Domain.Tests/Contracts/WorkflowPolicyTests.cs
Normal file
@ -0,0 +1,227 @@
|
||||
using SolutionErp.Domain.Contracts;
|
||||
using SolutionErp.Domain.Identity;
|
||||
|
||||
namespace SolutionErp.Domain.Tests.Contracts;
|
||||
|
||||
// Tests for WorkflowPolicy state machine — pure functions, no DB / IO.
|
||||
// Mục tiêu: chống regression khi policy table bị edit nhầm hoặc khi ContractPhase
|
||||
// enum thêm phase mới mà quên update policy. ALL fast in-memory.
|
||||
|
||||
public class WorkflowPolicyTests
|
||||
{
|
||||
// ===== Standard policy (HĐ Thầu phụ / NCC / Giao khoán — full CCM) =====
|
||||
|
||||
[Fact]
|
||||
public void Standard_Drafter_DangSoanThao_To_DangGopY_Allowed()
|
||||
{
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangSoanThao, ContractPhase.DangGopY,
|
||||
[AppRoles.Drafter])
|
||||
.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_DeptManager_DangSoanThao_To_DangGopY_Allowed()
|
||||
{
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangSoanThao, ContractPhase.DangGopY,
|
||||
[AppRoles.DeptManager])
|
||||
.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_RandomRole_DangSoanThao_To_DangGopY_Denied()
|
||||
{
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangSoanThao, ContractPhase.DangGopY,
|
||||
[AppRoles.Procurement])
|
||||
.Should().BeFalse();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_HasCcmPhase_InActivePhases()
|
||||
{
|
||||
WorkflowPolicies.Standard.HasPhase(ContractPhase.DangKiemTraCCM)
|
||||
.Should().BeTrue("Standard policy phải có CCM phase");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_CcmRole_DangKiemTraCCM_To_DangTrinhKy_Allowed()
|
||||
{
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangKiemTraCCM, ContractPhase.DangTrinhKy,
|
||||
[AppRoles.CostControl])
|
||||
.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_DangTrinhKy_To_DangDongDau_RequiresDirectorOrSigner()
|
||||
{
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangTrinhKy, ContractPhase.DangDongDau,
|
||||
[AppRoles.Director])
|
||||
.Should().BeTrue();
|
||||
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangTrinhKy, ContractPhase.DangDongDau,
|
||||
[AppRoles.AuthorizedSigner])
|
||||
.Should().BeTrue();
|
||||
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangTrinhKy, ContractPhase.DangDongDau,
|
||||
[AppRoles.CostControl])
|
||||
.Should().BeFalse();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_HrAdmin_DangDongDau_To_DaPhatHanh_Allowed()
|
||||
{
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangDongDau, ContractPhase.DaPhatHanh,
|
||||
[AppRoles.HrAdmin])
|
||||
.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_FromTerminal_DaPhatHanh_NoFurtherTransitions()
|
||||
{
|
||||
WorkflowPolicies.Standard.NextPhasesFrom(ContractPhase.DaPhatHanh)
|
||||
.Should().BeEmpty("DaPhatHanh là terminal — không transition tiếp");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_RejectFromCCM_GoesBackToDraft()
|
||||
{
|
||||
WorkflowPolicies.Standard
|
||||
.IsTransitionAllowed(ContractPhase.DangKiemTraCCM, ContractPhase.DangSoanThao,
|
||||
[AppRoles.CostControl])
|
||||
.Should().BeTrue("CCM có quyền reject về Drafter");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Standard_NextPhasesFrom_Draft_Includes_DangGopY_And_TuChoi()
|
||||
{
|
||||
var next = WorkflowPolicies.Standard.NextPhasesFrom(ContractPhase.DangSoanThao);
|
||||
next.Should().Contain(ContractPhase.DangGopY);
|
||||
next.Should().Contain(ContractPhase.TuChoi);
|
||||
}
|
||||
|
||||
// ===== SkipCcm policy (HĐ Dịch vụ / Mua bán / Nguyên tắc — bỏ phase CCM) =====
|
||||
|
||||
[Fact]
|
||||
public void SkipCcm_DoesNotHave_DangKiemTraCCM_Phase()
|
||||
{
|
||||
WorkflowPolicies.SkipCcm.HasPhase(ContractPhase.DangKiemTraCCM)
|
||||
.Should().BeFalse("SkipCcm policy bypass CCM phase");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SkipCcm_DangInKy_GoesDirectlyTo_DangTrinhKy()
|
||||
{
|
||||
WorkflowPolicies.SkipCcm
|
||||
.IsTransitionAllowed(ContractPhase.DangInKy, ContractPhase.DangTrinhKy,
|
||||
[AppRoles.Drafter])
|
||||
.Should().BeTrue();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SkipCcm_NoTransition_To_DangKiemTraCCM()
|
||||
{
|
||||
WorkflowPolicies.SkipCcm
|
||||
.IsTransitionAllowed(ContractPhase.DangInKy, ContractPhase.DangKiemTraCCM,
|
||||
[AppRoles.Drafter])
|
||||
.Should().BeFalse();
|
||||
}
|
||||
|
||||
// ===== Registry mapping per ContractType =====
|
||||
|
||||
[Theory]
|
||||
[InlineData(ContractType.HopDongThauPhu, "Standard")]
|
||||
[InlineData(ContractType.HopDongGiaoKhoan, "Standard")]
|
||||
[InlineData(ContractType.HopDongNhaCungCap, "Standard")]
|
||||
[InlineData(ContractType.HopDongDichVu, "SkipCcm")]
|
||||
[InlineData(ContractType.HopDongMuaBan, "SkipCcm")]
|
||||
[InlineData(ContractType.HopDongNguyenTacNCC, "SkipCcm")]
|
||||
[InlineData(ContractType.HopDongNguyenTacDichVu, "SkipCcm")]
|
||||
public void Registry_DefaultPolicyName_MapsCorrectly(ContractType type, string expectedName)
|
||||
{
|
||||
WorkflowPolicyRegistry.DefaultPolicyNameFor(type)
|
||||
.Should().Be(expectedName);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Registry_ForContract_BypassFlag_OverridesPolicy()
|
||||
{
|
||||
var contract = new Contract
|
||||
{
|
||||
Type = ContractType.HopDongThauPhu, // mặc định Standard
|
||||
BypassProcurementAndCCM = true, // override → SkipCcm
|
||||
};
|
||||
WorkflowPolicyRegistry.ForContract(contract).Name
|
||||
.Should().Be("SkipCcm");
|
||||
}
|
||||
|
||||
// ===== FromDefinition (versioned admin-authored) =====
|
||||
|
||||
[Fact]
|
||||
public void FromDefinition_BuildsPolicy_FromOrderedSteps()
|
||||
{
|
||||
var def = new WorkflowDefinition
|
||||
{
|
||||
Code = "QT-TEST",
|
||||
Version = 1,
|
||||
Name = "Test workflow",
|
||||
ContractType = ContractType.HopDongMuaBan,
|
||||
Steps =
|
||||
[
|
||||
new WorkflowStep { Order = 1, Phase = ContractPhase.DangSoanThao, Name = "Soạn",
|
||||
Approvers = [new WorkflowStepApprover { Kind = WorkflowApproverKind.Role, AssignmentValue = AppRoles.Drafter }] },
|
||||
new WorkflowStep { Order = 2, Phase = ContractPhase.DangGopY, Name = "Góp ý",
|
||||
Approvers = [new WorkflowStepApprover { Kind = WorkflowApproverKind.Role, AssignmentValue = AppRoles.ProjectManager }] },
|
||||
new WorkflowStep { Order = 3, Phase = ContractPhase.DaPhatHanh, Name = "Phát hành",
|
||||
Approvers = [new WorkflowStepApprover { Kind = WorkflowApproverKind.Role, AssignmentValue = AppRoles.HrAdmin }] },
|
||||
],
|
||||
};
|
||||
var policy = WorkflowPolicyRegistry.FromDefinition(def);
|
||||
|
||||
policy.Name.Should().Be("QT-TEST-v01");
|
||||
policy.IsTransitionAllowed(ContractPhase.DangSoanThao, ContractPhase.DangGopY, [AppRoles.ProjectManager])
|
||||
.Should().BeTrue();
|
||||
policy.IsTransitionAllowed(ContractPhase.DangGopY, ContractPhase.DaPhatHanh, [AppRoles.HrAdmin])
|
||||
.Should().BeTrue();
|
||||
policy.HasPhase(ContractPhase.TuChoi).Should().BeTrue("TuChoi luôn auto-thêm vào ActivePhases");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FromDefinition_UserKindApprover_PopulatesUserTransitions()
|
||||
{
|
||||
var userId = Guid.NewGuid().ToString();
|
||||
var def = new WorkflowDefinition
|
||||
{
|
||||
Code = "QT-TEST",
|
||||
Version = 1,
|
||||
Name = "Test workflow user-kind",
|
||||
ContractType = ContractType.HopDongMuaBan,
|
||||
Steps =
|
||||
[
|
||||
new WorkflowStep { Order = 1, Phase = ContractPhase.DangSoanThao, Name = "Soạn", Approvers = [] },
|
||||
new WorkflowStep { Order = 2, Phase = ContractPhase.DangGopY, Name = "Góp ý",
|
||||
Approvers = [new WorkflowStepApprover { Kind = WorkflowApproverKind.User, AssignmentValue = userId }] },
|
||||
],
|
||||
};
|
||||
var policy = WorkflowPolicyRegistry.FromDefinition(def);
|
||||
|
||||
// Role nào cũng deny vì step 2 chỉ có User-kind
|
||||
policy.IsTransitionAllowed(ContractPhase.DangSoanThao, ContractPhase.DangGopY,
|
||||
[AppRoles.Drafter])
|
||||
.Should().BeFalse();
|
||||
// Đúng user-id → allow
|
||||
policy.IsTransitionAllowed(ContractPhase.DangSoanThao, ContractPhase.DangGopY,
|
||||
[AppRoles.Drafter], Guid.Parse(userId))
|
||||
.Should().BeTrue();
|
||||
// Sai user-id → deny
|
||||
policy.IsTransitionAllowed(ContractPhase.DangSoanThao, ContractPhase.DangGopY,
|
||||
[AppRoles.Drafter], Guid.NewGuid())
|
||||
.Should().BeFalse();
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user