[CLAUDE] Backout: Chunk D — K5 cleanup F2 zombie endpoint + UsersPage column + DTO field

Reviewer K2 Major #1: PATCH /api/users/{id}/allow-skip-final endpoint Admin tick =
NoOp swallow silent (K1 sentinel → confusion UX). Full backout Plan D S22 stack:

BE drop (7 files):
- UsersController.cs: DELETE PATCH /allow-skip-final endpoint + SetAllowDrafterSkipToFinalBody record
- UserFeatures.cs: DELETE SetUserAllowDrafterSkipToFinalCommand + Handler
                    + UserDto.AllowDrafterSkipToFinal field
                    + list/get DTO mapping sentinel-false references
- ApprovalWorkflow.cs: REWRITE stale narrative line 78-80 (Reviewer Major #2 Mig 31 semantic)
                       + docstring AllowApproverSkipToFinal line 108 clean stale Users storage ref
- PurchaseEvaluationFeatures.cs: REWRITE Command DTO comment line 401 (Reviewer Minor #3)
- ApprovalWorkflowConfiguration.cs: APPEND Mig 31 narrative line 22-24 (Reviewer Minor #4)
                                     + clean storage move comment line 87
- ApprovalWorkflowV2AdminFeatures.cs: clean DTO comment line 58 stale "F2 xuống User table"
- IPurchaseEvaluationWorkflowService.cs + PurchaseEvaluationDtos.cs: clean stale
  "storage Users.AllowDrafterSkipToFinal" comments

FE Admin drop (2 files):
- UsersPage.tsx: DELETE "Skip cuối" column + FastForward badge + FastForward import
                  + allowSkipMut mutation hook + FastForward toggle button
- types/users.ts: DELETE allowDrafterSkipToFinal field

fe-user KHÔNG đụng (no UsersPage admin-only; K6 sẽ handle Workspace Drafter checkbox).
FE Designer page KHÔNG đụng (K3 done; 2 stale comment leftover deferred K6).

Plan K refactor F2 storage Users → Levels (Mig 31) complete cumulative cleanup.
Pattern reusable: post-refactor full cleanup (BE endpoint + Command + DTO + FE column
+ types + stale narratives) atomic 1 commit thay vì leak zombie state.

Verify:
- dotnet build production projects 0 err (2 pre-existing DocxRenderer warn)
- npm build fe-admin 0 TS err (no new warning)
- Grep AllowDrafterSkipToFinal + allow-skip-final + allowDrafterSkipToFinal zero results
  across src/Backend (excl Migrations history) + fe-admin/src

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
pqhuy1987
2026-05-14 23:27:12 +07:00
parent dd52d16ca9
commit 2ea8977d0f
11 changed files with 37 additions and 92 deletions

View File

@ -75,8 +75,9 @@ public class ApprovalWorkflowLevel : BaseEntity
// tick stick per Level row (KHÔNG còn workflow-level cũ Mig 28).
//
// F1 (4 mode Trả lại) + F3 (Edit Section 2) = quyền của Approver Level.
// F2 (Drafter skip) đã move sang Users.AllowDrafterSkipToFinal (per-Drafter
// user — không liên quan slot Approver).
// F2 đã move xuống Level slot này (Mig 31 — xem prop AllowApproverSkipToFinal).
// Semantic mới: Approver during ChoDuyet skip thẳng Cấp cuối (admin opt-in
// per slot, KHÔNG còn per-Drafter user scope cũ).
//
// Backfill Mig 29: copy từ workflow-level Allow* cũ → all Levels của workflow.
// Default backward compat: AllowReturnToDrafter=true (S17 fallback). 4 flag
@ -104,12 +105,12 @@ public class ApprovalWorkflowLevel : BaseEntity
/// Nháp/Trả lại — flag này CHỈ mở thêm scope cho Approver ChoDuyet.
public bool AllowApproverEditBudget { get; set; }
/// F2 (Mig 31 — S23 t1 Plan K) — REFACTOR semantic + storage từ
/// `Users.AllowDrafterSkipToFinal`. Cho phép NV slot này (khi đang duyệt
/// ChoDuyet) Approve skip thẳng Cấp cuối, bỏ qua mọi Bước/Cấp trung gian
/// còn lại. Default false (admin opt-in per slot). Mirror F3+F4 admin opt-in
/// per-Approver pattern (Mig 29 + Mig 30) reinforced 3× cumulative.
/// NO BACKFILL — 4 prod user lose value cũ per bro Option A.
/// F2 (Mig 31 — S23 t1 Plan K) — REFACTOR semantic + storage từ per-Drafter
/// (cũ Mig 29 ở Users table, đã DROP) sang per-Approver slot. Cho phép NV slot
/// này (khi đang duyệt ChoDuyet) Approve skip thẳng Cấp cuối, bỏ qua mọi
/// Bước/Cấp trung gian còn lại. Default false (admin opt-in per slot).
/// Mirror F3+F4 admin opt-in per-Approver pattern (Mig 29 + Mig 30)
/// reinforced 3× cumulative. NO BACKFILL — 4 prod user lose value cũ per bro Option A.
public bool AllowApproverSkipToFinal { get; set; }
public ApprovalWorkflowStep? Step { get; set; }